Browse code

Better logging for swarm tests

Call helper for starting swarm agents and add some logging with daemon
id's when joining the swarm.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit b0fe0dff7a5b7f70e2d08e59f4773c40e48e5c0d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Brian Goff authored on 2019/07/25 05:02:54
Showing 1 changed files
... ...
@@ -47,6 +47,9 @@ func (d *Daemon) StartAndSwarmInit(t testingT) {
47 47
 
48 48
 // StartAndSwarmJoin starts the daemon (with busybox) and join the specified swarm as worker or manager
49 49
 func (d *Daemon) StartAndSwarmJoin(t testingT, leader *Daemon, manager bool) {
50
+	if th, ok := t.(test.HelperT); ok {
51
+		th.Helper()
52
+	}
50 53
 	d.StartNode(t)
51 54
 
52 55
 	tokens := leader.JoinTokens(t)
... ...
@@ -54,6 +57,7 @@ func (d *Daemon) StartAndSwarmJoin(t testingT, leader *Daemon, manager bool) {
54 54
 	if manager {
55 55
 		token = tokens.Manager
56 56
 	}
57
+	t.Logf("[%s] joining swarm manager [%s]@%s, swarm listen addr %s", d.id, leader.id, leader.SwarmListenAddr(), d.SwarmListenAddr())
57 58
 	d.SwarmJoin(t, swarm.JoinRequest{
58 59
 		RemoteAddrs: []string{leader.SwarmListenAddr()},
59 60
 		JoinToken:   token,
... ...
@@ -106,7 +110,7 @@ func (d *Daemon) SwarmJoin(t assert.TestingT, req swarm.JoinRequest) {
106 106
 	cli := d.NewClientT(t)
107 107
 	defer cli.Close()
108 108
 	err := cli.SwarmJoin(context.Background(), req)
109
-	assert.NilError(t, err, "initializing swarm")
109
+	assert.NilError(t, err, "[%s] joining swarm", d.id)
110 110
 	d.CachedInfo = d.Info(t)
111 111
 }
112 112