Browse code

Fix golint warnings

Signed-off-by: Alexander Morozov <lk4d4@docker.com>

Alexander Morozov authored on 2015/11/03 01:02:25
Showing 6 changed files
... ...
@@ -44,10 +44,9 @@ func (graph *Graph) depth(img *image.Image) (int, error) {
44 44
 	return count, nil
45 45
 }
46 46
 
47
-// Set the max depth to the aufs default that most
48
-// kernels are compiled with
47
+// Set the max depth to the aufs default that most kernels are compiled with.
49 48
 // For more information see: http://sourceforge.net/p/aufs/aufs3-standalone/ci/aufs3.12/tree/config.mk
50
-const MaxImageDepth = 127
49
+const maxImageDepth = 127
51 50
 
52 51
 // CheckDepth returns an error if the depth of an image, as returned
53 52
 // by ImageDepth, is too large to support creating a container from it
... ...
@@ -59,8 +58,8 @@ func (graph *Graph) CheckDepth(img *image.Image) error {
59 59
 	if err != nil {
60 60
 		return err
61 61
 	}
62
-	if depth+2 >= MaxImageDepth {
63
-		return fmt.Errorf("Cannot create container with more than %d parents", MaxImageDepth)
62
+	if depth+2 >= maxImageDepth {
63
+		return fmt.Errorf("Cannot create container with more than %d parents", maxImageDepth)
64 64
 	}
65 65
 	return nil
66 66
 }
... ...
@@ -8,7 +8,7 @@ package devicemapper
8 8
 */
9 9
 import "C"
10 10
 
11
-// LibraryDeferredRemovalsupport is supported when statically linked.
11
+// LibraryDeferredRemovalSupport is supported when statically linked.
12 12
 const LibraryDeferredRemovalSupport = true
13 13
 
14 14
 func dmTaskDeferredRemoveFct(task *cdmTask) int {
... ...
@@ -589,7 +589,7 @@ var Usage = func() {
589 589
 	PrintDefaults()
590 590
 }
591 591
 
592
-// Usage prints to standard error a usage message documenting the standard command layout
592
+// ShortUsage prints to standard error a usage message documenting the standard command layout
593 593
 // The function is a variable that may be changed to point to a custom function.
594 594
 var ShortUsage = func() {
595 595
 	fmt.Fprintf(CommandLine.output, "Usage of %s:\n", os.Args[0])
... ...
@@ -34,7 +34,7 @@ func TruncateID(id string) string {
34 34
 
35 35
 func generateID(crypto bool) string {
36 36
 	b := make([]byte, 32)
37
-	var r io.Reader = random.Reader
37
+	r := random.Reader
38 38
 	if crypto {
39 39
 		r = rand.Reader
40 40
 	}
... ...
@@ -146,7 +146,7 @@ var (
146 146
 	}
147 147
 )
148 148
 
149
-// TarSum default is "sha256"
149
+// DefaultTHash is default TarSum hashing algoritm - "sha256".
150 150
 var DefaultTHash = NewTHash("sha256", sha256.New)
151 151
 
152 152
 type simpleTHash struct {
... ...
@@ -47,8 +47,9 @@ var clientCipherSuites = []uint16{
47 47
 	tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
48 48
 }
49 49
 
50
-// For use by code which already has a crypto/tls options struct but wants to
51
-// use a commonly accepted set of TLS cipher suites, with known weak algorithms removed
50
+// DefaultServerAcceptedCiphers should be uses by code which already has a crypto/tls
51
+// options struct but wants to use a commonly accepted set of TLS cipher suites, with
52
+// known weak algorithms removed.
52 53
 var DefaultServerAcceptedCiphers = append(clientCipherSuites, acceptedCBCCiphers...)
53 54
 
54 55
 // ServerDefault is a secure-enough TLS configuration for the server TLS configuration.