Signed-off-by: Mohammed Aaqib Ansari <maaquib@gmail.com>
| ... | ... |
@@ -39,12 +39,8 @@ func (s *DockerSuite) TestEventsTimestampFormats(c *check.C) {
|
| 39 | 39 |
since, until := f(start), f(end) |
| 40 | 40 |
out, _ := dockerCmd(c, "events", "--since="+since, "--until="+until) |
| 41 | 41 |
events := strings.Split(strings.TrimSpace(out), "\n") |
| 42 |
- if len(events) != 2 {
|
|
| 43 |
- c.Fatalf("unexpected events, was expecting only 2 events tag/untag (since=%s, until=%s) out=%s", since, until, out)
|
|
| 44 |
- } |
|
| 45 |
- if !strings.Contains(out, "untag") {
|
|
| 46 |
- c.Fatalf("expected 'untag' event not found (since=%s, until=%s) out=%s", since, until, out)
|
|
| 47 |
- } |
|
| 42 |
+ c.Assert(events, checker.HasLen, 2, check.Commentf("unexpected events, was expecting only 2 events tag/untag (since=%s, until=%s) out=%s", since, until, out))
|
|
| 43 |
+ c.Assert(out, checker.Contains, "untag", check.Commentf("expected 'untag' event not found (since=%s, until=%s)", since, until))
|
|
| 48 | 44 |
} |
| 49 | 45 |
|
| 50 | 46 |
} |
| ... | ... |
@@ -58,18 +54,15 @@ func (s *DockerSuite) TestEventsUntag(c *check.C) {
|
| 58 | 58 |
dockerCmd(c, "rmi", "utest:tag2") |
| 59 | 59 |
eventsCmd := exec.Command(dockerBinary, "events", "--since=1") |
| 60 | 60 |
out, exitCode, _, err := runCommandWithOutputForDuration(eventsCmd, time.Duration(time.Millisecond*200)) |
| 61 |
- if exitCode != 0 || err != nil {
|
|
| 62 |
- c.Fatalf("Failed to get events - exit code %d: %s", exitCode, err)
|
|
| 63 |
- } |
|
| 61 |
+ c.Assert(err, checker.IsNil) |
|
| 62 |
+ c.Assert(exitCode, checker.Equals, 0, check.Commentf("Failed to get events"))
|
|
| 64 | 63 |
events := strings.Split(out, "\n") |
| 65 | 64 |
nEvents := len(events) |
| 66 | 65 |
// The last element after the split above will be an empty string, so we |
| 67 | 66 |
// get the two elements before the last, which are the untags we're |
| 68 | 67 |
// looking for. |
| 69 | 68 |
for _, v := range events[nEvents-3 : nEvents-1] {
|
| 70 |
- if !strings.Contains(v, "untag") {
|
|
| 71 |
- c.Fatalf("event should be untag, not %#v", v)
|
|
| 72 |
- } |
|
| 69 |
+ c.Assert(v, checker.Contains, "untag", check.Commentf("event should be untag"))
|
|
| 73 | 70 |
} |
| 74 | 71 |
} |
| 75 | 72 |
|
| ... | ... |
@@ -77,25 +70,18 @@ func (s *DockerSuite) TestEventsContainerFailStartDie(c *check.C) {
|
| 77 | 77 |
|
| 78 | 78 |
out, _ := dockerCmd(c, "images", "-q") |
| 79 | 79 |
image := strings.Split(out, "\n")[0] |
| 80 |
- if _, _, err := dockerCmdWithError("run", "--name", "testeventdie", image, "blerg"); err == nil {
|
|
| 81 |
- c.Fatalf("Container run with command blerg should have failed, but it did not")
|
|
| 82 |
- } |
|
| 80 |
+ _, _, err := dockerCmdWithError("run", "--name", "testeventdie", image, "blerg")
|
|
| 81 |
+ c.Assert(err, checker.NotNil, check.Commentf("Container run with command blerg should have failed, but it did not, out=%s", out))
|
|
| 83 | 82 |
|
| 84 | 83 |
out, _ = dockerCmd(c, "events", "--since=0", fmt.Sprintf("--until=%d", daemonTime(c).Unix()))
|
| 85 | 84 |
events := strings.Split(out, "\n") |
| 86 |
- if len(events) <= 1 {
|
|
| 87 |
- c.Fatalf("Missing expected event")
|
|
| 88 |
- } |
|
| 85 |
+ c.Assert(len(events), checker.GreaterThan, 1) //Missing expected event |
|
| 89 | 86 |
|
| 90 | 87 |
startEvent := strings.Fields(events[len(events)-3]) |
| 91 | 88 |
dieEvent := strings.Fields(events[len(events)-2]) |
| 92 | 89 |
|
| 93 |
- if startEvent[len(startEvent)-1] != "start" {
|
|
| 94 |
- c.Fatalf("event should be start, not %#v", startEvent)
|
|
| 95 |
- } |
|
| 96 |
- if dieEvent[len(dieEvent)-1] != "die" {
|
|
| 97 |
- c.Fatalf("event should be die, not %#v", dieEvent)
|
|
| 98 |
- } |
|
| 90 |
+ c.Assert(startEvent[len(startEvent)-1], checker.Equals, "start", check.Commentf("event should be start, not %#v", startEvent))
|
|
| 91 |
+ c.Assert(dieEvent[len(dieEvent)-1], checker.Equals, "die", check.Commentf("event should be die, not %#v", dieEvent))
|
|
| 99 | 92 |
|
| 100 | 93 |
} |
| 101 | 94 |
|
| ... | ... |
@@ -117,17 +103,13 @@ func (s *DockerSuite) TestEventsLimit(c *check.C) {
|
| 117 | 117 |
close(errChan) |
| 118 | 118 |
|
| 119 | 119 |
for err := range errChan {
|
| 120 |
- if err != nil {
|
|
| 121 |
- c.Fatalf("%q failed with error: %v", strings.Join(args, " "), err)
|
|
| 122 |
- } |
|
| 120 |
+ c.Assert(err, checker.IsNil, check.Commentf("%q failed with error", strings.Join(args, " ")))
|
|
| 123 | 121 |
} |
| 124 | 122 |
|
| 125 | 123 |
out, _ := dockerCmd(c, "events", "--since=0", fmt.Sprintf("--until=%d", daemonTime(c).Unix()))
|
| 126 | 124 |
events := strings.Split(out, "\n") |
| 127 | 125 |
nEvents := len(events) - 1 |
| 128 |
- if nEvents != 64 {
|
|
| 129 |
- c.Fatalf("events should be limited to 64, but received %d", nEvents)
|
|
| 130 |
- } |
|
| 126 |
+ c.Assert(nEvents, checker.Equals, 64, check.Commentf("events should be limited to 64, but received %d", nEvents))
|
|
| 131 | 127 |
} |
| 132 | 128 |
|
| 133 | 129 |
func (s *DockerSuite) TestEventsContainerEvents(c *check.C) {
|
| ... | ... |
@@ -136,29 +118,17 @@ func (s *DockerSuite) TestEventsContainerEvents(c *check.C) {
|
| 136 | 136 |
out, _ := dockerCmd(c, "events", "--since=0", fmt.Sprintf("--until=%d", daemonTime(c).Unix()))
|
| 137 | 137 |
events := strings.Split(out, "\n") |
| 138 | 138 |
events = events[:len(events)-1] |
| 139 |
- if len(events) < 5 {
|
|
| 140 |
- c.Fatalf("Missing expected event")
|
|
| 141 |
- } |
|
| 139 |
+ c.Assert(len(events), checker.GreaterOrEqualThan, 5) //Missing expected event |
|
| 142 | 140 |
createEvent := strings.Fields(events[len(events)-5]) |
| 143 | 141 |
attachEvent := strings.Fields(events[len(events)-4]) |
| 144 | 142 |
startEvent := strings.Fields(events[len(events)-3]) |
| 145 | 143 |
dieEvent := strings.Fields(events[len(events)-2]) |
| 146 | 144 |
destroyEvent := strings.Fields(events[len(events)-1]) |
| 147 |
- if createEvent[len(createEvent)-1] != "create" {
|
|
| 148 |
- c.Fatalf("event should be create, not %#v", createEvent)
|
|
| 149 |
- } |
|
| 150 |
- if attachEvent[len(attachEvent)-1] != "attach" {
|
|
| 151 |
- c.Fatalf("event should be attach, not %#v", attachEvent)
|
|
| 152 |
- } |
|
| 153 |
- if startEvent[len(startEvent)-1] != "start" {
|
|
| 154 |
- c.Fatalf("event should be start, not %#v", startEvent)
|
|
| 155 |
- } |
|
| 156 |
- if dieEvent[len(dieEvent)-1] != "die" {
|
|
| 157 |
- c.Fatalf("event should be die, not %#v", dieEvent)
|
|
| 158 |
- } |
|
| 159 |
- if destroyEvent[len(destroyEvent)-1] != "destroy" {
|
|
| 160 |
- c.Fatalf("event should be destroy, not %#v", destroyEvent)
|
|
| 161 |
- } |
|
| 145 |
+ c.Assert(createEvent[len(createEvent)-1], checker.Equals, "create", check.Commentf("event should be create, not %#v", createEvent))
|
|
| 146 |
+ c.Assert(attachEvent[len(attachEvent)-1], checker.Equals, "attach", check.Commentf("event should be attach, not %#v", attachEvent))
|
|
| 147 |
+ c.Assert(startEvent[len(startEvent)-1], checker.Equals, "start", check.Commentf("event should be start, not %#v", startEvent))
|
|
| 148 |
+ c.Assert(dieEvent[len(dieEvent)-1], checker.Equals, "die", check.Commentf("event should be die, not %#v", dieEvent))
|
|
| 149 |
+ c.Assert(destroyEvent[len(destroyEvent)-1], checker.Equals, "destroy", check.Commentf("event should be destroy, not %#v", destroyEvent))
|
|
| 162 | 150 |
|
| 163 | 151 |
} |
| 164 | 152 |
|
| ... | ... |
@@ -171,29 +141,17 @@ func (s *DockerSuite) TestEventsContainerEventsSinceUnixEpoch(c *check.C) {
|
| 171 | 171 |
fmt.Sprintf("--until=%d", daemonTime(c).Unix()))
|
| 172 | 172 |
events := strings.Split(out, "\n") |
| 173 | 173 |
events = events[:len(events)-1] |
| 174 |
- if len(events) < 5 {
|
|
| 175 |
- c.Fatalf("Missing expected event")
|
|
| 176 |
- } |
|
| 174 |
+ c.Assert(len(events), checker.GreaterOrEqualThan, 5) //Missing expected event |
|
| 177 | 175 |
createEvent := strings.Fields(events[len(events)-5]) |
| 178 | 176 |
attachEvent := strings.Fields(events[len(events)-4]) |
| 179 | 177 |
startEvent := strings.Fields(events[len(events)-3]) |
| 180 | 178 |
dieEvent := strings.Fields(events[len(events)-2]) |
| 181 | 179 |
destroyEvent := strings.Fields(events[len(events)-1]) |
| 182 |
- if createEvent[len(createEvent)-1] != "create" {
|
|
| 183 |
- c.Fatalf("event should be create, not %#v", createEvent)
|
|
| 184 |
- } |
|
| 185 |
- if attachEvent[len(attachEvent)-1] != "attach" {
|
|
| 186 |
- c.Fatalf("event should be attach, not %#v", attachEvent)
|
|
| 187 |
- } |
|
| 188 |
- if startEvent[len(startEvent)-1] != "start" {
|
|
| 189 |
- c.Fatalf("event should be start, not %#v", startEvent)
|
|
| 190 |
- } |
|
| 191 |
- if dieEvent[len(dieEvent)-1] != "die" {
|
|
| 192 |
- c.Fatalf("event should be die, not %#v", dieEvent)
|
|
| 193 |
- } |
|
| 194 |
- if destroyEvent[len(destroyEvent)-1] != "destroy" {
|
|
| 195 |
- c.Fatalf("event should be destroy, not %#v", destroyEvent)
|
|
| 196 |
- } |
|
| 180 |
+ c.Assert(createEvent[len(createEvent)-1], checker.Equals, "create", check.Commentf("event should be create, not %#v", createEvent))
|
|
| 181 |
+ c.Assert(attachEvent[len(attachEvent)-1], checker.Equals, "attach", check.Commentf("event should be attach, not %#v", attachEvent))
|
|
| 182 |
+ c.Assert(startEvent[len(startEvent)-1], checker.Equals, "start", check.Commentf("event should be start, not %#v", startEvent))
|
|
| 183 |
+ c.Assert(dieEvent[len(dieEvent)-1], checker.Equals, "die", check.Commentf("event should be die, not %#v", dieEvent))
|
|
| 184 |
+ c.Assert(destroyEvent[len(destroyEvent)-1], checker.Equals, "destroy", check.Commentf("event should be destroy, not %#v", destroyEvent))
|
|
| 197 | 185 |
|
| 198 | 186 |
} |
| 199 | 187 |
|
| ... | ... |
@@ -204,27 +162,17 @@ func (s *DockerSuite) TestEventsImageUntagDelete(c *check.C) {
|
| 204 | 204 |
`FROM scratch |
| 205 | 205 |
MAINTAINER "docker"`, |
| 206 | 206 |
true) |
| 207 |
- if err != nil {
|
|
| 208 |
- c.Fatal(err) |
|
| 209 |
- } |
|
| 210 |
- if err := deleteImages(name); err != nil {
|
|
| 211 |
- c.Fatal(err) |
|
| 212 |
- } |
|
| 207 |
+ c.Assert(err, checker.IsNil) |
|
| 208 |
+ c.Assert(deleteImages(name), checker.IsNil) |
|
| 213 | 209 |
out, _ := dockerCmd(c, "events", "--since=0", fmt.Sprintf("--until=%d", daemonTime(c).Unix()))
|
| 214 | 210 |
events := strings.Split(out, "\n") |
| 215 | 211 |
|
| 216 | 212 |
events = events[:len(events)-1] |
| 217 |
- if len(events) < 2 {
|
|
| 218 |
- c.Fatalf("Missing expected event")
|
|
| 219 |
- } |
|
| 213 |
+ c.Assert(len(events), checker.GreaterOrEqualThan, 2) //Missing expected event |
|
| 220 | 214 |
untagEvent := strings.Fields(events[len(events)-2]) |
| 221 | 215 |
deleteEvent := strings.Fields(events[len(events)-1]) |
| 222 |
- if untagEvent[len(untagEvent)-1] != "untag" {
|
|
| 223 |
- c.Fatalf("untag should be untag, not %#v", untagEvent)
|
|
| 224 |
- } |
|
| 225 |
- if deleteEvent[len(deleteEvent)-1] != "delete" {
|
|
| 226 |
- c.Fatalf("delete should be delete, not %#v", deleteEvent)
|
|
| 227 |
- } |
|
| 216 |
+ c.Assert(untagEvent[len(untagEvent)-1], checker.Equals, "untag", check.Commentf("untag should be untag, not %#v", untagEvent))
|
|
| 217 |
+ c.Assert(deleteEvent[len(deleteEvent)-1], checker.Equals, "delete", check.Commentf("untag should be delete, not %#v", untagEvent))
|
|
| 228 | 218 |
} |
| 229 | 219 |
|
| 230 | 220 |
func (s *DockerSuite) TestEventsImageTag(c *check.C) {
|
| ... | ... |
@@ -239,15 +187,11 @@ func (s *DockerSuite) TestEventsImageTag(c *check.C) {
|
| 239 | 239 |
fmt.Sprintf("--until=%d", daemonTime(c).Unix()))
|
| 240 | 240 |
|
| 241 | 241 |
events := strings.Split(strings.TrimSpace(out), "\n") |
| 242 |
- if len(events) != 1 {
|
|
| 243 |
- c.Fatalf("was expecting 1 event. out=%s", out)
|
|
| 244 |
- } |
|
| 242 |
+ c.Assert(events, checker.HasLen, 1, check.Commentf("was expecting 1 event. out=%s", out))
|
|
| 245 | 243 |
event := strings.TrimSpace(events[0]) |
| 246 | 244 |
expectedStr := image + ": tag" |
| 247 | 245 |
|
| 248 |
- if !strings.HasSuffix(event, expectedStr) {
|
|
| 249 |
- c.Fatalf("wrong event format. expected='%s' got=%s", expectedStr, event)
|
|
| 250 |
- } |
|
| 246 |
+ c.Assert(event, checker.HasSuffix, expectedStr, check.Commentf("wrong event format. expected='%s' got=%s", expectedStr, event))
|
|
| 251 | 247 |
|
| 252 | 248 |
} |
| 253 | 249 |
|
| ... | ... |
@@ -265,9 +209,7 @@ func (s *DockerSuite) TestEventsImagePull(c *check.C) {
|
| 265 | 265 |
events := strings.Split(strings.TrimSpace(out), "\n") |
| 266 | 266 |
event := strings.TrimSpace(events[len(events)-1]) |
| 267 | 267 |
|
| 268 |
- if !strings.HasSuffix(event, "hello-world:latest: pull") {
|
|
| 269 |
- c.Fatalf("Missing pull event - got:%q", event)
|
|
| 270 |
- } |
|
| 268 |
+ c.Assert(event, checker.HasSuffix, "hello-world:latest: pull", check.Commentf("Missing pull event - got:%q", event))
|
|
| 271 | 269 |
|
| 272 | 270 |
} |
| 273 | 271 |
|
| ... | ... |
@@ -279,12 +221,8 @@ func (s *DockerSuite) TestEventsImageImport(c *check.C) {
|
| 279 | 279 |
eventImport := make(chan struct{})
|
| 280 | 280 |
eventsCmd := exec.Command(dockerBinary, "events", "--since", strconv.FormatInt(since, 10)) |
| 281 | 281 |
stdout, err := eventsCmd.StdoutPipe() |
| 282 |
- if err != nil {
|
|
| 283 |
- c.Fatal(err) |
|
| 284 |
- } |
|
| 285 |
- if err := eventsCmd.Start(); err != nil {
|
|
| 286 |
- c.Fatal(err) |
|
| 287 |
- } |
|
| 282 |
+ c.Assert(err, checker.IsNil) |
|
| 283 |
+ c.Assert(eventsCmd.Start(), checker.IsNil) |
|
| 288 | 284 |
defer eventsCmd.Process.Kill() |
| 289 | 285 |
|
| 290 | 286 |
go func() {
|
| ... | ... |
@@ -306,9 +244,7 @@ func (s *DockerSuite) TestEventsImageImport(c *check.C) {
|
| 306 | 306 |
exec.Command(dockerBinary, "export", cleanedContainerID), |
| 307 | 307 |
exec.Command(dockerBinary, "import", "-"), |
| 308 | 308 |
) |
| 309 |
- if err != nil {
|
|
| 310 |
- c.Errorf("import failed with errors: %v, output: %q", err, out)
|
|
| 311 |
- } |
|
| 309 |
+ c.Assert(err, checker.IsNil, check.Commentf("import failed with output: %q", out))
|
|
| 312 | 310 |
newContainerID := strings.TrimSpace(out) |
| 313 | 311 |
id <- newContainerID |
| 314 | 312 |
|
| ... | ... |
@@ -328,9 +264,7 @@ func (s *DockerSuite) TestEventsFilters(c *check.C) {
|
| 328 | 328 |
for _, event := range events {
|
| 329 | 329 |
eventFields := strings.Fields(event) |
| 330 | 330 |
eventName := eventFields[len(eventFields)-1] |
| 331 |
- if ok, err := regexp.MatchString(match, eventName); err != nil || !ok {
|
|
| 332 |
- c.Fatalf("event should match %s, got %#v, err: %v", match, eventFields, err)
|
|
| 333 |
- } |
|
| 331 |
+ c.Assert(eventName, checker.Matches, match) |
|
| 334 | 332 |
} |
| 335 | 333 |
} |
| 336 | 334 |
|
| ... | ... |
@@ -345,9 +279,7 @@ func (s *DockerSuite) TestEventsFilters(c *check.C) {
|
| 345 | 345 |
|
| 346 | 346 |
// make sure we at least got 2 start events |
| 347 | 347 |
count := strings.Count(out, "start") |
| 348 |
- if count < 2 {
|
|
| 349 |
- c.Fatalf("should have had 2 start events but had %d, out: %s", count, out)
|
|
| 350 |
- } |
|
| 348 |
+ c.Assert(strings.Count(out, "start"), checker.GreaterOrEqualThan, 2, check.Commentf("should have had 2 start events but had %d, out: %s", count, out))
|
|
| 351 | 349 |
|
| 352 | 350 |
} |
| 353 | 351 |
|
| ... | ... |
@@ -365,9 +297,7 @@ func (s *DockerSuite) TestEventsFilterImageName(c *check.C) {
|
| 365 | 365 |
out, _ = dockerCmd(c, "events", fmt.Sprintf("--since=%d", since), fmt.Sprintf("--until=%d", daemonTime(c).Unix()), "--filter", fmt.Sprintf("image=%s", name))
|
| 366 | 366 |
events := strings.Split(out, "\n") |
| 367 | 367 |
events = events[:len(events)-1] |
| 368 |
- if len(events) == 0 {
|
|
| 369 |
- c.Fatalf("Expected events but found none for the image busybox:latest")
|
|
| 370 |
- } |
|
| 368 |
+ c.Assert(events, checker.Not(checker.HasLen), 0) //Expected events but found none for the image busybox:latest |
|
| 371 | 369 |
count1 := 0 |
| 372 | 370 |
count2 := 0 |
| 373 | 371 |
|
| ... | ... |
@@ -378,9 +308,8 @@ func (s *DockerSuite) TestEventsFilterImageName(c *check.C) {
|
| 378 | 378 |
count2++ |
| 379 | 379 |
} |
| 380 | 380 |
} |
| 381 |
- if count1 == 0 || count2 == 0 {
|
|
| 382 |
- c.Fatalf("Expected events from each container but got %d from %s and %d from %s", count1, container1, count2, container2)
|
|
| 383 |
- } |
|
| 381 |
+ c.Assert(count1, checker.Not(checker.Equals), 0, check.Commentf("Expected event from container but got %d from %s", count1, container1))
|
|
| 382 |
+ c.Assert(count2, checker.Not(checker.Equals), 0, check.Commentf("Expected event from container but got %d from %s", count2, container2))
|
|
| 384 | 383 |
|
| 385 | 384 |
} |
| 386 | 385 |
|
| ... | ... |
@@ -407,7 +336,7 @@ func (s *DockerSuite) TestEventsFilterLabels(c *check.C) {
|
| 407 | 407 |
|
| 408 | 408 |
for _, e := range events {
|
| 409 | 409 |
c.Assert(e, checker.Contains, container1) |
| 410 |
- c.Assert(e, check.Not(checker.Contains), container2) |
|
| 410 |
+ c.Assert(e, checker.Not(checker.Contains), container2) |
|
| 411 | 411 |
} |
| 412 | 412 |
} |
| 413 | 413 |
|
| ... | ... |
@@ -421,9 +350,7 @@ func (s *DockerSuite) TestEventsFilterImageLabels(c *check.C) {
|
| 421 | 421 |
_, err := buildImage(name, fmt.Sprintf(` |
| 422 | 422 |
FROM busybox:latest |
| 423 | 423 |
LABEL %s`, label), true) |
| 424 |
- if err != nil {
|
|
| 425 |
- c.Fatalf("Couldn't create image: %q", err)
|
|
| 426 |
- } |
|
| 424 |
+ c.Assert(err, checker.IsNil, check.Commentf("Couldn't create image"))
|
|
| 427 | 425 |
|
| 428 | 426 |
dockerCmd(c, "tag", name, "labelfiltertest:tag1") |
| 429 | 427 |
dockerCmd(c, "tag", name, "labelfiltertest:tag2") |
| ... | ... |
@@ -439,7 +366,7 @@ func (s *DockerSuite) TestEventsFilterImageLabels(c *check.C) {
|
| 439 | 439 |
events := strings.Split(strings.TrimSpace(out), "\n") |
| 440 | 440 |
|
| 441 | 441 |
// 2 events from the "docker tag" command, another one is from "docker build" |
| 442 |
- c.Assert(len(events), checker.Equals, 3, check.Commentf("Events == %s", events))
|
|
| 442 |
+ c.Assert(events, checker.HasLen, 3, check.Commentf("Events == %s", events))
|
|
| 443 | 443 |
for _, e := range events {
|
| 444 | 444 |
c.Assert(e, checker.Contains, "labelfiltertest") |
| 445 | 445 |
} |
| ... | ... |
@@ -453,9 +380,7 @@ func (s *DockerSuite) TestEventsFilterContainer(c *check.C) {
|
| 453 | 453 |
for _, name := range []string{"container_1", "container_2"} {
|
| 454 | 454 |
dockerCmd(c, "run", "--name", name, "busybox", "true") |
| 455 | 455 |
id, err := inspectField(name, "Id") |
| 456 |
- if err != nil {
|
|
| 457 |
- c.Fatal(err) |
|
| 458 |
- } |
|
| 456 |
+ c.Assert(err, checker.IsNil) |
|
| 459 | 457 |
nameID[name] = id |
| 460 | 458 |
} |
| 461 | 459 |
|
| ... | ... |
@@ -484,16 +409,12 @@ func (s *DockerSuite) TestEventsFilterContainer(c *check.C) {
|
| 484 | 484 |
// filter by names |
| 485 | 485 |
out, _ := dockerCmd(c, "events", "--since", since, "--until", until, "--filter", "container="+name) |
| 486 | 486 |
events := strings.Split(strings.TrimSuffix(out, "\n"), "\n") |
| 487 |
- if err := checkEvents(ID, events); err != nil {
|
|
| 488 |
- c.Fatal(err) |
|
| 489 |
- } |
|
| 487 |
+ c.Assert(checkEvents(ID, events), checker.IsNil) |
|
| 490 | 488 |
|
| 491 | 489 |
// filter by ID's |
| 492 | 490 |
out, _ = dockerCmd(c, "events", "--since", since, "--until", until, "--filter", "container="+ID) |
| 493 | 491 |
events = strings.Split(strings.TrimSuffix(out, "\n"), "\n") |
| 494 |
- if err := checkEvents(ID, events); err != nil {
|
|
| 495 |
- c.Fatal(err) |
|
| 496 |
- } |
|
| 492 |
+ c.Assert(checkEvents(ID, events), checker.IsNil) |
|
| 497 | 493 |
} |
| 498 | 494 |
} |
| 499 | 495 |
|
| ... | ... |
@@ -509,12 +430,8 @@ func (s *DockerSuite) TestEventsStreaming(c *check.C) {
|
| 509 | 509 |
|
| 510 | 510 |
eventsCmd := exec.Command(dockerBinary, "events", "--since", strconv.FormatInt(start, 10)) |
| 511 | 511 |
stdout, err := eventsCmd.StdoutPipe() |
| 512 |
- if err != nil {
|
|
| 513 |
- c.Fatal(err) |
|
| 514 |
- } |
|
| 515 |
- if err := eventsCmd.Start(); err != nil {
|
|
| 516 |
- c.Fatalf("failed to start 'docker events': %s", err)
|
|
| 517 |
- } |
|
| 512 |
+ c.Assert(err, checker.IsNil) |
|
| 513 |
+ c.Assert(eventsCmd.Start(), checker.IsNil, check.Commentf("failed to start 'docker events'"))
|
|
| 518 | 514 |
defer eventsCmd.Process.Kill() |
| 519 | 515 |
|
| 520 | 516 |
go func() {
|
| ... | ... |
@@ -581,15 +498,13 @@ func (s *DockerSuite) TestEventsCommit(c *check.C) {
|
| 581 | 581 |
|
| 582 | 582 |
out, _ := dockerCmd(c, "run", "-d", "busybox", "top") |
| 583 | 583 |
cID := strings.TrimSpace(out) |
| 584 |
- c.Assert(waitRun(cID), check.IsNil) |
|
| 584 |
+ c.Assert(waitRun(cID), checker.IsNil) |
|
| 585 | 585 |
|
| 586 | 586 |
dockerCmd(c, "commit", "-m", "test", cID) |
| 587 | 587 |
dockerCmd(c, "stop", cID) |
| 588 | 588 |
|
| 589 | 589 |
out, _ = dockerCmd(c, "events", "--since=0", "-f", "container="+cID, "--until="+strconv.Itoa(int(since))) |
| 590 |
- if !strings.Contains(out, " commit\n") {
|
|
| 591 |
- c.Fatalf("Missing 'commit' log event\n%s", out)
|
|
| 592 |
- } |
|
| 590 |
+ c.Assert(out, checker.Contains, " commit\n", check.Commentf("Missing 'commit' log event"))
|
|
| 593 | 591 |
} |
| 594 | 592 |
|
| 595 | 593 |
func (s *DockerSuite) TestEventsCopy(c *check.C) {
|
| ... | ... |
@@ -600,36 +515,26 @@ func (s *DockerSuite) TestEventsCopy(c *check.C) {
|
| 600 | 600 |
id, err := buildImage("cpimg", `
|
| 601 | 601 |
FROM busybox |
| 602 | 602 |
RUN echo HI > /tmp/file`, true) |
| 603 |
- if err != nil {
|
|
| 604 |
- c.Fatalf("Couldn't create image: %q", err)
|
|
| 605 |
- } |
|
| 603 |
+ c.Assert(err, checker.IsNil, check.Commentf("Couldn't create image"))
|
|
| 606 | 604 |
|
| 607 | 605 |
// Create an empty test file. |
| 608 | 606 |
tempFile, err := ioutil.TempFile("", "test-events-copy-")
|
| 609 |
- if err != nil {
|
|
| 610 |
- c.Fatal(err) |
|
| 611 |
- } |
|
| 607 |
+ c.Assert(err, checker.IsNil) |
|
| 612 | 608 |
defer os.Remove(tempFile.Name()) |
| 613 | 609 |
|
| 614 |
- if err := tempFile.Close(); err != nil {
|
|
| 615 |
- c.Fatal(err) |
|
| 616 |
- } |
|
| 610 |
+ c.Assert(tempFile.Close(), checker.IsNil) |
|
| 617 | 611 |
|
| 618 | 612 |
dockerCmd(c, "create", "--name=cptest", id) |
| 619 | 613 |
|
| 620 | 614 |
dockerCmd(c, "cp", "cptest:/tmp/file", tempFile.Name()) |
| 621 | 615 |
|
| 622 | 616 |
out, _ := dockerCmd(c, "events", "--since=0", "-f", "container=cptest", "--until="+strconv.Itoa(int(since))) |
| 623 |
- if !strings.Contains(out, " archive-path\n") {
|
|
| 624 |
- c.Fatalf("Missing 'archive-path' log event\n%s", out)
|
|
| 625 |
- } |
|
| 617 |
+ c.Assert(out, checker.Contains, " archive-path\n", check.Commentf("Missing 'archive-path' log event\n"))
|
|
| 626 | 618 |
|
| 627 | 619 |
dockerCmd(c, "cp", tempFile.Name(), "cptest:/tmp/filecopy") |
| 628 | 620 |
|
| 629 | 621 |
out, _ = dockerCmd(c, "events", "--since=0", "-f", "container=cptest", "--until="+strconv.Itoa(int(since))) |
| 630 |
- if !strings.Contains(out, " extract-to-dir\n") {
|
|
| 631 |
- c.Fatalf("Missing 'extract-to-dir' log event\n%s", out)
|
|
| 632 |
- } |
|
| 622 |
+ c.Assert(out, checker.Contains, " extract-to-dir\n", check.Commentf("Missing 'extract-to-dir' log event"))
|
|
| 633 | 623 |
} |
| 634 | 624 |
|
| 635 | 625 |
func (s *DockerSuite) TestEventsResize(c *check.C) {
|
| ... | ... |
@@ -638,19 +543,17 @@ func (s *DockerSuite) TestEventsResize(c *check.C) {
|
| 638 | 638 |
|
| 639 | 639 |
out, _ := dockerCmd(c, "run", "-d", "busybox", "top") |
| 640 | 640 |
cID := strings.TrimSpace(out) |
| 641 |
- c.Assert(waitRun(cID), check.IsNil) |
|
| 641 |
+ c.Assert(waitRun(cID), checker.IsNil) |
|
| 642 | 642 |
|
| 643 | 643 |
endpoint := "/containers/" + cID + "/resize?h=80&w=24" |
| 644 | 644 |
status, _, err := sockRequest("POST", endpoint, nil)
|
| 645 |
- c.Assert(status, check.Equals, http.StatusOK) |
|
| 646 |
- c.Assert(err, check.IsNil) |
|
| 645 |
+ c.Assert(status, checker.Equals, http.StatusOK) |
|
| 646 |
+ c.Assert(err, checker.IsNil) |
|
| 647 | 647 |
|
| 648 | 648 |
dockerCmd(c, "stop", cID) |
| 649 | 649 |
|
| 650 | 650 |
out, _ = dockerCmd(c, "events", "--since=0", "-f", "container="+cID, "--until="+strconv.Itoa(int(since))) |
| 651 |
- if !strings.Contains(out, " resize\n") {
|
|
| 652 |
- c.Fatalf("Missing 'resize' log event\n%s", out)
|
|
| 653 |
- } |
|
| 651 |
+ c.Assert(out, checker.Contains, " resize\n", check.Commentf("Missing 'resize' log event"))
|
|
| 654 | 652 |
} |
| 655 | 653 |
|
| 656 | 654 |
func (s *DockerSuite) TestEventsAttach(c *check.C) {
|
| ... | ... |
@@ -662,32 +565,27 @@ func (s *DockerSuite) TestEventsAttach(c *check.C) {
|
| 662 | 662 |
|
| 663 | 663 |
cmd := exec.Command(dockerBinary, "attach", cID) |
| 664 | 664 |
stdin, err := cmd.StdinPipe() |
| 665 |
- c.Assert(err, check.IsNil) |
|
| 665 |
+ c.Assert(err, checker.IsNil) |
|
| 666 | 666 |
defer stdin.Close() |
| 667 | 667 |
stdout, err := cmd.StdoutPipe() |
| 668 |
- c.Assert(err, check.IsNil) |
|
| 668 |
+ c.Assert(err, checker.IsNil) |
|
| 669 | 669 |
defer stdout.Close() |
| 670 |
- c.Assert(cmd.Start(), check.IsNil) |
|
| 670 |
+ c.Assert(cmd.Start(), checker.IsNil) |
|
| 671 | 671 |
defer cmd.Process.Kill() |
| 672 | 672 |
|
| 673 | 673 |
// Make sure we're done attaching by writing/reading some stuff |
| 674 |
- if _, err := stdin.Write([]byte("hello\n")); err != nil {
|
|
| 675 |
- c.Fatal(err) |
|
| 676 |
- } |
|
| 674 |
+ _, err = stdin.Write([]byte("hello\n"))
|
|
| 675 |
+ c.Assert(err, checker.IsNil) |
|
| 677 | 676 |
out, err = bufio.NewReader(stdout).ReadString('\n')
|
| 678 |
- c.Assert(err, check.IsNil) |
|
| 679 |
- if strings.TrimSpace(out) != "hello" {
|
|
| 680 |
- c.Fatalf("expected 'hello', got %q", out)
|
|
| 681 |
- } |
|
| 677 |
+ c.Assert(err, checker.IsNil) |
|
| 678 |
+ c.Assert(strings.TrimSpace(out), checker.Equals, "hello", check.Commentf("expected 'hello'"))
|
|
| 682 | 679 |
|
| 683 |
- c.Assert(stdin.Close(), check.IsNil) |
|
| 680 |
+ c.Assert(stdin.Close(), checker.IsNil) |
|
| 684 | 681 |
|
| 685 | 682 |
dockerCmd(c, "stop", cID) |
| 686 | 683 |
|
| 687 | 684 |
out, _ = dockerCmd(c, "events", "--since=0", "-f", "container="+cID, "--until="+strconv.Itoa(int(since))) |
| 688 |
- if !strings.Contains(out, " attach\n") {
|
|
| 689 |
- c.Fatalf("Missing 'attach' log event\n%s", out)
|
|
| 690 |
- } |
|
| 685 |
+ c.Assert(out, checker.Contains, " attach\n", check.Commentf("Missing 'attach' log event"))
|
|
| 691 | 686 |
} |
| 692 | 687 |
|
| 693 | 688 |
func (s *DockerSuite) TestEventsRename(c *check.C) {
|
| ... | ... |
@@ -698,9 +596,7 @@ func (s *DockerSuite) TestEventsRename(c *check.C) {
|
| 698 | 698 |
dockerCmd(c, "rename", "oldName", "newName") |
| 699 | 699 |
|
| 700 | 700 |
out, _ := dockerCmd(c, "events", "--since=0", "-f", "container=newName", "--until="+strconv.Itoa(int(since))) |
| 701 |
- if !strings.Contains(out, " rename\n") {
|
|
| 702 |
- c.Fatalf("Missing 'rename' log event\n%s", out)
|
|
| 703 |
- } |
|
| 701 |
+ c.Assert(out, checker.Contains, " rename\n", check.Commentf("Missing 'rename' log event\n"))
|
|
| 704 | 702 |
} |
| 705 | 703 |
|
| 706 | 704 |
func (s *DockerSuite) TestEventsTop(c *check.C) {
|
| ... | ... |
@@ -709,15 +605,13 @@ func (s *DockerSuite) TestEventsTop(c *check.C) {
|
| 709 | 709 |
|
| 710 | 710 |
out, _ := dockerCmd(c, "run", "-d", "busybox", "top") |
| 711 | 711 |
cID := strings.TrimSpace(out) |
| 712 |
- c.Assert(waitRun(cID), check.IsNil) |
|
| 712 |
+ c.Assert(waitRun(cID), checker.IsNil) |
|
| 713 | 713 |
|
| 714 | 714 |
dockerCmd(c, "top", cID) |
| 715 | 715 |
dockerCmd(c, "stop", cID) |
| 716 | 716 |
|
| 717 | 717 |
out, _ = dockerCmd(c, "events", "--since=0", "-f", "container="+cID, "--until="+strconv.Itoa(int(since))) |
| 718 |
- if !strings.Contains(out, " top\n") {
|
|
| 719 |
- c.Fatalf("Missing 'top' log event\n%s", out)
|
|
| 720 |
- } |
|
| 718 |
+ c.Assert(out, checker.Contains, " top\n", check.Commentf("Missing 'top' log event"))
|
|
| 721 | 719 |
} |
| 722 | 720 |
|
| 723 | 721 |
// #13753 |
| ... | ... |
@@ -725,7 +619,7 @@ func (s *DockerSuite) TestEventsDefaultEmpty(c *check.C) {
|
| 725 | 725 |
testRequires(c, DaemonIsLinux) |
| 726 | 726 |
dockerCmd(c, "run", "busybox") |
| 727 | 727 |
out, _ := dockerCmd(c, "events", fmt.Sprintf("--until=%d", daemonTime(c).Unix()))
|
| 728 |
- c.Assert(strings.TrimSpace(out), check.Equals, "") |
|
| 728 |
+ c.Assert(strings.TrimSpace(out), checker.Equals, "") |
|
| 729 | 729 |
} |
| 730 | 730 |
|
| 731 | 731 |
// #14316 |
| ... | ... |
@@ -737,14 +631,12 @@ func (s *DockerRegistrySuite) TestEventsImageFilterPush(c *check.C) {
|
| 737 | 737 |
|
| 738 | 738 |
out, _ := dockerCmd(c, "run", "-d", "busybox", "top") |
| 739 | 739 |
cID := strings.TrimSpace(out) |
| 740 |
- c.Assert(waitRun(cID), check.IsNil) |
|
| 740 |
+ c.Assert(waitRun(cID), checker.IsNil) |
|
| 741 | 741 |
|
| 742 | 742 |
dockerCmd(c, "commit", cID, repoName) |
| 743 | 743 |
dockerCmd(c, "stop", cID) |
| 744 | 744 |
dockerCmd(c, "push", repoName) |
| 745 | 745 |
|
| 746 | 746 |
out, _ = dockerCmd(c, "events", "--since=0", "-f", "image="+repoName, "-f", "event=push", "--until="+strconv.Itoa(int(since))) |
| 747 |
- if !strings.Contains(out, repoName+": push\n") {
|
|
| 748 |
- c.Fatalf("Missing 'push' log event for image %s\n%s", repoName, out)
|
|
| 749 |
- } |
|
| 747 |
+ c.Assert(out, checker.Contains, repoName+": push\n", check.Commentf("Missing 'push' log event"))
|
|
| 750 | 748 |
} |