Browse code

return directly without ifs in remaining packages

Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>

unclejack authored on 2016/12/15 06:16:12
Showing 11 changed files
... ...
@@ -38,10 +38,7 @@ func Int64ValueOrZero(r *http.Request, k string) int64 {
38 38
 func Int64ValueOrDefault(r *http.Request, field string, def int64) (int64, error) {
39 39
 	if r.Form.Get(field) != "" {
40 40
 		value, err := strconv.ParseInt(r.Form.Get(field), 10, 64)
41
-		if err != nil {
42
-			return value, err
43
-		}
44
-		return value, nil
41
+		return value, err
45 42
 	}
46 43
 	return def, nil
47 44
 }
... ...
@@ -50,11 +50,8 @@ func (s *containerRouter) postContainersCopy(ctx context.Context, w http.Respons
50 50
 	defer data.Close()
51 51
 
52 52
 	w.Header().Set("Content-Type", "application/x-tar")
53
-	if _, err := io.Copy(w, data); err != nil {
54
-		return err
55
-	}
56
-
57
-	return nil
53
+	_, err = io.Copy(w, data)
54
+	return err
58 55
 }
59 56
 
60 57
 // // Encode the stat to JSON, base64 encode, and place in a header.
... ...
@@ -70,11 +70,7 @@ func Print(dockerCli *command.DockerCli, ctx context.Context, tasks []swarm.Task
70 70
 	defer writer.Flush()
71 71
 	fmt.Fprintln(writer, strings.Join([]string{"ID", "NAME", "IMAGE", "NODE", "DESIRED STATE", "CURRENT STATE", "ERROR", "PORTS"}, "\t"))
72 72
 
73
-	if err := print(writer, ctx, tasks, resolver, noTrunc); err != nil {
74
-		return err
75
-	}
76
-
77
-	return nil
73
+	return print(writer, ctx, tasks, resolver, noTrunc)
78 74
 }
79 75
 
80 76
 // PrintQuiet shows task list in a quiet way.
... ...
@@ -219,12 +219,7 @@ func registerService() error {
219 219
 		return err
220 220
 	}
221 221
 
222
-	err = eventlog.Install(*flServiceName, p, false, eventlog.Info|eventlog.Warning|eventlog.Error)
223
-	if err != nil {
224
-		return err
225
-	}
226
-
227
-	return nil
222
+	return eventlog.Install(*flServiceName, p, false, eventlog.Info|eventlog.Warning|eventlog.Error)
228 223
 }
229 224
 
230 225
 func unregisterService() error {
... ...
@@ -215,10 +215,8 @@ func (s *saveSession) save(outStream io.Writer) error {
215 215
 	}
216 216
 	defer fs.Close()
217 217
 
218
-	if _, err := io.Copy(outStream, fs); err != nil {
219
-		return err
220
-	}
221
-	return nil
218
+	_, err = io.Copy(outStream, fs)
219
+	return err
222 220
 }
223 221
 
224 222
 func (s *saveSession) saveImage(id image.ID) (map[layer.DiffID]distribution.Descriptor, error) {
... ...
@@ -103,10 +103,8 @@ func newVolumePlugin(c *check.C, name string) *volumePlugin {
103 103
 	read := func(b io.ReadCloser) (pluginRequest, error) {
104 104
 		defer b.Close()
105 105
 		var pr pluginRequest
106
-		if err := json.NewDecoder(b).Decode(&pr); err != nil {
107
-			return pr, err
108
-		}
109
-		return pr, nil
106
+		err := json.NewDecoder(b).Decode(&pr)
107
+		return pr, err
110 108
 	}
111 109
 
112 110
 	send := func(w http.ResponseWriter, data interface{}) {
... ...
@@ -180,10 +180,7 @@ var (
180 180
 				defer f.Close()
181 181
 				b := make([]byte, 1)
182 182
 				_, _ = f.Read(b)
183
-				if string(b) == "N" {
184
-					return false
185
-				}
186
-				return true
183
+				return string(b) != "N"
187 184
 			}
188 185
 
189 186
 			return true
... ...
@@ -193,10 +190,7 @@ var (
193 193
 	NotUserNamespace = testRequirement{
194 194
 		func() bool {
195 195
 			root := os.Getenv("DOCKER_REMAP_ROOT")
196
-			if root != "" {
197
-				return false
198
-			}
199
-			return true
196
+			return root == ""
200 197
 		},
201 198
 		"Test cannot be run when remapping root",
202 199
 	}
... ...
@@ -195,10 +195,7 @@ func saveMappings(root string, mappings map[string]image.ID) error {
195 195
 		return err
196 196
 	}
197 197
 	defer f.Close()
198
-	if err := json.NewEncoder(f).Encode(mappings); err != nil {
199
-		return err
200
-	}
201
-	return nil
198
+	return json.NewEncoder(f).Encode(mappings)
202 199
 }
203 200
 
204 201
 func migrateImages(root string, ls graphIDRegistrar, is image.Store, ms metadata.Store, mappings map[string]image.ID) error {
... ...
@@ -79,10 +79,7 @@ func Init(root string, ps *store.Store, remote libcontainerd.Remote, rs registry
79 79
 		return err
80 80
 	}
81 81
 	manager.cMap = make(map[*v2.Plugin]*controller)
82
-	if err := manager.reload(); err != nil {
83
-		return err
84
-	}
85
-	return nil
82
+	return manager.reload()
86 83
 }
87 84
 
88 85
 // StateChanged updates plugin internals using libcontainerd events.
... ...
@@ -859,10 +859,8 @@ func ParseLink(val string) (string, string, error) {
859 859
 
860 860
 // ValidateLink validates that the specified string has a valid link format (containerName:alias).
861 861
 func ValidateLink(val string) (string, error) {
862
-	if _, _, err := ParseLink(val); err != nil {
863
-		return val, err
864
-	}
865
-	return val, nil
862
+	_, _, err := ParseLink(val)
863
+	return val, err
866 864
 }
867 865
 
868 866
 // ValidDeviceMode checks if the mode for device is valid or not.
... ...
@@ -623,10 +623,7 @@ func (s *VolumeStore) FilterByUsed(vols []volume.Volume, used bool) []volume.Vol
623 623
 		s.locks.Lock(v.Name())
624 624
 		hasRef := s.hasRef(v.Name())
625 625
 		s.locks.Unlock(v.Name())
626
-		if used == hasRef {
627
-			return true
628
-		}
629
-		return false
626
+		return used == hasRef
630 627
 	})
631 628
 }
632 629