Browse code

Build docker incrementally by default

This speeds up docker build time drastically. It still possible to
disable this by setting `DOCKER_INCREMENTAL_BUILD` to `0` (and this is
what should be done on the CI).

Signed-off-by: Vincent Demeester <vincent@sbr.pm>

Vincent Demeester authored on 2016/11/16 00:23:48
Showing 2 changed files
... ...
@@ -2,6 +2,9 @@
2 2
 
3 3
 # set the graph driver as the current graphdriver if not set
4 4
 DOCKER_GRAPHDRIVER := $(if $(DOCKER_GRAPHDRIVER),$(DOCKER_GRAPHDRIVER),$(shell docker info 2>&1 | grep "Storage Driver" | sed 's/.*: //'))
5
+export DOCKER_GRAPHDRIVER
6
+DOCKER_INCREMENTAL_BINARY := $(if $(DOCKER_INCREMENTAL_BINARY),$(DOCKER_INCREMENTAL_BINARY),1)
7
+export DOCKER_INCREMENTAL_BINARY
5 8
 
6 9
 # get OS/Arch of docker engine
7 10
 DOCKER_OSARCH := $(shell bash -c 'source hack/make/.detect-daemon-osarch && echo $${DOCKER_ENGINE_OSARCH:-$$DOCKER_CLIENT_OSARCH}')
... ...
@@ -20,7 +23,7 @@ DOCKER_ENVS := \
20 20
 	-e DOCKER_DEBUG \
21 21
 	-e DOCKER_EXPERIMENTAL \
22 22
 	-e DOCKER_GITCOMMIT \
23
-	-e DOCKER_GRAPHDRIVER=$(DOCKER_GRAPHDRIVER) \
23
+	-e DOCKER_GRAPHDRIVER \
24 24
 	-e DOCKER_INCREMENTAL_BINARY \
25 25
 	-e DOCKER_PORT \
26 26
 	-e DOCKER_REMAP_ROOT \
... ...
@@ -159,7 +159,7 @@ ORIG_BUILDFLAGS=( -tags "autogen netgo static_build sqlite_omit_load_extension $
159 159
 # When $DOCKER_INCREMENTAL_BINARY is set in the environment, enable incremental
160 160
 # builds by installing dependent packages to the GOPATH.
161 161
 REBUILD_FLAG="-a"
162
-if [ "$DOCKER_INCREMENTAL_BINARY" ]; then
162
+if [ "$DOCKER_INCREMENTAL_BINARY" == "1" ] || [ "$DOCKER_INCREMENTAL_BINARY" == "true" ]; then
163 163
 	REBUILD_FLAG="-i"
164 164
 fi
165 165
 ORIG_BUILDFLAGS+=( $REBUILD_FLAG )