Signed-off-by: Alexandr Morozov <lk4d4@docker.com>
| ... | ... |
@@ -103,7 +103,7 @@ func (daemon *Daemon) ContainerAttach(job *engine.Job) engine.Status {
|
| 103 | 103 |
cStderr = job.Stderr |
| 104 | 104 |
} |
| 105 | 105 |
|
| 106 |
- <-daemon.Attach(&container.StreamConfig, container.Config.OpenStdin, container.Config.StdinOnce, container.Config.Tty, cStdin, cStdinCloser, cStdout, cStderr) |
|
| 106 |
+ <-daemon.attach(&container.StreamConfig, container.Config.OpenStdin, container.Config.StdinOnce, container.Config.Tty, cStdin, cStdinCloser, cStdout, cStderr) |
|
| 107 | 107 |
// If we are in stdinonce mode, wait for the process to end |
| 108 | 108 |
// otherwise, simply return |
| 109 | 109 |
if container.Config.StdinOnce && !container.Config.Tty {
|
| ... | ... |
@@ -113,13 +113,7 @@ func (daemon *Daemon) ContainerAttach(job *engine.Job) engine.Status {
|
| 113 | 113 |
return engine.StatusOK |
| 114 | 114 |
} |
| 115 | 115 |
|
| 116 |
-// FIXME: this should be private, and every outside subsystem |
|
| 117 |
-// should go through the "container_attach" job. But that would require |
|
| 118 |
-// that job to be properly documented, as well as the relationship between |
|
| 119 |
-// Attach and ContainerAttach. |
|
| 120 |
-// |
|
| 121 |
-// This method is in use by builder/builder.go. |
|
| 122 |
-func (daemon *Daemon) Attach(streamConfig *StreamConfig, openStdin, stdinOnce, tty bool, stdin io.ReadCloser, stdinCloser io.Closer, stdout io.Writer, stderr io.Writer) chan error {
|
|
| 116 |
+func (daemon *Daemon) attach(streamConfig *StreamConfig, openStdin, stdinOnce, tty bool, stdin io.ReadCloser, stdinCloser io.Closer, stdout io.Writer, stderr io.Writer) chan error {
|
|
| 123 | 117 |
var ( |
| 124 | 118 |
cStdout, cStderr io.ReadCloser |
| 125 | 119 |
nJobs int |
| ... | ... |
@@ -204,7 +204,7 @@ func (d *Daemon) ContainerExecStart(job *engine.Job) engine.Status {
|
| 204 | 204 |
execConfig.StreamConfig.stdinPipe = ioutils.NopWriteCloser(ioutil.Discard) // Silently drop stdin |
| 205 | 205 |
} |
| 206 | 206 |
|
| 207 |
- attachErr := d.Attach(&execConfig.StreamConfig, execConfig.OpenStdin, false, execConfig.ProcessConfig.Tty, cStdin, cStdinCloser, cStdout, cStderr) |
|
| 207 |
+ attachErr := d.attach(&execConfig.StreamConfig, execConfig.OpenStdin, false, execConfig.ProcessConfig.Tty, cStdin, cStdinCloser, cStdout, cStderr) |
|
| 208 | 208 |
|
| 209 | 209 |
execErr := make(chan error) |
| 210 | 210 |
|