Browse code

Replace t.Fatal(err) with assert.NilError(err)

so that they are consistent with other places

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

Yong Tang authored on 2019/01/14 06:36:25
Showing 2 changed files
... ...
@@ -11,6 +11,7 @@ import (
11 11
 	"github.com/docker/docker/api/types"
12 12
 	"github.com/docker/docker/internal/test/daemon"
13 13
 	"github.com/docker/docker/internal/testutil"
14
+	"gotest.tools/assert"
14 15
 	"gotest.tools/skip"
15 16
 )
16 17
 
... ...
@@ -34,16 +35,13 @@ func TestImportExtremelyLargeImageWorks(t *testing.T) {
34 34
 	var tarBuffer bytes.Buffer
35 35
 
36 36
 	tw := tar.NewWriter(&tarBuffer)
37
-	if err := tw.Close(); err != nil {
38
-		t.Fatal(err)
39
-	}
37
+	err := tw.Close()
38
+	assert.NilError(t, err)
40 39
 	imageRdr := io.MultiReader(&tarBuffer, io.LimitReader(testutil.DevZero, 8*1024*1024*1024))
41 40
 
42
-	_, err := client.ImageImport(context.Background(),
41
+	_, err = client.ImageImport(context.Background(),
43 42
 		types.ImageImportSource{Source: imageRdr, SourceName: "-"},
44 43
 		"test1234:v42",
45 44
 		types.ImageImportOptions{})
46
-	if err != nil {
47
-		t.Fatal(err)
48
-	}
45
+	assert.NilError(t, err)
49 46
 }
... ...
@@ -63,7 +63,7 @@ func TestEventsExecDie(t *testing.T) {
63 63
 		assert.Equal(t, m.Actor.Attributes["execID"], id.ID)
64 64
 		assert.Equal(t, m.Actor.Attributes["exitCode"], "0")
65 65
 	case err = <-errors:
66
-		t.Fatal(err)
66
+		assert.NilError(t, err)
67 67
 	case <-time.After(time.Second * 3):
68 68
 		t.Fatal("timeout hit")
69 69
 	}
... ...
@@ -109,7 +109,7 @@ func TestEventsBackwardsCompatible(t *testing.T) {
109 109
 			if err == io.EOF {
110 110
 				break
111 111
 			}
112
-			t.Fatal(err)
112
+			assert.NilError(t, err)
113 113
 		}
114 114
 		if event.Status == "create" && event.ID == cID {
115 115
 			containerCreateEvent = &event