Browse code

Use assert.NilError() instead of assert.Assert()

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2019/01/21 21:16:02
Showing 13 changed files
... ...
@@ -61,7 +61,7 @@ func TestTLSCloseWriter(t *testing.T) {
61 61
 			break
62 62
 		}
63 63
 	}
64
-	assert.Assert(t, err)
64
+	assert.NilError(t, err)
65 65
 
66 66
 	ts.Listener = l
67 67
 	defer l.Close()
... ...
@@ -76,13 +76,13 @@ func TestTLSCloseWriter(t *testing.T) {
76 76
 	defer ts.Close()
77 77
 
78 78
 	serverURL, err := url.Parse(ts.URL)
79
-	assert.Assert(t, err)
79
+	assert.NilError(t, err)
80 80
 
81 81
 	client, err := NewClient("tcp://"+serverURL.Host, "", ts.Client(), nil)
82
-	assert.Assert(t, err)
82
+	assert.NilError(t, err)
83 83
 
84 84
 	resp, err := client.postHijacked(context.Background(), "/asdf", url.Values{}, nil, map[string][]string{"Content-Type": {"text/plain"}})
85
-	assert.Assert(t, err)
85
+	assert.NilError(t, err)
86 86
 	defer resp.Close()
87 87
 
88 88
 	if _, ok := resp.Conn.(types.CloseWriter); !ok {
... ...
@@ -90,10 +90,10 @@ func TestTLSCloseWriter(t *testing.T) {
90 90
 	}
91 91
 
92 92
 	_, err = resp.Conn.Write([]byte("hello"))
93
-	assert.Assert(t, err)
93
+	assert.NilError(t, err)
94 94
 
95 95
 	b, err := ioutil.ReadAll(resp.Reader)
96
-	assert.Assert(t, err)
96
+	assert.NilError(t, err)
97 97
 	assert.Assert(t, string(b) == "hello")
98 98
 	assert.Assert(t, resp.CloseWrite())
99 99
 
... ...
@@ -236,30 +236,30 @@ func TestRootMountCleanup(t *testing.T) {
236 236
 	t.Parallel()
237 237
 
238 238
 	testRoot, err := ioutil.TempDir("", t.Name())
239
-	assert.Assert(t, err)
239
+	assert.NilError(t, err)
240 240
 	defer os.RemoveAll(testRoot)
241 241
 	cfg := &config.Config{}
242 242
 
243 243
 	err = mount.MakePrivate(testRoot)
244
-	assert.Assert(t, err)
244
+	assert.NilError(t, err)
245 245
 	defer mount.Unmount(testRoot)
246 246
 
247 247
 	cfg.ExecRoot = filepath.Join(testRoot, "exec")
248 248
 	cfg.Root = filepath.Join(testRoot, "daemon")
249 249
 
250 250
 	err = os.Mkdir(cfg.ExecRoot, 0755)
251
-	assert.Assert(t, err)
251
+	assert.NilError(t, err)
252 252
 	err = os.Mkdir(cfg.Root, 0755)
253
-	assert.Assert(t, err)
253
+	assert.NilError(t, err)
254 254
 
255 255
 	d := &Daemon{configStore: cfg, root: cfg.Root}
256 256
 	unmountFile := getUnmountOnShutdownPath(cfg)
257 257
 
258 258
 	t.Run("regular dir no mountpoint", func(t *testing.T) {
259 259
 		err = setupDaemonRootPropagation(cfg)
260
-		assert.Assert(t, err)
260
+		assert.NilError(t, err)
261 261
 		_, err = os.Stat(unmountFile)
262
-		assert.Assert(t, err)
262
+		assert.NilError(t, err)
263 263
 		checkMounted(t, cfg.Root, true)
264 264
 
265 265
 		assert.Assert(t, d.cleanupMounts())
... ...
@@ -271,11 +271,11 @@ func TestRootMountCleanup(t *testing.T) {
271 271
 
272 272
 	t.Run("root is a private mountpoint", func(t *testing.T) {
273 273
 		err = mount.MakePrivate(cfg.Root)
274
-		assert.Assert(t, err)
274
+		assert.NilError(t, err)
275 275
 		defer mount.Unmount(cfg.Root)
276 276
 
277 277
 		err = setupDaemonRootPropagation(cfg)
278
-		assert.Assert(t, err)
278
+		assert.NilError(t, err)
279 279
 		assert.Check(t, ensureShared(cfg.Root))
280 280
 
281 281
 		_, err = os.Stat(unmountFile)
... ...
@@ -287,11 +287,11 @@ func TestRootMountCleanup(t *testing.T) {
287 287
 	// mount is pre-configured with a shared mount
288 288
 	t.Run("root is a shared mountpoint", func(t *testing.T) {
289 289
 		err = mount.MakeShared(cfg.Root)
290
-		assert.Assert(t, err)
290
+		assert.NilError(t, err)
291 291
 		defer mount.Unmount(cfg.Root)
292 292
 
293 293
 		err = setupDaemonRootPropagation(cfg)
294
-		assert.Assert(t, err)
294
+		assert.NilError(t, err)
295 295
 
296 296
 		if _, err := os.Stat(unmountFile); err == nil {
297 297
 			t.Fatal("unmount file should not exist")
... ...
@@ -305,13 +305,13 @@ func TestRootMountCleanup(t *testing.T) {
305 305
 	// does not need mount but unmount file exists from previous run
306 306
 	t.Run("old mount file is cleaned up on setup if not needed", func(t *testing.T) {
307 307
 		err = mount.MakeShared(testRoot)
308
-		assert.Assert(t, err)
308
+		assert.NilError(t, err)
309 309
 		defer mount.MakePrivate(testRoot)
310 310
 		err = ioutil.WriteFile(unmountFile, nil, 0644)
311
-		assert.Assert(t, err)
311
+		assert.NilError(t, err)
312 312
 
313 313
 		err = setupDaemonRootPropagation(cfg)
314
-		assert.Assert(t, err)
314
+		assert.NilError(t, err)
315 315
 
316 316
 		_, err = os.Stat(unmountFile)
317 317
 		assert.Check(t, os.IsNotExist(err), err)
... ...
@@ -77,15 +77,15 @@ func TestEncodeDecode(t *testing.T) {
77 77
 
78 78
 	decode := decodeFunc(buf)
79 79
 	msg, err := decode()
80
-	assert.Assert(t, err)
80
+	assert.NilError(t, err)
81 81
 	assert.Assert(t, string(msg.Line) == "hello 1\n", string(msg.Line))
82 82
 
83 83
 	msg, err = decode()
84
-	assert.Assert(t, err)
84
+	assert.NilError(t, err)
85 85
 	assert.Assert(t, string(msg.Line) == "hello 2\n")
86 86
 
87 87
 	msg, err = decode()
88
-	assert.Assert(t, err)
88
+	assert.NilError(t, err)
89 89
 	assert.Assert(t, string(msg.Line) == "hello 3\n")
90 90
 
91 91
 	_, err = decode()
... ...
@@ -28,13 +28,13 @@ func TestWriteLog(t *testing.T) {
28 28
 	t.Parallel()
29 29
 
30 30
 	dir, err := ioutil.TempDir("", t.Name())
31
-	assert.Assert(t, err)
31
+	assert.NilError(t, err)
32 32
 	defer os.RemoveAll(dir)
33 33
 
34 34
 	logPath := filepath.Join(dir, "test.log")
35 35
 
36 36
 	l, err := New(logger.Info{LogPath: logPath})
37
-	assert.Assert(t, err)
37
+	assert.NilError(t, err)
38 38
 	defer l.Close()
39 39
 
40 40
 	m1 := logger.Message{Source: "stdout", Timestamp: time.Now().Add(-1 * 30 * time.Minute), Line: []byte("message 1")}
... ...
@@ -43,14 +43,14 @@ func TestWriteLog(t *testing.T) {
43 43
 
44 44
 	// copy the log message because the underying log writer resets the log message and returns it to a buffer pool
45 45
 	err = l.Log(copyLogMessage(&m1))
46
-	assert.Assert(t, err)
46
+	assert.NilError(t, err)
47 47
 	err = l.Log(copyLogMessage(&m2))
48
-	assert.Assert(t, err)
48
+	assert.NilError(t, err)
49 49
 	err = l.Log(copyLogMessage(&m3))
50
-	assert.Assert(t, err)
50
+	assert.NilError(t, err)
51 51
 
52 52
 	f, err := os.Open(logPath)
53
-	assert.Assert(t, err)
53
+	assert.NilError(t, err)
54 54
 	defer f.Close()
55 55
 	dec := protoio.NewUint32DelimitedReader(f, binary.BigEndian, 1e6)
56 56
 
... ...
@@ -66,19 +66,19 @@ func TestWriteLog(t *testing.T) {
66 66
 	}
67 67
 
68 68
 	err = dec.ReadMsg(&proto)
69
-	assert.Assert(t, err)
69
+	assert.NilError(t, err)
70 70
 	messageToProto(&m1, &testProto, &partial)
71 71
 	assert.Check(t, is.DeepEqual(testProto, proto), "expected:\n%+v\ngot:\n%+v", testProto, proto)
72 72
 	seekMsgLen()
73 73
 
74 74
 	err = dec.ReadMsg(&proto)
75
-	assert.Assert(t, err)
75
+	assert.NilError(t, err)
76 76
 	messageToProto(&m2, &testProto, &partial)
77 77
 	assert.Check(t, is.DeepEqual(testProto, proto))
78 78
 	seekMsgLen()
79 79
 
80 80
 	err = dec.ReadMsg(&proto)
81
-	assert.Assert(t, err)
81
+	assert.NilError(t, err)
82 82
 	messageToProto(&m3, &testProto, &partial)
83 83
 	assert.Check(t, is.DeepEqual(testProto, proto), "expected:\n%+v\ngot:\n%+v", testProto, proto)
84 84
 }
... ...
@@ -87,12 +87,12 @@ func TestReadLog(t *testing.T) {
87 87
 	t.Parallel()
88 88
 
89 89
 	dir, err := ioutil.TempDir("", t.Name())
90
-	assert.Assert(t, err)
90
+	assert.NilError(t, err)
91 91
 	defer os.RemoveAll(dir)
92 92
 
93 93
 	logPath := filepath.Join(dir, "test.log")
94 94
 	l, err := New(logger.Info{LogPath: logPath})
95
-	assert.Assert(t, err)
95
+	assert.NilError(t, err)
96 96
 	defer l.Close()
97 97
 
98 98
 	m1 := logger.Message{Source: "stdout", Timestamp: time.Now().Add(-1 * 30 * time.Minute), Line: []byte("a message")}
... ...
@@ -103,13 +103,13 @@ func TestReadLog(t *testing.T) {
103 103
 
104 104
 	// copy the log message because the underlying log writer resets the log message and returns it to a buffer pool
105 105
 	err = l.Log(copyLogMessage(&m1))
106
-	assert.Assert(t, err)
106
+	assert.NilError(t, err)
107 107
 	err = l.Log(copyLogMessage(&m2))
108
-	assert.Assert(t, err)
108
+	assert.NilError(t, err)
109 109
 	err = l.Log(copyLogMessage(&m3))
110
-	assert.Assert(t, err)
110
+	assert.NilError(t, err)
111 111
 	err = l.Log(copyLogMessage(&m4))
112
-	assert.Assert(t, err)
112
+	assert.NilError(t, err)
113 113
 
114 114
 	lr := l.(logger.LogReader)
115 115
 
... ...
@@ -121,12 +121,12 @@ func TestReadLog(t *testing.T) {
121 121
 		case <-ctx.Done():
122 122
 			assert.Assert(t, ctx.Err())
123 123
 		case err := <-lw.Err:
124
-			assert.Assert(t, err)
124
+			assert.NilError(t, err)
125 125
 		case msg, open := <-lw.Msg:
126 126
 			if !open {
127 127
 				select {
128 128
 				case err := <-lw.Err:
129
-					assert.Assert(t, err)
129
+					assert.NilError(t, err)
130 130
 				default:
131 131
 					assert.Assert(t, m == nil)
132 132
 					return
... ...
@@ -60,7 +60,7 @@ func TestTailFiles(t *testing.T) {
60 60
 	case <-time.After(60 * time.Second):
61 61
 		t.Fatal("timeout waiting for tail line")
62 62
 	case err := <-watcher.Err:
63
-		assert.Assert(t, err)
63
+		assert.NilError(t, err)
64 64
 	case msg := <-watcher.Msg:
65 65
 		assert.Assert(t, msg != nil)
66 66
 		assert.Assert(t, string(msg.Line) == "Roads?", string(msg.Line))
... ...
@@ -70,7 +70,7 @@ func TestTailFiles(t *testing.T) {
70 70
 	case <-time.After(60 * time.Second):
71 71
 		t.Fatal("timeout waiting for tail line")
72 72
 	case err := <-watcher.Err:
73
-		assert.Assert(t, err)
73
+		assert.NilError(t, err)
74 74
 	case msg := <-watcher.Msg:
75 75
 		assert.Assert(t, msg != nil)
76 76
 		assert.Assert(t, string(msg.Line) == "Where we're going we don't need roads.", string(msg.Line))
... ...
@@ -370,18 +370,18 @@ func TestAuthzPluginEnsureContainerCopyToFrom(t *testing.T) {
370 370
 	d.StartWithBusybox(t, "--authorization-plugin="+testAuthZPlugin, "--authorization-plugin="+testAuthZPlugin)
371 371
 
372 372
 	dir, err := ioutil.TempDir("", t.Name())
373
-	assert.Assert(t, err)
373
+	assert.NilError(t, err)
374 374
 	defer os.RemoveAll(dir)
375 375
 
376 376
 	f, err := ioutil.TempFile(dir, "send")
377
-	assert.Assert(t, err)
377
+	assert.NilError(t, err)
378 378
 	defer f.Close()
379 379
 
380 380
 	buf := make([]byte, 1024)
381 381
 	fileSize := len(buf) * 1024 * 10
382 382
 	for written := 0; written < fileSize; {
383 383
 		n, err := f.Write(buf)
384
-		assert.Assert(t, err)
384
+		assert.NilError(t, err)
385 385
 		written += n
386 386
 	}
387 387
 
... ...
@@ -392,24 +392,24 @@ func TestAuthzPluginEnsureContainerCopyToFrom(t *testing.T) {
392 392
 	defer c.ContainerRemove(ctx, cID, types.ContainerRemoveOptions{Force: true})
393 393
 
394 394
 	_, err = f.Seek(0, io.SeekStart)
395
-	assert.Assert(t, err)
395
+	assert.NilError(t, err)
396 396
 
397 397
 	srcInfo, err := archive.CopyInfoSourcePath(f.Name(), false)
398
-	assert.Assert(t, err)
398
+	assert.NilError(t, err)
399 399
 	srcArchive, err := archive.TarResource(srcInfo)
400
-	assert.Assert(t, err)
400
+	assert.NilError(t, err)
401 401
 	defer srcArchive.Close()
402 402
 
403 403
 	dstDir, preparedArchive, err := archive.PrepareArchiveCopy(srcArchive, srcInfo, archive.CopyInfo{Path: "/test"})
404
-	assert.Assert(t, err)
404
+	assert.NilError(t, err)
405 405
 
406 406
 	err = c.CopyToContainer(ctx, cID, dstDir, preparedArchive, types.CopyToContainerOptions{})
407
-	assert.Assert(t, err)
407
+	assert.NilError(t, err)
408 408
 
409 409
 	rdr, _, err := c.CopyFromContainer(ctx, cID, "/test")
410
-	assert.Assert(t, err)
410
+	assert.NilError(t, err)
411 411
 	_, err = io.Copy(ioutil.Discard, rdr)
412
-	assert.Assert(t, err)
412
+	assert.NilError(t, err)
413 413
 }
414 414
 
415 415
 func imageSave(client client.APIClient, path, image string) error {
... ...
@@ -45,7 +45,7 @@ func TestContinueAfterPluginCrash(t *testing.T) {
45 45
 
46 46
 	// Attach to the container to make sure it's written a few times to stdout
47 47
 	attach, err := client.ContainerAttach(context.Background(), id, types.ContainerAttachOptions{Stream: true, Stdout: true})
48
-	assert.Assert(t, err)
48
+	assert.NilError(t, err)
49 49
 
50 50
 	chErr := make(chan error)
51 51
 	go func() {
... ...
@@ -62,7 +62,7 @@ func TestContinueAfterPluginCrash(t *testing.T) {
62 62
 
63 63
 	select {
64 64
 	case err := <-chErr:
65
-		assert.Assert(t, err)
65
+		assert.NilError(t, err)
66 66
 	case <-time.After(60 * time.Second):
67 67
 		t.Fatal("timeout waiting for container i/o")
68 68
 	}
... ...
@@ -71,7 +71,7 @@ func TestContinueAfterPluginCrash(t *testing.T) {
71 71
 	// TODO(@cpuguy83): This is horribly hacky but is the only way to really test this case right now.
72 72
 	// It would be nice if there was a way to know that a broken pipe has occurred without looking through the logs.
73 73
 	log, err := os.Open(d.LogFileName())
74
-	assert.Assert(t, err)
74
+	assert.NilError(t, err)
75 75
 	scanner := bufio.NewScanner(log)
76 76
 	for scanner.Scan() {
77 77
 		assert.Assert(t, !strings.Contains(scanner.Text(), "broken pipe"))
... ...
@@ -28,7 +28,7 @@ func TestPluginWithDevMounts(t *testing.T) {
28 28
 	ctx := context.Background()
29 29
 
30 30
 	testDir, err := ioutil.TempDir("", "test-dir")
31
-	assert.Assert(t, err)
31
+	assert.NilError(t, err)
32 32
 	defer os.RemoveAll(testDir)
33 33
 
34 34
 	createPlugin(t, c, "test", "dummy", asVolumeDriver, func(c *plugin.Config) {
... ...
@@ -46,13 +46,13 @@ func TestPluginWithDevMounts(t *testing.T) {
46 46
 	})
47 47
 
48 48
 	err = c.PluginEnable(ctx, "test", types.PluginEnableOptions{Timeout: 30})
49
-	assert.Assert(t, err)
49
+	assert.NilError(t, err)
50 50
 	defer func() {
51 51
 		err := c.PluginRemove(ctx, "test", types.PluginRemoveOptions{Force: true})
52 52
 		assert.Check(t, err)
53 53
 	}()
54 54
 
55 55
 	p, _, err := c.PluginInspectWithRaw(ctx, "test")
56
-	assert.Assert(t, err)
56
+	assert.NilError(t, err)
57 57
 	assert.Assert(t, p.Enabled)
58 58
 }
... ...
@@ -232,11 +232,11 @@ func TestNewTailReader(t *testing.T) {
232 232
 								assert.Assert(t, lines == 0)
233 233
 								return
234 234
 							}
235
-							assert.Assert(t, err)
235
+							assert.NilError(t, err)
236 236
 							assert.Check(t, lines == i, "%d -- %d", lines, i)
237 237
 
238 238
 							b, err := ioutil.ReadAll(tr)
239
-							assert.Assert(t, err)
239
+							assert.NilError(t, err)
240 240
 
241 241
 							expectLines := test.data[len(test.data)-i:]
242 242
 							assert.Check(t, len(expectLines) == i)
... ...
@@ -260,10 +260,10 @@ func TestNewTailReader(t *testing.T) {
260 260
 							return
261 261
 						}
262 262
 
263
-						assert.Assert(t, err)
263
+						assert.NilError(t, err)
264 264
 						assert.Check(t, lines == len(test.data), "%d -- %d", lines, len(test.data))
265 265
 						b, err := ioutil.ReadAll(tr)
266
-						assert.Assert(t, err)
266
+						assert.NilError(t, err)
267 267
 						assert.Check(t, bytes.Equal(b, []byte(s)), "\n%v\n%v", b, []byte(s))
268 268
 					})
269 269
 				})
... ...
@@ -273,16 +273,16 @@ func TestNewTailReader(t *testing.T) {
273 273
 	t.Run("truncated last line", func(t *testing.T) {
274 274
 		t.Run("more than available", func(t *testing.T) {
275 275
 			tail, nLines, err := NewTailReader(ctx, strings.NewReader("a\nb\nextra"), 3)
276
-			assert.Assert(t, err)
276
+			assert.NilError(t, err)
277 277
 			assert.Check(t, nLines == 2, nLines)
278 278
 
279 279
 			rdr := bufio.NewReader(tail)
280 280
 			data, _, err := rdr.ReadLine()
281
-			assert.Assert(t, err)
281
+			assert.NilError(t, err)
282 282
 			assert.Check(t, string(data) == "a", string(data))
283 283
 
284 284
 			data, _, err = rdr.ReadLine()
285
-			assert.Assert(t, err)
285
+			assert.NilError(t, err)
286 286
 			assert.Check(t, string(data) == "b", string(data))
287 287
 
288 288
 			_, _, err = rdr.ReadLine()
... ...
@@ -292,16 +292,16 @@ func TestNewTailReader(t *testing.T) {
292 292
 	t.Run("truncated last line", func(t *testing.T) {
293 293
 		t.Run("exact", func(t *testing.T) {
294 294
 			tail, nLines, err := NewTailReader(ctx, strings.NewReader("a\nb\nextra"), 2)
295
-			assert.Assert(t, err)
295
+			assert.NilError(t, err)
296 296
 			assert.Check(t, nLines == 2, nLines)
297 297
 
298 298
 			rdr := bufio.NewReader(tail)
299 299
 			data, _, err := rdr.ReadLine()
300
-			assert.Assert(t, err)
300
+			assert.NilError(t, err)
301 301
 			assert.Check(t, string(data) == "a", string(data))
302 302
 
303 303
 			data, _, err = rdr.ReadLine()
304
-			assert.Assert(t, err)
304
+			assert.NilError(t, err)
305 305
 			assert.Check(t, string(data) == "b", string(data))
306 306
 
307 307
 			_, _, err = rdr.ReadLine()
... ...
@@ -312,12 +312,12 @@ func TestNewTailReader(t *testing.T) {
312 312
 	t.Run("truncated last line", func(t *testing.T) {
313 313
 		t.Run("one line", func(t *testing.T) {
314 314
 			tail, nLines, err := NewTailReader(ctx, strings.NewReader("a\nb\nextra"), 1)
315
-			assert.Assert(t, err)
315
+			assert.NilError(t, err)
316 316
 			assert.Check(t, nLines == 1, nLines)
317 317
 
318 318
 			rdr := bufio.NewReader(tail)
319 319
 			data, _, err := rdr.ReadLine()
320
-			assert.Assert(t, err)
320
+			assert.NilError(t, err)
321 321
 			assert.Check(t, string(data) == "b", string(data))
322 322
 
323 323
 			_, _, err = rdr.ReadLine()
... ...
@@ -28,7 +28,7 @@ func TestLifeCycle(t *testing.T) {
28 28
 	mock.simulateStartError(false, id)
29 29
 
30 30
 	err = exec.Create(id, specs.Spec{}, nil, nil)
31
-	assert.Assert(t, err)
31
+	assert.NilError(t, err)
32 32
 	running, _ := exec.IsRunning(id)
33 33
 	assert.Assert(t, running)
34 34
 
... ...
@@ -39,12 +39,12 @@ func TestLifeCycle(t *testing.T) {
39 39
 	mock.HandleExitEvent(id) // simulate a plugin that exits
40 40
 
41 41
 	err = exec.Create(id, specs.Spec{}, nil, nil)
42
-	assert.Assert(t, err)
42
+	assert.NilError(t, err)
43 43
 }
44 44
 
45 45
 func setupTest(t *testing.T, client Client, eh ExitHandler) (*Executor, func()) {
46 46
 	rootDir, err := ioutil.TempDir("", "test-daemon")
47
-	assert.Assert(t, err)
47
+	assert.NilError(t, err)
48 48
 	assert.Assert(t, client != nil)
49 49
 	assert.Assert(t, eh != nil)
50 50
 
... ...
@@ -22,11 +22,11 @@ func TestLocalVolumeSize(t *testing.T) {
22 22
 
23 23
 	ds := volumedrivers.NewStore(nil)
24 24
 	dir, err := ioutil.TempDir("", t.Name())
25
-	assert.Assert(t, err)
25
+	assert.NilError(t, err)
26 26
 	defer os.RemoveAll(dir)
27 27
 
28 28
 	l, err := local.New(dir, idtools.Identity{UID: os.Getuid(), GID: os.Getegid()})
29
-	assert.Assert(t, err)
29
+	assert.NilError(t, err)
30 30
 	assert.Assert(t, ds.Register(l, volume.DefaultDriverName))
31 31
 	assert.Assert(t, ds.Register(testutils.NewFakeDriver("fake"), "fake"))
32 32
 
... ...
@@ -35,20 +35,20 @@ func TestLocalVolumeSize(t *testing.T) {
35 35
 
36 36
 	ctx := context.Background()
37 37
 	v1, err := service.Create(ctx, "test1", volume.DefaultDriverName, opts.WithCreateReference("foo"))
38
-	assert.Assert(t, err)
38
+	assert.NilError(t, err)
39 39
 	v2, err := service.Create(ctx, "test2", volume.DefaultDriverName)
40
-	assert.Assert(t, err)
40
+	assert.NilError(t, err)
41 41
 	_, err = service.Create(ctx, "test3", "fake")
42
-	assert.Assert(t, err)
42
+	assert.NilError(t, err)
43 43
 
44 44
 	data := make([]byte, 1024)
45 45
 	err = ioutil.WriteFile(filepath.Join(v1.Mountpoint, "data"), data, 0644)
46
-	assert.Assert(t, err)
46
+	assert.NilError(t, err)
47 47
 	err = ioutil.WriteFile(filepath.Join(v2.Mountpoint, "data"), data[:1], 0644)
48
-	assert.Assert(t, err)
48
+	assert.NilError(t, err)
49 49
 
50 50
 	ls, err := service.LocalVolumesSize(ctx)
51
-	assert.Assert(t, err)
51
+	assert.NilError(t, err)
52 52
 	assert.Assert(t, is.Len(ls, 2))
53 53
 
54 54
 	for _, v := range ls {
... ...
@@ -31,10 +31,10 @@ func TestServiceCreate(t *testing.T) {
31 31
 	assert.Assert(t, errdefs.IsNotFound(err), err)
32 32
 
33 33
 	v, err := service.Create(ctx, "v1", "d1")
34
-	assert.Assert(t, err)
34
+	assert.NilError(t, err)
35 35
 
36 36
 	vCopy, err := service.Create(ctx, "v1", "d1")
37
-	assert.Assert(t, err)
37
+	assert.NilError(t, err)
38 38
 	assert.Assert(t, is.DeepEqual(v, vCopy))
39 39
 
40 40
 	_, err = service.Create(ctx, "v1", "d2")
... ...
@@ -43,9 +43,9 @@ func TestServiceCreate(t *testing.T) {
43 43
 
44 44
 	assert.Assert(t, service.Remove(ctx, "v1"))
45 45
 	_, err = service.Create(ctx, "v1", "d2")
46
-	assert.Assert(t, err)
46
+	assert.NilError(t, err)
47 47
 	_, err = service.Create(ctx, "v1", "d2")
48
-	assert.Assert(t, err)
48
+	assert.NilError(t, err)
49 49
 
50 50
 }
51 51
 
... ...
@@ -62,45 +62,45 @@ func TestServiceList(t *testing.T) {
62 62
 	ctx := context.Background()
63 63
 
64 64
 	_, err := service.Create(ctx, "v1", "d1")
65
-	assert.Assert(t, err)
65
+	assert.NilError(t, err)
66 66
 	_, err = service.Create(ctx, "v2", "d1")
67
-	assert.Assert(t, err)
67
+	assert.NilError(t, err)
68 68
 	_, err = service.Create(ctx, "v3", "d2")
69
-	assert.Assert(t, err)
69
+	assert.NilError(t, err)
70 70
 
71 71
 	ls, _, err := service.List(ctx, filters.NewArgs(filters.Arg("driver", "d1")))
72
-	assert.Assert(t, err)
72
+	assert.NilError(t, err)
73 73
 	assert.Check(t, is.Len(ls, 2))
74 74
 
75 75
 	ls, _, err = service.List(ctx, filters.NewArgs(filters.Arg("driver", "d2")))
76
-	assert.Assert(t, err)
76
+	assert.NilError(t, err)
77 77
 	assert.Check(t, is.Len(ls, 1))
78 78
 
79 79
 	ls, _, err = service.List(ctx, filters.NewArgs(filters.Arg("driver", "notexist")))
80
-	assert.Assert(t, err)
80
+	assert.NilError(t, err)
81 81
 	assert.Check(t, is.Len(ls, 0))
82 82
 
83 83
 	ls, _, err = service.List(ctx, filters.NewArgs(filters.Arg("dangling", "true")))
84
-	assert.Assert(t, err)
84
+	assert.NilError(t, err)
85 85
 	assert.Check(t, is.Len(ls, 3))
86 86
 	ls, _, err = service.List(ctx, filters.NewArgs(filters.Arg("dangling", "false")))
87
-	assert.Assert(t, err)
87
+	assert.NilError(t, err)
88 88
 	assert.Check(t, is.Len(ls, 0))
89 89
 
90 90
 	_, err = service.Get(ctx, "v1", opts.WithGetReference("foo"))
91
-	assert.Assert(t, err)
91
+	assert.NilError(t, err)
92 92
 	ls, _, err = service.List(ctx, filters.NewArgs(filters.Arg("dangling", "true")))
93
-	assert.Assert(t, err)
93
+	assert.NilError(t, err)
94 94
 	assert.Check(t, is.Len(ls, 2))
95 95
 	ls, _, err = service.List(ctx, filters.NewArgs(filters.Arg("dangling", "false")))
96
-	assert.Assert(t, err)
96
+	assert.NilError(t, err)
97 97
 	assert.Check(t, is.Len(ls, 1))
98 98
 
99 99
 	ls, _, err = service.List(ctx, filters.NewArgs(filters.Arg("dangling", "false"), filters.Arg("driver", "d2")))
100
-	assert.Assert(t, err)
100
+	assert.NilError(t, err)
101 101
 	assert.Check(t, is.Len(ls, 0))
102 102
 	ls, _, err = service.List(ctx, filters.NewArgs(filters.Arg("dangling", "true"), filters.Arg("driver", "d2")))
103
-	assert.Assert(t, err)
103
+	assert.NilError(t, err)
104 104
 	assert.Check(t, is.Len(ls, 1))
105 105
 }
106 106
 
... ...
@@ -115,7 +115,7 @@ func TestServiceRemove(t *testing.T) {
115 115
 	ctx := context.Background()
116 116
 
117 117
 	_, err := service.Create(ctx, "test", "d1")
118
-	assert.Assert(t, err)
118
+	assert.NilError(t, err)
119 119
 
120 120
 	assert.Assert(t, service.Remove(ctx, "test"))
121 121
 	assert.Assert(t, service.Remove(ctx, "test", opts.WithPurgeOnError(true)))
... ...
@@ -136,15 +136,15 @@ func TestServiceGet(t *testing.T) {
136 136
 	assert.Check(t, v == nil)
137 137
 
138 138
 	created, err := service.Create(ctx, "test", "d1")
139
-	assert.Assert(t, err)
139
+	assert.NilError(t, err)
140 140
 	assert.Assert(t, created != nil)
141 141
 
142 142
 	v, err = service.Get(ctx, "test")
143
-	assert.Assert(t, err)
143
+	assert.NilError(t, err)
144 144
 	assert.Assert(t, is.DeepEqual(created, v))
145 145
 
146 146
 	v, err = service.Get(ctx, "test", opts.WithGetResolveStatus)
147
-	assert.Assert(t, err)
147
+	assert.NilError(t, err)
148 148
 	assert.Assert(t, is.Len(v.Status, 1), v.Status)
149 149
 
150 150
 	v, err = service.Get(ctx, "test", opts.WithGetDriver("notarealdriver"))
... ...
@@ -170,16 +170,16 @@ func TestServicePrune(t *testing.T) {
170 170
 	ctx := context.Background()
171 171
 
172 172
 	_, err := service.Create(ctx, "test", volume.DefaultDriverName)
173
-	assert.Assert(t, err)
173
+	assert.NilError(t, err)
174 174
 	_, err = service.Create(ctx, "test2", "other")
175
-	assert.Assert(t, err)
175
+	assert.NilError(t, err)
176 176
 
177 177
 	pr, err := service.Prune(ctx, filters.NewArgs(filters.Arg("label", "banana")))
178
-	assert.Assert(t, err)
178
+	assert.NilError(t, err)
179 179
 	assert.Assert(t, is.Len(pr.VolumesDeleted, 0))
180 180
 
181 181
 	pr, err = service.Prune(ctx, filters.NewArgs())
182
-	assert.Assert(t, err)
182
+	assert.NilError(t, err)
183 183
 	assert.Assert(t, is.Len(pr.VolumesDeleted, 1))
184 184
 	assert.Assert(t, is.Equal(pr.VolumesDeleted[0], "test"))
185 185
 
... ...
@@ -187,48 +187,48 @@ func TestServicePrune(t *testing.T) {
187 187
 	assert.Assert(t, IsNotExist(err), err)
188 188
 
189 189
 	v, err := service.Get(ctx, "test2")
190
-	assert.Assert(t, err)
190
+	assert.NilError(t, err)
191 191
 	assert.Assert(t, is.Equal(v.Driver, "other"))
192 192
 
193 193
 	_, err = service.Create(ctx, "test", volume.DefaultDriverName)
194
-	assert.Assert(t, err)
194
+	assert.NilError(t, err)
195 195
 
196 196
 	pr, err = service.Prune(ctx, filters.NewArgs(filters.Arg("label!", "banana")))
197
-	assert.Assert(t, err)
197
+	assert.NilError(t, err)
198 198
 	assert.Assert(t, is.Len(pr.VolumesDeleted, 1))
199 199
 	assert.Assert(t, is.Equal(pr.VolumesDeleted[0], "test"))
200 200
 	v, err = service.Get(ctx, "test2")
201
-	assert.Assert(t, err)
201
+	assert.NilError(t, err)
202 202
 	assert.Assert(t, is.Equal(v.Driver, "other"))
203 203
 
204 204
 	_, err = service.Create(ctx, "test", volume.DefaultDriverName, opts.WithCreateLabels(map[string]string{"banana": ""}))
205
-	assert.Assert(t, err)
205
+	assert.NilError(t, err)
206 206
 	pr, err = service.Prune(ctx, filters.NewArgs(filters.Arg("label!", "banana")))
207
-	assert.Assert(t, err)
207
+	assert.NilError(t, err)
208 208
 	assert.Assert(t, is.Len(pr.VolumesDeleted, 0))
209 209
 
210 210
 	_, err = service.Create(ctx, "test3", volume.DefaultDriverName, opts.WithCreateLabels(map[string]string{"banana": "split"}))
211
-	assert.Assert(t, err)
211
+	assert.NilError(t, err)
212 212
 	pr, err = service.Prune(ctx, filters.NewArgs(filters.Arg("label!", "banana=split")))
213
-	assert.Assert(t, err)
213
+	assert.NilError(t, err)
214 214
 	assert.Assert(t, is.Len(pr.VolumesDeleted, 1))
215 215
 	assert.Assert(t, is.Equal(pr.VolumesDeleted[0], "test"))
216 216
 
217 217
 	pr, err = service.Prune(ctx, filters.NewArgs(filters.Arg("label", "banana=split")))
218
-	assert.Assert(t, err)
218
+	assert.NilError(t, err)
219 219
 	assert.Assert(t, is.Len(pr.VolumesDeleted, 1))
220 220
 	assert.Assert(t, is.Equal(pr.VolumesDeleted[0], "test3"))
221 221
 
222 222
 	v, err = service.Create(ctx, "test", volume.DefaultDriverName, opts.WithCreateReference(t.Name()))
223
-	assert.Assert(t, err)
223
+	assert.NilError(t, err)
224 224
 
225 225
 	pr, err = service.Prune(ctx, filters.NewArgs())
226
-	assert.Assert(t, err)
226
+	assert.NilError(t, err)
227 227
 	assert.Assert(t, is.Len(pr.VolumesDeleted, 0))
228 228
 	assert.Assert(t, service.Release(ctx, v.Name, t.Name()))
229 229
 
230 230
 	pr, err = service.Prune(ctx, filters.NewArgs())
231
-	assert.Assert(t, err)
231
+	assert.NilError(t, err)
232 232
 	assert.Assert(t, is.Len(pr.VolumesDeleted, 1))
233 233
 	assert.Assert(t, is.Equal(pr.VolumesDeleted[0], "test"))
234 234
 }
... ...
@@ -237,10 +237,10 @@ func newTestService(t *testing.T, ds *volumedrivers.Store) (*VolumesService, fun
237 237
 	t.Helper()
238 238
 
239 239
 	dir, err := ioutil.TempDir("", t.Name())
240
-	assert.Assert(t, err)
240
+	assert.NilError(t, err)
241 241
 
242 242
 	store, err := NewStore(dir, ds)
243
-	assert.Assert(t, err)
243
+	assert.NilError(t, err)
244 244
 	s := &VolumesService{vs: store, eventLogger: dummyEventLogger{}}
245 245
 	return s, func() {
246 246
 		assert.Check(t, s.Shutdown())
... ...
@@ -179,12 +179,12 @@ func TestFindByReferenced(t *testing.T) {
179 179
 	}
180 180
 
181 181
 	dangling, _, err := s.Find(ctx, ByReferenced(false))
182
-	assert.Assert(t, err)
182
+	assert.NilError(t, err)
183 183
 	assert.Assert(t, len(dangling) == 1)
184 184
 	assert.Check(t, dangling[0].Name() == "fake2")
185 185
 
186 186
 	used, _, err := s.Find(ctx, ByReferenced(true))
187
-	assert.Assert(t, err)
187
+	assert.NilError(t, err)
188 188
 	assert.Assert(t, len(used) == 1)
189 189
 	assert.Check(t, used[0].Name() == "fake1")
190 190
 }