Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>
| ... | ... |
@@ -193,6 +193,11 @@ for each. |
| 193 | 193 |
# They should ask for any editorial change that makes the documentation more |
| 194 | 194 |
# consistent and easier to understand. |
| 195 | 195 |
# |
| 196 |
+ # Changes and additions to docs must be reviewed and approved (LGTM'd) by a minimum of |
|
| 197 |
+ # two docs sub-project maintainers. If the docs change originates with a docs |
|
| 198 |
+ # maintainer, only one additional LGTM is required (since we assume a docs maintainer |
|
| 199 |
+ # approves of their own PR). |
|
| 200 |
+ # |
|
| 196 | 201 |
# Once documentation is approved (see below), a maintainer should make sure to remove this |
| 197 | 202 |
# label and add the next one. |
| 198 | 203 |
|
| ... | ... |
@@ -201,11 +206,6 @@ for each. |
| 201 | 201 |
1-design-review = "raises design concerns" |
| 202 | 202 |
4-merge = "general case" |
| 203 | 203 |
|
| 204 |
- # Docs approval |
|
| 205 |
- [Rules.review.docs-approval] |
|
| 206 |
- # Changes and additions to docs must be reviewed and approved (LGTM'd) by a minimum of two docs sub-project maintainers. |
|
| 207 |
- # If the docs change originates with a docs maintainer, only one additional LGTM is required (since we assume a docs maintainer approves of their own PR). |
|
| 208 |
- |
|
| 209 | 204 |
# Merge |
| 210 | 205 |
[Rules.review.states.4-merge] |
| 211 | 206 |
|