pkg/plugins/plugins.go:231:6: shadow: declaration of "pl" shadows declaration at line 214 (govet)
if pl, exists := storage.plugins[name]; exists {
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| ... | ... |
@@ -211,7 +211,7 @@ func loadWithRetry(name string, retry bool) (*Plugin, error) {
|
| 211 | 211 |
} |
| 212 | 212 |
var retries int |
| 213 | 213 |
for {
|
| 214 |
- pl, err := registry.Plugin(name) |
|
| 214 |
+ plugin, err := registry.Plugin(name) |
|
| 215 | 215 |
if err != nil {
|
| 216 | 216 |
if !retry {
|
| 217 | 217 |
return nil, err |
| ... | ... |
@@ -232,17 +232,17 @@ func loadWithRetry(name string, retry bool) (*Plugin, error) {
|
| 232 | 232 |
storage.Unlock() |
| 233 | 233 |
return pl, pl.activate() |
| 234 | 234 |
} |
| 235 |
- storage.plugins[name] = pl |
|
| 235 |
+ storage.plugins[name] = plugin |
|
| 236 | 236 |
storage.Unlock() |
| 237 | 237 |
|
| 238 |
- err = pl.activate() |
|
| 238 |
+ err = plugin.activate() |
|
| 239 | 239 |
if err != nil {
|
| 240 | 240 |
storage.Lock() |
| 241 | 241 |
delete(storage.plugins, name) |
| 242 | 242 |
storage.Unlock() |
| 243 | 243 |
} |
| 244 | 244 |
|
| 245 |
- return pl, err |
|
| 245 |
+ return plugin, err |
|
| 246 | 246 |
} |
| 247 | 247 |
} |
| 248 | 248 |
|