Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
unclejack authored on 2016/12/15 05:36:58... | ... |
@@ -204,10 +204,7 @@ func verifyPlatformContainerSettings(daemon *Daemon, hostConfig *containertypes. |
204 | 204 |
|
205 | 205 |
w, err := verifyContainerResources(&hostConfig.Resources, hyperv) |
206 | 206 |
warnings = append(warnings, w...) |
207 |
- if err != nil { |
|
208 |
- return warnings, err |
|
209 |
- } |
|
210 |
- return warnings, nil |
|
207 |
+ return warnings, err |
|
211 | 208 |
} |
212 | 209 |
|
213 | 210 |
// platformReload update configuration with platform specific options |
... | ... |
@@ -380,10 +380,7 @@ func (devices *DeviceSet) isDeviceIDFree(deviceID int) bool { |
380 | 380 |
var mask byte |
381 | 381 |
i := deviceID % 8 |
382 | 382 |
mask = (1 << uint(i)) |
383 |
- if (devices.deviceIDMap[deviceID/8] & mask) != 0 { |
|
384 |
- return false |
|
385 |
- } |
|
386 |
- return true |
|
383 |
+ return (devices.deviceIDMap[deviceID/8] & mask) == 0 |
|
387 | 384 |
} |
388 | 385 |
|
389 | 386 |
// Should be called with devices.Lock() held. |
... | ... |
@@ -1400,10 +1397,7 @@ func (devices *DeviceSet) saveTransactionMetaData() error { |
1400 | 1400 |
} |
1401 | 1401 |
|
1402 | 1402 |
func (devices *DeviceSet) removeTransactionMetaData() error { |
1403 |
- if err := os.RemoveAll(devices.transactionMetaFile()); err != nil { |
|
1404 |
- return err |
|
1405 |
- } |
|
1406 |
- return nil |
|
1403 |
+ return os.RemoveAll(devices.transactionMetaFile()) |
|
1407 | 1404 |
} |
1408 | 1405 |
|
1409 | 1406 |
func (devices *DeviceSet) rollbackTransaction() error { |
... | ... |
@@ -2408,11 +2402,7 @@ func (devices *DeviceSet) UnmountDevice(hash, mountPath string) error { |
2408 | 2408 |
} |
2409 | 2409 |
logrus.Debug("devmapper: Unmount done") |
2410 | 2410 |
|
2411 |
- if err := devices.deactivateDevice(info); err != nil { |
|
2412 |
- return err |
|
2413 |
- } |
|
2414 |
- |
|
2415 |
- return nil |
|
2411 |
+ return devices.deactivateDevice(info) |
|
2416 | 2412 |
} |
2417 | 2413 |
|
2418 | 2414 |
// HasDevice returns true if the device metadata exists. |
... | ... |
@@ -775,11 +775,7 @@ func (d *Driver) resolveID(id string) (string, error) { |
775 | 775 |
|
776 | 776 |
// setID stores the layerId in disk. |
777 | 777 |
func (d *Driver) setID(id, altID string) error { |
778 |
- err := ioutil.WriteFile(filepath.Join(d.dir(id), "layerId"), []byte(altID), 0600) |
|
779 |
- if err != nil { |
|
780 |
- return err |
|
781 |
- } |
|
782 |
- return nil |
|
778 |
+ return ioutil.WriteFile(filepath.Join(d.dir(id), "layerId"), []byte(altID), 0600) |
|
783 | 779 |
} |
784 | 780 |
|
785 | 781 |
// getLayerChain returns the layer chain information. |
... | ... |
@@ -155,8 +155,5 @@ func callEventWriteString(message string) error { |
155 | 155 |
|
156 | 156 |
func callEventUnregister() bool { |
157 | 157 |
ret, _, _ := procEventUnregister.Call(uintptr(providerHandle)) |
158 |
- if ret != win32CallSuccess { |
|
159 |
- return false |
|
160 |
- } |
|
161 |
- return true |
|
158 |
+ return ret == win32CallSuccess |
|
162 | 159 |
} |
... | ... |
@@ -182,11 +182,8 @@ func ValidateLogOpt(cfg map[string]string) error { |
182 | 182 |
} |
183 | 183 |
} |
184 | 184 |
|
185 |
- if _, err := parseAddress(cfg["fluentd-address"]); err != nil { |
|
186 |
- return err |
|
187 |
- } |
|
188 |
- |
|
189 |
- return nil |
|
185 |
+ _, err := parseAddress(cfg["fluentd-address"]) |
|
186 |
+ return err |
|
190 | 187 |
} |
191 | 188 |
|
192 | 189 |
func parseAddress(address string) (*location, error) { |
... | ... |
@@ -172,11 +172,8 @@ func ValidateLogOpt(cfg map[string]string) error { |
172 | 172 |
} |
173 | 173 |
} |
174 | 174 |
|
175 |
- if _, err := parseAddress(cfg["gelf-address"]); err != nil { |
|
176 |
- return err |
|
177 |
- } |
|
178 |
- |
|
179 |
- return nil |
|
175 |
+ _, err := parseAddress(cfg["gelf-address"]) |
|
176 |
+ return err |
|
180 | 177 |
} |
181 | 178 |
|
182 | 179 |
func parseAddress(address string) (string, error) { |