Browse code

don't obfuscate error during create

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

Brian Goff authored on 2017/03/31 23:59:45
Showing 2 changed files
... ...
@@ -20,7 +20,6 @@ import (
20 20
 	"github.com/docker/docker/pkg/idtools"
21 21
 	"github.com/docker/docker/pkg/stringid"
22 22
 	"github.com/docker/docker/runconfig"
23
-	volumestore "github.com/docker/docker/volume/store"
24 23
 	"github.com/opencontainers/runc/libcontainer/label"
25 24
 )
26 25
 
... ...
@@ -242,9 +241,6 @@ func (daemon *Daemon) VolumeCreate(name, driverName string, opts, labels map[str
242 242
 
243 243
 	v, err := daemon.volumes.Create(name, driverName, opts, labels)
244 244
 	if err != nil {
245
-		if volumestore.IsNameConflict(err) {
246
-			return nil, fmt.Errorf("A volume named %s already exists. Choose a different volume name.", name)
247
-		}
248 245
 		return nil, err
249 246
 	}
250 247
 
... ...
@@ -287,7 +287,7 @@ func (s *DockerExternalVolumeSuite) TestVolumeCLICreateOptionConflict(c *check.C
287 287
 
288 288
 	out, _, err := dockerCmdWithError("volume", "create", "test", "--driver", volumePluginName)
289 289
 	c.Assert(err, check.NotNil, check.Commentf("volume create exception name already in use with another driver"))
290
-	c.Assert(out, checker.Contains, "A volume named test already exists")
290
+	c.Assert(out, checker.Contains, "must be unique")
291 291
 
292 292
 	out, _ = dockerCmd(c, "volume", "inspect", "--format={{ .Driver }}", "test")
293 293
 	_, _, err = dockerCmdWithError("volume", "create", "test", "--driver", strings.TrimSpace(out))
... ...
@@ -570,7 +570,7 @@ func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverOutOfBandDelete(c *c
570 570
 
571 571
 	out, err = s.d.Cmd("volume", "create", "-d", "local", "--name", "test")
572 572
 	c.Assert(err, checker.NotNil, check.Commentf(out))
573
-	c.Assert(out, checker.Contains, "volume named test already exists")
573
+	c.Assert(out, checker.Contains, "must be unique")
574 574
 
575 575
 	// simulate out of band volume deletion on plugin level
576 576
 	delete(p.vols, "test")