Browse code

Adds Fred to list of people and clarifies that docs approval requires only two LGTMS (not a "majority" as it was before Mary and Steve were added).

Docker-DCO-1.1-Signed-off-by: Fred Lifton <fred.lifton@docker.com> (github: fredlf)

Fred Lifton authored on 2015/03/12 09:38:35
Showing 1 changed files
... ...
@@ -193,13 +193,18 @@ for each.
193 193
 			# They should ask for any editorial change that makes the documentation more
194 194
 			# consistent and easier to understand.
195 195
 			#
196
-			# Once documentation is approved, a maintainer should make sure to remove this
196
+			# Once documentation is approved (see below), a maintainer should make sure to remove this
197 197
 			# label and add the next one.
198 198
 
199 199
 			close = ""
200 200
 			2-code-review = "requires more code changes"
201 201
 			1-design-review = "raises design concerns"
202 202
 			4-merge = "general case"
203
+			
204
+		# Docs approval
205
+		[Rules.review.docs-approval]
206
+			# Changes and additions to docs must be reviewed and approved (LGTM'd) by a minimum of two docs sub-project maintainers.
207
+			# If the docs change originates with a docs maintainer, only one additional LGTM is required (since we assume a docs maintainer approves of their own PR). 	
203 208
 
204 209
 		# Merge
205 210
 		[Rules.review.states.4-merge]
... ...
@@ -535,6 +540,11 @@ made through a pull request.
535 535
 	Email = "estesp@linux.vnet.ibm.com"
536 536
 	GitHub = "estesp"
537 537
 
538
+	[people.fredlf]
539
+	Name = "Fred Lifton"
540
+	Email = "fred.lifton@docker.com"
541
+	GitHub = "fredlf"
542
+
538 543
 	[people.icecrime]
539 544
 	Name = "Arnaud Porterie"
540 545
 	Email = "arnaud@docker.com"