Browse code

Merge pull request #51099 from thaJeztah/consistent_alias

use consistent alias for docker image spec

Sebastiaan van Stijn authored on 2025/10/06 21:51:09
Showing 8 changed files
... ...
@@ -194,6 +194,8 @@ linters:
194 194
           alias: c8dimages
195 195
         - pkg: github.com/opencontainers/image-spec/specs-go/v1
196 196
           alias: ocispec
197
+        - pkg: github.com/moby/docker-image-spec/specs-go/v1
198
+          alias: dockerspec
197 199
         - pkg: go.etcd.io/bbolt
198 200
           alias: bolt
199 201
           # Enforce that gotest.tools/v3/assert/cmp is always aliased as "is"
... ...
@@ -12,7 +12,7 @@ import (
12 12
 	"github.com/containerd/log"
13 13
 	"github.com/containerd/platforms"
14 14
 	"github.com/distribution/reference"
15
-	imagespec "github.com/moby/docker-image-spec/specs-go/v1"
15
+	dockerspec "github.com/moby/docker-image-spec/specs-go/v1"
16 16
 	"github.com/moby/moby/v2/daemon/images"
17 17
 	"github.com/moby/moby/v2/daemon/internal/image"
18 18
 	"github.com/moby/moby/v2/daemon/server/imagebackend"
... ...
@@ -54,7 +54,7 @@ func (i *ImageService) GetImage(ctx context.Context, refOrID string, options ima
54 54
 		return nil, err
55 55
 	}
56 56
 
57
-	var ociImage imagespec.DockerOCIImage
57
+	var ociImage dockerspec.DockerOCIImage
58 58
 	err = im.ReadConfig(ctx, &ociImage)
59 59
 	if err != nil {
60 60
 		return nil, err
... ...
@@ -21,7 +21,7 @@ import (
21 21
 	"github.com/containerd/log"
22 22
 	"github.com/containerd/platforms"
23 23
 	"github.com/distribution/reference"
24
-	imagespec "github.com/moby/docker-image-spec/specs-go/v1"
24
+	dockerspec "github.com/moby/docker-image-spec/specs-go/v1"
25 25
 	"github.com/moby/go-archive"
26 26
 	"github.com/moby/moby/api/pkg/progress"
27 27
 	"github.com/moby/moby/api/pkg/streamformatter"
... ...
@@ -491,7 +491,7 @@ func (i *ImageService) CreateImage(ctx context.Context, config []byte, parent st
491 491
 	return image.Clone(imgToCreate, createdImageId), nil
492 492
 }
493 493
 
494
-func (i *ImageService) createImageOCI(ctx context.Context, imgToCreate imagespec.DockerOCIImage,
494
+func (i *ImageService) createImageOCI(ctx context.Context, imgToCreate dockerspec.DockerOCIImage,
495 495
 	parentDigest digest.Digest, layers []ocispec.Descriptor,
496 496
 	containerConfig container.Config,
497 497
 ) (image.ID, error) {
... ...
@@ -536,7 +536,7 @@ func (i *ImageService) createImageOCI(ctx context.Context, imgToCreate imagespec
536 536
 
537 537
 // writeContentsForImage will commit oci image config and manifest into containerd's content store.
538 538
 func writeContentsForImage(ctx context.Context, snName string, cs content.Store,
539
-	newConfig imagespec.DockerOCIImage, layers []ocispec.Descriptor,
539
+	newConfig dockerspec.DockerOCIImage, layers []ocispec.Descriptor,
540 540
 	containerConfig container.Config,
541 541
 ) (
542 542
 	manifestDesc ocispec.Descriptor,
... ...
@@ -16,7 +16,7 @@ import (
16 16
 	"github.com/containerd/containerd/v2/core/snapshots"
17 17
 	cerrdefs "github.com/containerd/errdefs"
18 18
 	"github.com/containerd/log"
19
-	imagespec "github.com/moby/docker-image-spec/specs-go/v1"
19
+	dockerspec "github.com/moby/docker-image-spec/specs-go/v1"
20 20
 	"github.com/moby/go-archive"
21 21
 	"github.com/moby/moby/v2/daemon/internal/image"
22 22
 	"github.com/moby/moby/v2/daemon/server/backend"
... ...
@@ -38,7 +38,7 @@ func (i *ImageService) CommitImage(ctx context.Context, cc backend.CommitConfig)
38 38
 	cs := i.content
39 39
 
40 40
 	var parentManifest ocispec.Manifest
41
-	var parentImage imagespec.DockerOCIImage
41
+	var parentImage dockerspec.DockerOCIImage
42 42
 
43 43
 	// ImageManifest can be nil when committing an image with base FROM scratch
44 44
 	if container.ImageManifest != nil {
... ...
@@ -93,7 +93,7 @@ func (i *ImageService) CommitImage(ctx context.Context, cc backend.CommitConfig)
93 93
 
94 94
 // generateCommitImageConfig generates an OCI Image config based on the
95 95
 // container's image and the CommitConfig options.
96
-func generateCommitImageConfig(baseConfig imagespec.DockerOCIImage, diffID digest.Digest, opts backend.CommitConfig) imagespec.DockerOCIImage {
96
+func generateCommitImageConfig(baseConfig dockerspec.DockerOCIImage, diffID digest.Digest, opts backend.CommitConfig) dockerspec.DockerOCIImage {
97 97
 	if opts.Author == "" {
98 98
 		opts.Author = baseConfig.Author
99 99
 	}
... ...
@@ -116,7 +116,7 @@ func generateCommitImageConfig(baseConfig imagespec.DockerOCIImage, diffID diges
116 116
 		diffIds = append(diffIds, diffID)
117 117
 	}
118 118
 
119
-	return imagespec.DockerOCIImage{
119
+	return dockerspec.DockerOCIImage{
120 120
 		Image: ocispec.Image{
121 121
 			Platform: ocispec.Platform{
122 122
 				Architecture: arch,
... ...
@@ -16,7 +16,7 @@ import (
16 16
 	"github.com/containerd/platforms"
17 17
 	"github.com/distribution/reference"
18 18
 	"github.com/google/uuid"
19
-	imagespec "github.com/moby/docker-image-spec/specs-go/v1"
19
+	dockerspec "github.com/moby/docker-image-spec/specs-go/v1"
20 20
 	"github.com/moby/go-archive/compression"
21 21
 	"github.com/moby/moby/api/types/container"
22 22
 	"github.com/moby/moby/api/types/events"
... ...
@@ -91,7 +91,7 @@ func (i *ImageService) ImportImage(ctx context.Context, ref reference.Named, pla
91 91
 
92 92
 	dockerCfg := containerConfigToDockerOCIImageConfig(imageConfig)
93 93
 	createdAt := time.Now()
94
-	config := imagespec.DockerOCIImage{
94
+	config := dockerspec.DockerOCIImage{
95 95
 		Image: ocispec.Image{
96 96
 			Platform: *platform,
97 97
 			Created:  &createdAt,
... ...
@@ -10,7 +10,7 @@ import (
10 10
 	"github.com/containerd/log"
11 11
 	"github.com/containerd/platforms"
12 12
 	"github.com/distribution/reference"
13
-	imagespec "github.com/moby/docker-image-spec/specs-go/v1"
13
+	dockerspec "github.com/moby/docker-image-spec/specs-go/v1"
14 14
 	imagetypes "github.com/moby/moby/api/types/image"
15 15
 	"github.com/moby/moby/v2/daemon/server/imagebackend"
16 16
 	"github.com/moby/moby/v2/internal/sliceutil"
... ...
@@ -62,7 +62,7 @@ func (i *ImageService) ImageInspect(ctx context.Context, refOrID string, opts im
62 62
 		}
63 63
 	}
64 64
 
65
-	var img imagespec.DockerOCIImage
65
+	var img dockerspec.DockerOCIImage
66 66
 	if multi.Best != nil {
67 67
 		if err := multi.Best.ReadConfig(ctx, &img); err != nil {
68 68
 			return nil, err
... ...
@@ -3,7 +3,7 @@ package containerd
3 3
 import (
4 4
 	"slices"
5 5
 
6
-	imagespec "github.com/moby/docker-image-spec/specs-go/v1"
6
+	dockerspec "github.com/moby/docker-image-spec/specs-go/v1"
7 7
 	"github.com/moby/moby/api/types/container"
8 8
 	"github.com/moby/moby/api/types/network"
9 9
 	"github.com/moby/moby/v2/daemon/internal/image"
... ...
@@ -16,7 +16,7 @@ import (
16 16
 // - V1Image.ContainerConfig
17 17
 // - V1Image.Container
18 18
 // - Details
19
-func dockerOciImageToDockerImagePartial(id image.ID, img imagespec.DockerOCIImage) *image.Image {
19
+func dockerOciImageToDockerImagePartial(id image.ID, img dockerspec.DockerOCIImage) *image.Image {
20 20
 	v1Image := image.V1Image{
21 21
 		DockerVersion: dockerversion.Version,
22 22
 		Config:        dockerOCIImageConfigToContainerConfig(img.Config),
... ...
@@ -39,8 +39,8 @@ func dockerOciImageToDockerImagePartial(id image.ID, img imagespec.DockerOCIImag
39 39
 	return out
40 40
 }
41 41
 
42
-func dockerImageToDockerOCIImage(img image.Image) imagespec.DockerOCIImage {
43
-	return imagespec.DockerOCIImage{
42
+func dockerImageToDockerOCIImage(img image.Image) dockerspec.DockerOCIImage {
43
+	return dockerspec.DockerOCIImage{
44 44
 		Image: ocispec.Image{
45 45
 			Created: img.Created,
46 46
 			Author:  img.Author,
... ...
@@ -61,9 +61,9 @@ func dockerImageToDockerOCIImage(img image.Image) imagespec.DockerOCIImage {
61 61
 	}
62 62
 }
63 63
 
64
-func containerConfigToDockerOCIImageConfig(cfg *container.Config) imagespec.DockerOCIImageConfig {
64
+func containerConfigToDockerOCIImageConfig(cfg *container.Config) dockerspec.DockerOCIImageConfig {
65 65
 	var ociCfg ocispec.ImageConfig
66
-	var ext imagespec.DockerOCIImageConfigExt
66
+	var ext dockerspec.DockerOCIImageConfigExt
67 67
 
68 68
 	if cfg != nil {
69 69
 		ociCfg = ocispec.ImageConfig{
... ...
@@ -89,13 +89,13 @@ func containerConfigToDockerOCIImageConfig(cfg *container.Config) imagespec.Dock
89 89
 		ext.Shell = cfg.Shell
90 90
 	}
91 91
 
92
-	return imagespec.DockerOCIImageConfig{
92
+	return dockerspec.DockerOCIImageConfig{
93 93
 		ImageConfig:             ociCfg,
94 94
 		DockerOCIImageConfigExt: ext,
95 95
 	}
96 96
 }
97 97
 
98
-func dockerOCIImageConfigToContainerConfig(cfg imagespec.DockerOCIImageConfig) *container.Config {
98
+func dockerOCIImageConfigToContainerConfig(cfg dockerspec.DockerOCIImageConfig) *container.Config {
99 99
 	exposedPorts := make(network.PortSet, len(cfg.ExposedPorts))
100 100
 	for k := range cfg.ExposedPorts {
101 101
 		if p, err := network.ParsePort(k); err == nil {
... ...
@@ -1,14 +1,14 @@
1 1
 package images
2 2
 
3 3
 import (
4
-	imagespec "github.com/moby/docker-image-spec/specs-go/v1"
4
+	dockerspec "github.com/moby/docker-image-spec/specs-go/v1"
5 5
 	"github.com/moby/moby/api/types/container"
6 6
 	ocispec "github.com/opencontainers/image-spec/specs-go/v1"
7 7
 )
8 8
 
9
-func containerConfigToDockerOCIImageConfig(cfg *container.Config) imagespec.DockerOCIImageConfig {
9
+func containerConfigToDockerOCIImageConfig(cfg *container.Config) dockerspec.DockerOCIImageConfig {
10 10
 	var ociCfg ocispec.ImageConfig
11
-	var ext imagespec.DockerOCIImageConfigExt
11
+	var ext dockerspec.DockerOCIImageConfigExt
12 12
 
13 13
 	if cfg != nil {
14 14
 		ociCfg = ocispec.ImageConfig{
... ...
@@ -34,7 +34,7 @@ func containerConfigToDockerOCIImageConfig(cfg *container.Config) imagespec.Dock
34 34
 		ext.Shell = cfg.Shell
35 35
 	}
36 36
 
37
-	return imagespec.DockerOCIImageConfig{
37
+	return dockerspec.DockerOCIImageConfig{
38 38
 		ImageConfig:             ociCfg,
39 39
 		DockerOCIImageConfigExt: ext,
40 40
 	}