Despite the current issue with unix sockets and golang, I'm bumping this back up to 1.6.
Go <1.6 has major compatibility issues on ppc64* including not supporting dynamic binding,
so we would have to go back to gccgo, which is worse in a lot of other categories. Ultimately for us,
the amount of people affected by this issue isn't worth switching compilers.
Signed-off-by: Christopher Jones <tophj@linux.vnet.ibm.com>
| ... | ... |
@@ -71,11 +71,9 @@ RUN cd /usr/local/lvm2 \ |
| 71 | 71 |
&& make install_device-mapper |
| 72 | 72 |
# see https://git.fedorahosted.org/cgit/lvm2.git/tree/INSTALL |
| 73 | 73 |
|
| 74 |
-# TODO install Go, using gccgo as GOROOT_BOOTSTRAP (Go 1.5+ supports ppc64le properly) |
|
| 75 |
-# possibly a ppc64le/golang image? |
|
| 76 |
- |
|
| 77 |
-## BUILD GOLANG 1.5.3 |
|
| 78 |
-ENV GO_VERSION 1.5.3 |
|
| 74 |
+## BUILD GOLANG 1.6 |
|
| 75 |
+# NOTE: ppc64le has compatibility issues with older versions of go, so make sure the version >= 1.6 |
|
| 76 |
+ENV GO_VERSION 1.6 |
|
| 79 | 77 |
ENV GO_DOWNLOAD_URL https://golang.org/dl/go${GO_VERSION}.src.tar.gz
|
| 80 | 78 |
ENV GO_DOWNLOAD_SHA256 a96cce8ce43a9bf9b2a4c7d470bc7ee0cb00410da815980681c8353218dcf146 |
| 81 | 79 |
ENV GOROOT_BOOTSTRAP /usr/local |
| ... | ... |
@@ -129,13 +127,12 @@ RUN set -x \ |
| 129 | 129 |
# Install notary and notary-server |
| 130 | 130 |
ENV NOTARY_VERSION docker-v1.11-3 |
| 131 | 131 |
RUN set -x \ |
| 132 |
- && export GO15VENDOREXPERIMENT=1 \ |
|
| 133 | 132 |
&& export GOPATH="$(mktemp -d)" \ |
| 134 | 133 |
&& git clone https://github.com/docker/notary.git "$GOPATH/src/github.com/docker/notary" \ |
| 135 | 134 |
&& (cd "$GOPATH/src/github.com/docker/notary" && git checkout -q "$NOTARY_VERSION") \ |
| 136 |
- && GOPATH="$GOPATH/src/github.com/docker/notary/vendor:$GOPATH" \ |
|
| 135 |
+ && GOPATH="$GOPATH/src/github.com/docker/notary/Godeps/_workspace:$GOPATH" \ |
|
| 137 | 136 |
go build -o /usr/local/bin/notary-server github.com/docker/notary/cmd/notary-server \ |
| 138 |
- && GOPATH="$GOPATH/src/github.com/docker/notary/vendor:$GOPATH" \ |
|
| 137 |
+ && GOPATH="$GOPATH/src/github.com/docker/notary/Godeps/_workspace:$GOPATH" \ |
|
| 139 | 138 |
go build -o /usr/local/bin/notary github.com/docker/notary/cmd/notary \ |
| 140 | 139 |
&& rm -rf "$GOPATH" |
| 141 | 140 |
|