Browse code

Small tweaks to the hack scripts to make them simpler

Please do with this as you please (including rebasing and/or squashing it), especially under clause (c) of the DCO.

Docker-DCO-1.1-Signed-off-by: Andrew Page <admwiggin@gmail.com> (github: tianon)

Tianon Gravi authored on 2014/03/21 07:46:55
Showing 2 changed files
... ...
@@ -11,5 +11,6 @@ go build \
11 11
 	" \
12 12
 	./docker
13 13
 echo "Created binary: $DEST/docker-$VERSION"
14
+ln -sf "docker-$VERSION" "$DEST/docker"
14 15
 
15 16
 hash_files "$DEST/docker-$VERSION"
... ...
@@ -1,37 +1,28 @@
1 1
 #!/bin/bash
2 2
 
3 3
 DEST=$1
4
-DOCKERBIN=$DEST/../binary/docker-$VERSION
5
-DYNDOCKERBIN=$DEST/../dynbinary/docker-$VERSION
6
-DOCKERINITBIN=$DEST/../dynbinary/dockerinit-$VERSION
7 4
 
8 5
 set -e
9 6
 
7
+# subshell so that we can export PATH without breaking other things
8
+(
9
+export PATH="$DEST/../binary:$DEST/../dynbinary:$PATH"
10
+
10 11
 bundle_test_integration_cli() {
11 12
 	go_test_dir ./integration-cli
12 13
 }
13 14
 
14
-if [ -x "/usr/bin/docker" ]; then
15
-	echo "docker found at /usr/bin/docker"
16
-elif [ -x "$DOCKERBIN" ]; then
17
-	ln -s $DOCKERBIN /usr/bin/docker
18
-elif [ -x "$DYNDOCKERBIN" ]; then
19
-	ln -s $DYNDOCKERBIN /usr/bin/docker
20
-	ln -s $DOCKERINITBIN /usr/bin/dockerinit
21
-else
15
+if ! command -v docker &> /dev/null; then
22 16
 	echo >&2 'error: binary or dynbinary must be run before test-integration-cli'
23 17
 	false
24 18
 fi
25 19
 
26
-
27 20
 docker -d -D -p $DEST/docker.pid &> $DEST/docker.log &
28
-sleep 2
29
-docker info
30
-DOCKERD_PID=`cat $DEST/docker.pid`
31 21
 
32 22
 bundle_test_integration_cli 2>&1 \
33 23
 	| tee $DEST/test.log
34 24
 
25
+DOCKERD_PID=$(cat $DEST/docker.pid)
35 26
 kill $DOCKERD_PID
36 27
 wait $DOCKERD_PID
37
-
28
+)