Browse code

Just pass the container in RegisterLinks(), no need to lookup by name again

Roel Van Nyen authored on 2014/01/03 23:47:22
Showing 1 changed files
... ...
@@ -1714,12 +1714,8 @@ func (srv *Server) ImageGetCached(imgID string, config *Config) (*Image, error)
1714 1714
 	return nil, nil
1715 1715
 }
1716 1716
 
1717
-func (srv *Server) RegisterLinks(name string, hostConfig *HostConfig) error {
1717
+func (srv *Server) RegisterLinks(container *Container, hostConfig *HostConfig) error {
1718 1718
 	runtime := srv.runtime
1719
-	container := runtime.Get(name)
1720
-	if container == nil {
1721
-		return fmt.Errorf("No such container: %s", name)
1722
-	}
1723 1719
 
1724 1720
 	if hostConfig != nil && hostConfig.Links != nil {
1725 1721
 		for _, l := range hostConfig.Links {
... ...
@@ -1792,8 +1788,7 @@ func (srv *Server) ContainerStart(job *engine.Job) engine.Status {
1792 1792
 			}
1793 1793
 		}
1794 1794
 		// Register any links from the host config before starting the container
1795
-		// FIXME: we could just pass the container here, no need to lookup by name again.
1796
-		if err := srv.RegisterLinks(name, &hostConfig); err != nil {
1795
+		if err := srv.RegisterLinks(container, &hostConfig); err != nil {
1797 1796
 			job.Error(err)
1798 1797
 			return engine.StatusErr
1799 1798
 		}