Browse code

Fix TestSecretCreateWithLabels nondeterminism

This test checks for the substring "foo" in the "secret ls" output. This
is a valid base36 substring and can sometimes show up by chance:

docker_cli_secret_create_test.go:86:
c.Assert(out, checker.Not(checker.Contains), name)
... obtained string = "" +
... "ID NAME CREATED UPDATED\n" +
... "ob8y4t4feuz8pn5h6vla9oxoz stefoo7e268ozqfupi9s4se9q Less than a second ago Less than a second ago\n"
... substring string = "foo"

Change the secret name to test_secret, matching other tests. Underscores
can't appear in base36 so this name is safe to grep for.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>

Aaron Lehmann authored on 2017/01/06 08:22:51
Showing 1 changed files
... ...
@@ -55,7 +55,7 @@ func (s *DockerSwarmSuite) TestSecretCreateWithLabels(c *check.C) {
55 55
 func (s *DockerSwarmSuite) TestSecretCreateResolve(c *check.C) {
56 56
 	d := s.AddDaemon(c, true, true)
57 57
 
58
-	name := "foo"
58
+	name := "test_secret"
59 59
 	id := d.CreateSecret(c, swarm.SecretSpec{
60 60
 		swarm.Annotations{
61 61
 			Name: name,