Browse code

Remove Job from rename

A part of ISSUE#12151-Remove engine.Job mechanism

Signed-off-by: Hu Keping <hukeping@huawei.com>

Hu Keping authored on 2015/04/10 02:52:55
Showing 3 changed files
... ...
@@ -859,10 +859,10 @@ func postContainerRename(eng *engine.Engine, version version.Version, w http.Res
859 859
 		return fmt.Errorf("Missing parameter")
860 860
 	}
861 861
 
862
-	newName := r.URL.Query().Get("name")
863
-	job := eng.Job("container_rename", vars["name"], newName)
864
-	job.Setenv("t", r.Form.Get("t"))
865
-	if err := job.Run(); err != nil {
862
+	d := getDaemon(eng)
863
+	name := vars["name"]
864
+	newName := r.Form.Get("name")
865
+	if err := d.ContainerRename(name, newName); err != nil {
866 866
 		return err
867 867
 	}
868 868
 	w.WriteHeader(http.StatusNoContent)
... ...
@@ -119,7 +119,6 @@ func (daemon *Daemon) Install(eng *engine.Engine) error {
119 119
 	for name, method := range map[string]engine.Handler{
120 120
 		"commit":            daemon.ContainerCommit,
121 121
 		"container_copy":    daemon.ContainerCopy,
122
-		"container_rename":  daemon.ContainerRename,
123 122
 		"container_inspect": daemon.ContainerInspect,
124 123
 		"container_stats":   daemon.ContainerStats,
125 124
 		"create":            daemon.ContainerCreate,
... ...
@@ -2,16 +2,12 @@ package daemon
2 2
 
3 3
 import (
4 4
 	"fmt"
5
-
6
-	"github.com/docker/docker/engine"
7 5
 )
8 6
 
9
-func (daemon *Daemon) ContainerRename(job *engine.Job) error {
10
-	if len(job.Args) != 2 {
11
-		return fmt.Errorf("usage: %s OLD_NAME NEW_NAME", job.Name)
7
+func (daemon *Daemon) ContainerRename(oldName, newName string) error {
8
+	if oldName == "" || newName == "" {
9
+		return fmt.Errorf("usage: docker rename OLD_NAME NEW_NAME")
12 10
 	}
13
-	oldName := job.Args[0]
14
-	newName := job.Args[1]
15 11
 
16 12
 	container, err := daemon.Get(oldName)
17 13
 	if err != nil {