Browse code

Merge pull request #4312 from shykes/engine-error-reporting

Engine: clearer job error reporting

Victor Vieux authored on 2014/02/25 06:58:12
Showing 1 changed files
... ...
@@ -74,7 +74,7 @@ func (job *Job) Run() error {
74 74
 		return err
75 75
 	}
76 76
 	if job.status != 0 {
77
-		return fmt.Errorf("%s: %s", job.Name, errorMessage)
77
+		return fmt.Errorf("%s", errorMessage)
78 78
 	}
79 79
 	return nil
80 80
 }
... ...
@@ -201,11 +201,14 @@ func (job *Job) Printf(format string, args ...interface{}) (n int, err error) {
201 201
 }
202 202
 
203 203
 func (job *Job) Errorf(format string, args ...interface{}) Status {
204
+	if format[len(format)-1] != '\n' {
205
+		format = format + "\n"
206
+	}
204 207
 	fmt.Fprintf(job.Stderr, format, args...)
205 208
 	return StatusErr
206 209
 }
207 210
 
208 211
 func (job *Job) Error(err error) Status {
209
-	fmt.Fprintf(job.Stderr, "%s", err)
212
+	fmt.Fprintf(job.Stderr, "%s\n", err)
210 213
 	return StatusErr
211 214
 }