Browse code

Remove the restriction on multi-user PRs

This came up in #docker-dev today. We're not sure exactly why the original restriction was put it place. It is not well obeyed. Please comment if you know the origin of the restriction.

Docker-DCO-1.1-Signed-off-by: Timothy Hobbs <timothyhobbs@seznam.cz> (github: timthelion)

Timothy Hobbs authored on 2014/08/01 04:48:39
Showing 1 changed files
... ...
@@ -120,8 +120,6 @@ committing your changes. Most editors have plug-ins that do this automatically.
120 120
 Pull requests descriptions should be as clear as possible and include a
121 121
 reference to all the issues that they address.
122 122
 
123
-Pull requests must not contain commits from other users or branches.
124
-
125 123
 Commit messages must start with a capitalized and short summary (max. 50
126 124
 chars) written in the imperative, followed by an optional, more detailed
127 125
 explanatory text which is separated from the summary by an empty line.
... ...
@@ -132,6 +130,12 @@ sure to post a comment after pushing. The new commits will show up in the pull
132 132
 request automatically, but the reviewers will not be notified unless you
133 133
 comment.
134 134
 
135
+Pull requests must be cleanly rebased ontop of master without multiple branches
136
+mixed into the PR.
137
+
138
+**Git tip**: If your PR no longer merges cleanly, use `rebase master` in your
139
+feature branch to update your pull request rather than `merge master`.
140
+
135 141
 Before the pull request is merged, make sure that you squash your commits into
136 142
 logical units of work using `git rebase -i` and `git push -f`. After every
137 143
 commit the test suite should be passing. Include documentation changes in the