Signed-off-by: Daniel Nephin <dnephin@docker.com>
| ... | ... |
@@ -253,7 +253,7 @@ func TestGetWithStatusError(t *testing.T) {
|
| 253 | 253 |
if testcase.expectedErr == "" {
|
| 254 | 254 |
require.NoError(t, err) |
| 255 | 255 |
|
| 256 |
- body, err := testutil.ReadBody(response.Body) |
|
| 256 |
+ body, err := readBody(response.Body) |
|
| 257 | 257 |
require.NoError(t, err) |
| 258 | 258 |
assert.Contains(t, string(body), testcase.expectedBody) |
| 259 | 259 |
} else {
|
| ... | ... |
@@ -261,3 +261,8 @@ func TestGetWithStatusError(t *testing.T) {
|
| 261 | 261 |
} |
| 262 | 262 |
} |
| 263 | 263 |
} |
| 264 |
+ |
|
| 265 |
+func readBody(b io.ReadCloser) ([]byte, error) {
|
|
| 266 |
+ defer b.Close() |
|
| 267 |
+ return ioutil.ReadAll(b) |
|
| 268 |
+} |
| ... | ... |
@@ -545,7 +545,7 @@ func (d *Daemon) queryRootDir() (string, error) {
|
| 545 | 545 |
} |
| 546 | 546 |
var b []byte |
| 547 | 547 |
var i Info |
| 548 |
- b, err = testutil.ReadBody(body) |
|
| 548 |
+ b, err = request.ReadBody(body) |
|
| 549 | 549 |
if err == nil && resp.StatusCode == http.StatusOK {
|
| 550 | 550 |
// read the docker root dir |
| 551 | 551 |
if err = json.Unmarshal(b, &i); err == nil {
|
| ... | ... |
@@ -620,7 +620,7 @@ func (d *Daemon) SockRequest(method, endpoint string, data interface{}) (int, []
|
| 620 | 620 |
if err != nil {
|
| 621 | 621 |
return -1, nil, err |
| 622 | 622 |
} |
| 623 |
- b, err := testutil.ReadBody(body) |
|
| 623 |
+ b, err := request.ReadBody(body) |
|
| 624 | 624 |
return res.StatusCode, b, err |
| 625 | 625 |
} |
| 626 | 626 |
|
| ... | ... |
@@ -15,7 +15,6 @@ import ( |
| 15 | 15 |
"github.com/docker/docker/integration-cli/checker" |
| 16 | 16 |
"github.com/docker/docker/integration-cli/request" |
| 17 | 17 |
"github.com/docker/docker/pkg/stdcopy" |
| 18 |
- "github.com/docker/docker/pkg/testutil" |
|
| 19 | 18 |
"github.com/go-check/check" |
| 20 | 19 |
"golang.org/x/net/websocket" |
| 21 | 20 |
) |
| ... | ... |
@@ -80,7 +79,7 @@ func (s *DockerSuite) TestPostContainersAttachContainerNotFound(c *check.C) {
|
| 80 | 80 |
resp, err := client.Do(req) |
| 81 | 81 |
// connection will shutdown, err should be "persistent connection closed" |
| 82 | 82 |
c.Assert(resp.StatusCode, checker.Equals, http.StatusNotFound) |
| 83 |
- content, err := testutil.ReadBody(resp.Body) |
|
| 83 |
+ content, err := request.ReadBody(resp.Body) |
|
| 84 | 84 |
c.Assert(err, checker.IsNil) |
| 85 | 85 |
expected := "No such container: doesnotexist\r\n" |
| 86 | 86 |
c.Assert(string(content), checker.Equals, expected) |
| ... | ... |
@@ -17,7 +17,6 @@ import ( |
| 17 | 17 |
"github.com/docker/docker/integration-cli/cli/build/fakegit" |
| 18 | 18 |
"github.com/docker/docker/integration-cli/cli/build/fakestorage" |
| 19 | 19 |
"github.com/docker/docker/integration-cli/request" |
| 20 |
- "github.com/docker/docker/pkg/testutil" |
|
| 21 | 20 |
"github.com/go-check/check" |
| 22 | 21 |
"github.com/moby/buildkit/session" |
| 23 | 22 |
"github.com/moby/buildkit/session/filesync" |
| ... | ... |
@@ -47,7 +46,7 @@ RUN find /tmp/` |
| 47 | 47 |
c.Assert(err, checker.IsNil) |
| 48 | 48 |
c.Assert(res.StatusCode, checker.Equals, http.StatusOK) |
| 49 | 49 |
|
| 50 |
- buf, err := testutil.ReadBody(body) |
|
| 50 |
+ buf, err := request.ReadBody(body) |
|
| 51 | 51 |
c.Assert(err, checker.IsNil) |
| 52 | 52 |
|
| 53 | 53 |
// Make sure Dockerfile exists. |
| ... | ... |
@@ -135,7 +134,7 @@ RUN echo 'right' |
| 135 | 135 |
c.Assert(res.StatusCode, checker.Equals, http.StatusOK) |
| 136 | 136 |
|
| 137 | 137 |
defer body.Close() |
| 138 |
- content, err := testutil.ReadBody(body) |
|
| 138 |
+ content, err := request.ReadBody(body) |
|
| 139 | 139 |
c.Assert(err, checker.IsNil) |
| 140 | 140 |
|
| 141 | 141 |
// Build used the wrong dockerfile. |
| ... | ... |
@@ -153,7 +152,7 @@ RUN echo from dockerfile`, |
| 153 | 153 |
c.Assert(err, checker.IsNil) |
| 154 | 154 |
c.Assert(res.StatusCode, checker.Equals, http.StatusOK) |
| 155 | 155 |
|
| 156 |
- buf, err := testutil.ReadBody(body) |
|
| 156 |
+ buf, err := request.ReadBody(body) |
|
| 157 | 157 |
c.Assert(err, checker.IsNil) |
| 158 | 158 |
|
| 159 | 159 |
out := string(buf) |
| ... | ... |
@@ -174,7 +173,7 @@ RUN echo from Dockerfile`, |
| 174 | 174 |
c.Assert(err, checker.IsNil) |
| 175 | 175 |
c.Assert(res.StatusCode, checker.Equals, http.StatusOK) |
| 176 | 176 |
|
| 177 |
- buf, err := testutil.ReadBody(body) |
|
| 177 |
+ buf, err := request.ReadBody(body) |
|
| 178 | 178 |
c.Assert(err, checker.IsNil) |
| 179 | 179 |
|
| 180 | 180 |
out := string(buf) |
| ... | ... |
@@ -196,7 +195,7 @@ RUN echo from dockerfile`, |
| 196 | 196 |
c.Assert(err, checker.IsNil) |
| 197 | 197 |
c.Assert(res.StatusCode, checker.Equals, http.StatusOK) |
| 198 | 198 |
|
| 199 |
- buf, err := testutil.ReadBody(body) |
|
| 199 |
+ buf, err := request.ReadBody(body) |
|
| 200 | 200 |
c.Assert(err, checker.IsNil) |
| 201 | 201 |
|
| 202 | 202 |
out := string(buf) |
| ... | ... |
@@ -243,7 +242,7 @@ func (s *DockerSuite) TestBuildAPIUnnormalizedTarPaths(c *check.C) {
|
| 243 | 243 |
c.Assert(err, checker.IsNil) |
| 244 | 244 |
c.Assert(res.StatusCode, checker.Equals, http.StatusOK) |
| 245 | 245 |
|
| 246 |
- out, err := testutil.ReadBody(body) |
|
| 246 |
+ out, err := request.ReadBody(body) |
|
| 247 | 247 |
c.Assert(err, checker.IsNil) |
| 248 | 248 |
lines := strings.Split(string(out), "\n") |
| 249 | 249 |
c.Assert(len(lines), checker.GreaterThan, 1) |
| ... | ... |
@@ -280,7 +279,7 @@ func (s *DockerSuite) TestBuildOnBuildWithCopy(c *check.C) {
|
| 280 | 280 |
c.Assert(err, checker.IsNil) |
| 281 | 281 |
c.Assert(res.StatusCode, checker.Equals, http.StatusOK) |
| 282 | 282 |
|
| 283 |
- out, err := testutil.ReadBody(body) |
|
| 283 |
+ out, err := request.ReadBody(body) |
|
| 284 | 284 |
c.Assert(err, checker.IsNil) |
| 285 | 285 |
c.Assert(string(out), checker.Contains, "Successfully built") |
| 286 | 286 |
} |
| ... | ... |
@@ -299,7 +298,7 @@ func (s *DockerSuite) TestBuildOnBuildCache(c *check.C) {
|
| 299 | 299 |
require.NoError(c, err) |
| 300 | 300 |
assert.Equal(c, http.StatusOK, res.StatusCode) |
| 301 | 301 |
|
| 302 |
- out, err := testutil.ReadBody(body) |
|
| 302 |
+ out, err := request.ReadBody(body) |
|
| 303 | 303 |
require.NoError(c, err) |
| 304 | 304 |
assert.Contains(c, string(out), "Successfully built") |
| 305 | 305 |
return out |
| ... | ... |
@@ -361,7 +360,7 @@ func (s *DockerRegistrySuite) TestBuildCopyFromForcePull(c *check.C) {
|
| 361 | 361 |
require.NoError(c, err) |
| 362 | 362 |
assert.Equal(c, http.StatusOK, res.StatusCode) |
| 363 | 363 |
|
| 364 |
- out, err := testutil.ReadBody(body) |
|
| 364 |
+ out, err := request.ReadBody(body) |
|
| 365 | 365 |
require.NoError(c, err) |
| 366 | 366 |
assert.Contains(c, string(out), "Successfully built") |
| 367 | 367 |
} |
| ... | ... |
@@ -405,7 +404,7 @@ func (s *DockerSuite) TestBuildAddRemoteNoDecompress(c *check.C) {
|
| 405 | 405 |
require.NoError(c, err) |
| 406 | 406 |
assert.Equal(c, http.StatusOK, res.StatusCode) |
| 407 | 407 |
|
| 408 |
- out, err := testutil.ReadBody(body) |
|
| 408 |
+ out, err := request.ReadBody(body) |
|
| 409 | 409 |
require.NoError(c, err) |
| 410 | 410 |
assert.Contains(c, string(out), "Successfully built") |
| 411 | 411 |
} |
| ... | ... |
@@ -461,7 +460,7 @@ func (s *DockerSuite) TestBuildWithSession(c *check.C) {
|
| 461 | 461 |
require.NoError(c, err) |
| 462 | 462 |
assert.Equal(c, http.StatusOK, res.StatusCode) |
| 463 | 463 |
|
| 464 |
- outBytes, err := testutil.ReadBody(body) |
|
| 464 |
+ outBytes, err := request.ReadBody(body) |
|
| 465 | 465 |
require.NoError(c, err) |
| 466 | 466 |
assert.Contains(c, string(outBytes), "Successfully built") |
| 467 | 467 |
assert.Equal(c, strings.Count(string(outBytes), "Using cache"), 4) |
| ... | ... |
@@ -499,7 +498,7 @@ func testBuildWithSession(c *check.C, dir, dockerfile string) (outStr string) {
|
| 499 | 499 |
return err |
| 500 | 500 |
} |
| 501 | 501 |
assert.Equal(c, res.StatusCode, http.StatusOK) |
| 502 |
- out, err := testutil.ReadBody(body) |
|
| 502 |
+ out, err := request.ReadBody(body) |
|
| 503 | 503 |
require.NoError(c, err) |
| 504 | 504 |
assert.Contains(c, string(out), "Successfully built") |
| 505 | 505 |
sess.Close() |
| ... | ... |
@@ -27,7 +27,6 @@ import ( |
| 27 | 27 |
"github.com/docker/docker/pkg/ioutils" |
| 28 | 28 |
"github.com/docker/docker/pkg/mount" |
| 29 | 29 |
"github.com/docker/docker/pkg/stringid" |
| 30 |
- "github.com/docker/docker/pkg/testutil" |
|
| 31 | 30 |
"github.com/docker/docker/volume" |
| 32 | 31 |
"github.com/go-check/check" |
| 33 | 32 |
) |
| ... | ... |
@@ -735,7 +734,7 @@ func (s *DockerSuite) TestContainerAPIInvalidPortSyntax(c *check.C) {
|
| 735 | 735 |
c.Assert(err, checker.IsNil) |
| 736 | 736 |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| 737 | 737 |
|
| 738 |
- b, err := testutil.ReadBody(body) |
|
| 738 |
+ b, err := request.ReadBody(body) |
|
| 739 | 739 |
c.Assert(err, checker.IsNil) |
| 740 | 740 |
c.Assert(string(b[:]), checker.Contains, "invalid port") |
| 741 | 741 |
} |
| ... | ... |
@@ -755,7 +754,7 @@ func (s *DockerSuite) TestContainerAPIRestartPolicyInvalidPolicyName(c *check.C) |
| 755 | 755 |
c.Assert(err, checker.IsNil) |
| 756 | 756 |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| 757 | 757 |
|
| 758 |
- b, err := testutil.ReadBody(body) |
|
| 758 |
+ b, err := request.ReadBody(body) |
|
| 759 | 759 |
c.Assert(err, checker.IsNil) |
| 760 | 760 |
c.Assert(string(b[:]), checker.Contains, "invalid restart policy") |
| 761 | 761 |
} |
| ... | ... |
@@ -775,7 +774,7 @@ func (s *DockerSuite) TestContainerAPIRestartPolicyRetryMismatch(c *check.C) {
|
| 775 | 775 |
c.Assert(err, checker.IsNil) |
| 776 | 776 |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| 777 | 777 |
|
| 778 |
- b, err := testutil.ReadBody(body) |
|
| 778 |
+ b, err := request.ReadBody(body) |
|
| 779 | 779 |
c.Assert(err, checker.IsNil) |
| 780 | 780 |
c.Assert(string(b[:]), checker.Contains, "maximum retry count cannot be used with restart policy") |
| 781 | 781 |
} |
| ... | ... |
@@ -795,7 +794,7 @@ func (s *DockerSuite) TestContainerAPIRestartPolicyNegativeRetryCount(c *check.C |
| 795 | 795 |
c.Assert(err, checker.IsNil) |
| 796 | 796 |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| 797 | 797 |
|
| 798 |
- b, err := testutil.ReadBody(body) |
|
| 798 |
+ b, err := request.ReadBody(body) |
|
| 799 | 799 |
c.Assert(err, checker.IsNil) |
| 800 | 800 |
c.Assert(string(b[:]), checker.Contains, "maximum retry count cannot be negative") |
| 801 | 801 |
} |
| ... | ... |
@@ -846,7 +845,7 @@ func (s *DockerSuite) TestContainerAPIPostCreateNull(c *check.C) {
|
| 846 | 846 |
c.Assert(err, checker.IsNil) |
| 847 | 847 |
c.Assert(res.StatusCode, checker.Equals, http.StatusCreated) |
| 848 | 848 |
|
| 849 |
- b, err := testutil.ReadBody(body) |
|
| 849 |
+ b, err := request.ReadBody(body) |
|
| 850 | 850 |
c.Assert(err, checker.IsNil) |
| 851 | 851 |
type createResp struct {
|
| 852 | 852 |
ID string |
| ... | ... |
@@ -875,7 +874,7 @@ func (s *DockerSuite) TestCreateWithTooLowMemoryLimit(c *check.C) {
|
| 875 | 875 |
|
| 876 | 876 |
res, body, err := request.Post("/containers/create", request.RawString(config), request.JSON)
|
| 877 | 877 |
c.Assert(err, checker.IsNil) |
| 878 |
- b, err2 := testutil.ReadBody(body) |
|
| 878 |
+ b, err2 := request.ReadBody(body) |
|
| 879 | 879 |
c.Assert(err2, checker.IsNil) |
| 880 | 880 |
|
| 881 | 881 |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| ... | ... |
@@ -12,7 +12,6 @@ import ( |
| 12 | 12 |
|
| 13 | 13 |
"github.com/docker/docker/integration-cli/checker" |
| 14 | 14 |
"github.com/docker/docker/integration-cli/request" |
| 15 |
- "github.com/docker/docker/pkg/testutil" |
|
| 16 | 15 |
"github.com/go-check/check" |
| 17 | 16 |
) |
| 18 | 17 |
|
| ... | ... |
@@ -42,7 +41,7 @@ func (s *DockerSuite) TestExecAPICreateNoValidContentType(c *check.C) {
|
| 42 | 42 |
c.Assert(err, checker.IsNil) |
| 43 | 43 |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| 44 | 44 |
|
| 45 |
- b, err := testutil.ReadBody(body) |
|
| 45 |
+ b, err := request.ReadBody(body) |
|
| 46 | 46 |
c.Assert(err, checker.IsNil) |
| 47 | 47 |
|
| 48 | 48 |
comment := check.Commentf("Expected message when creating exec command with invalid Content-Type specified")
|
| ... | ... |
@@ -109,7 +108,7 @@ func (s *DockerSuite) TestExecAPIStartBackwardsCompatible(c *check.C) {
|
| 109 | 109 |
resp, body, err := request.Post(fmt.Sprintf("/v1.20/exec/%s/start", id), request.RawString(`{"Detach": true}`), request.ContentType("text/plain"))
|
| 110 | 110 |
c.Assert(err, checker.IsNil) |
| 111 | 111 |
|
| 112 |
- b, err := testutil.ReadBody(body) |
|
| 112 |
+ b, err := request.ReadBody(body) |
|
| 113 | 113 |
comment := check.Commentf("response body: %s", b)
|
| 114 | 114 |
c.Assert(err, checker.IsNil, comment) |
| 115 | 115 |
c.Assert(resp.StatusCode, checker.Equals, http.StatusOK, comment) |
| ... | ... |
@@ -144,7 +143,7 @@ func (s *DockerSuite) TestExecAPIStartWithDetach(c *check.C) {
|
| 144 | 144 |
_, body, err := request.Post(fmt.Sprintf("/exec/%s/start", createResp.ID), request.RawString(`{"Detach": true}`), request.JSON)
|
| 145 | 145 |
c.Assert(err, checker.IsNil) |
| 146 | 146 |
|
| 147 |
- b, err = testutil.ReadBody(body) |
|
| 147 |
+ b, err = request.ReadBody(body) |
|
| 148 | 148 |
comment := check.Commentf("response body: %s", b)
|
| 149 | 149 |
c.Assert(err, checker.IsNil, comment) |
| 150 | 150 |
|
| ... | ... |
@@ -207,7 +206,7 @@ func startExec(c *check.C, id string, code int) {
|
| 207 | 207 |
resp, body, err := request.Post(fmt.Sprintf("/exec/%s/start", id), request.RawString(`{"Detach": true}`), request.JSON)
|
| 208 | 208 |
c.Assert(err, checker.IsNil) |
| 209 | 209 |
|
| 210 |
- b, err := testutil.ReadBody(body) |
|
| 210 |
+ b, err := request.ReadBody(body) |
|
| 211 | 211 |
comment := check.Commentf("response body: %s", b)
|
| 212 | 212 |
c.Assert(err, checker.IsNil, comment) |
| 213 | 213 |
c.Assert(resp.StatusCode, checker.Equals, code, comment) |
| ... | ... |
@@ -1,13 +1,12 @@ |
| 1 | 1 |
package main |
| 2 | 2 |
|
| 3 | 3 |
import ( |
| 4 |
+ "encoding/json" |
|
| 4 | 5 |
"net/http" |
| 5 | 6 |
|
| 6 |
- "encoding/json" |
|
| 7 | 7 |
"github.com/docker/docker/api/types" |
| 8 | 8 |
"github.com/docker/docker/integration-cli/checker" |
| 9 | 9 |
"github.com/docker/docker/integration-cli/request" |
| 10 |
- "github.com/docker/docker/pkg/testutil" |
|
| 11 | 10 |
"github.com/go-check/check" |
| 12 | 11 |
) |
| 13 | 12 |
|
| ... | ... |
@@ -52,7 +51,7 @@ func (s *DockerSuite) TestInfoAPIRuncCommit(c *check.C) {
|
| 52 | 52 |
c.Assert(res.StatusCode, checker.Equals, http.StatusOK) |
| 53 | 53 |
c.Assert(err, checker.IsNil) |
| 54 | 54 |
|
| 55 |
- b, err := testutil.ReadBody(body) |
|
| 55 |
+ b, err := request.ReadBody(body) |
|
| 56 | 56 |
c.Assert(err, checker.IsNil) |
| 57 | 57 |
|
| 58 | 58 |
var i types.Info |
| ... | ... |
@@ -5,7 +5,6 @@ import ( |
| 5 | 5 |
|
| 6 | 6 |
"github.com/docker/docker/integration-cli/checker" |
| 7 | 7 |
"github.com/docker/docker/integration-cli/request" |
| 8 |
- "github.com/docker/docker/pkg/testutil" |
|
| 9 | 8 |
"github.com/go-check/check" |
| 10 | 9 |
) |
| 11 | 10 |
|
| ... | ... |
@@ -29,7 +28,7 @@ func (s *DockerSuite) TestSessionCreateWithBadUpgrade(c *check.C) {
|
| 29 | 29 |
res, body, err := request.Post("/session")
|
| 30 | 30 |
c.Assert(err, checker.IsNil) |
| 31 | 31 |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| 32 |
- buf, err := testutil.ReadBody(body) |
|
| 32 |
+ buf, err := request.ReadBody(body) |
|
| 33 | 33 |
c.Assert(err, checker.IsNil) |
| 34 | 34 |
|
| 35 | 35 |
out := string(buf) |
| ... | ... |
@@ -41,7 +40,7 @@ func (s *DockerSuite) TestSessionCreateWithBadUpgrade(c *check.C) {
|
| 41 | 41 |
}) |
| 42 | 42 |
c.Assert(err, checker.IsNil) |
| 43 | 43 |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| 44 |
- buf, err = testutil.ReadBody(body) |
|
| 44 |
+ buf, err = request.ReadBody(body) |
|
| 45 | 45 |
c.Assert(err, checker.IsNil) |
| 46 | 46 |
|
| 47 | 47 |
out = string(buf) |
| ... | ... |
@@ -11,7 +11,6 @@ import ( |
| 11 | 11 |
"github.com/docker/docker/api" |
| 12 | 12 |
"github.com/docker/docker/integration-cli/checker" |
| 13 | 13 |
"github.com/docker/docker/integration-cli/request" |
| 14 |
- "github.com/docker/docker/pkg/testutil" |
|
| 15 | 14 |
"github.com/go-check/check" |
| 16 | 15 |
) |
| 17 | 16 |
|
| ... | ... |
@@ -62,7 +61,7 @@ func (s *DockerSuite) TestAPIErrorJSON(c *check.C) {
|
| 62 | 62 |
c.Assert(err, checker.IsNil) |
| 63 | 63 |
c.Assert(httpResp.StatusCode, checker.Equals, http.StatusBadRequest) |
| 64 | 64 |
c.Assert(httpResp.Header.Get("Content-Type"), checker.Equals, "application/json")
|
| 65 |
- b, err := testutil.ReadBody(body) |
|
| 65 |
+ b, err := request.ReadBody(body) |
|
| 66 | 66 |
c.Assert(err, checker.IsNil) |
| 67 | 67 |
c.Assert(getErrorMessage(c, b), checker.Equals, "Config cannot be empty in order to create a container") |
| 68 | 68 |
} |
| ... | ... |
@@ -75,7 +74,7 @@ func (s *DockerSuite) TestAPIErrorPlainText(c *check.C) {
|
| 75 | 75 |
c.Assert(err, checker.IsNil) |
| 76 | 76 |
c.Assert(httpResp.StatusCode, checker.Equals, http.StatusBadRequest) |
| 77 | 77 |
c.Assert(httpResp.Header.Get("Content-Type"), checker.Contains, "text/plain")
|
| 78 |
- b, err := testutil.ReadBody(body) |
|
| 78 |
+ b, err := request.ReadBody(body) |
|
| 79 | 79 |
c.Assert(err, checker.IsNil) |
| 80 | 80 |
c.Assert(strings.TrimSpace(string(b)), checker.Equals, "Config cannot be empty in order to create a container") |
| 81 | 81 |
} |
| ... | ... |
@@ -86,7 +85,7 @@ func (s *DockerSuite) TestAPIErrorNotFoundJSON(c *check.C) {
|
| 86 | 86 |
c.Assert(err, checker.IsNil) |
| 87 | 87 |
c.Assert(httpResp.StatusCode, checker.Equals, http.StatusNotFound) |
| 88 | 88 |
c.Assert(httpResp.Header.Get("Content-Type"), checker.Equals, "application/json")
|
| 89 |
- b, err := testutil.ReadBody(body) |
|
| 89 |
+ b, err := request.ReadBody(body) |
|
| 90 | 90 |
c.Assert(err, checker.IsNil) |
| 91 | 91 |
c.Assert(getErrorMessage(c, b), checker.Equals, "page not found") |
| 92 | 92 |
} |
| ... | ... |
@@ -96,7 +95,7 @@ func (s *DockerSuite) TestAPIErrorNotFoundPlainText(c *check.C) {
|
| 96 | 96 |
c.Assert(err, checker.IsNil) |
| 97 | 97 |
c.Assert(httpResp.StatusCode, checker.Equals, http.StatusNotFound) |
| 98 | 98 |
c.Assert(httpResp.Header.Get("Content-Type"), checker.Contains, "text/plain")
|
| 99 |
- b, err := testutil.ReadBody(body) |
|
| 99 |
+ b, err := request.ReadBody(body) |
|
| 100 | 100 |
c.Assert(err, checker.IsNil) |
| 101 | 101 |
c.Assert(strings.TrimSpace(string(b)), checker.Equals, "page not found") |
| 102 | 102 |
} |
| ... | ... |
@@ -12,15 +12,15 @@ import ( |
| 12 | 12 |
"path/filepath" |
| 13 | 13 |
"regexp" |
| 14 | 14 |
"strings" |
| 15 |
- "time" |
|
| 16 |
- |
|
| 17 | 15 |
"syscall" |
| 16 |
+ "time" |
|
| 18 | 17 |
|
| 19 | 18 |
"github.com/docker/docker/integration-cli/checker" |
| 20 | 19 |
"github.com/docker/docker/integration-cli/cli" |
| 21 | 20 |
"github.com/docker/docker/integration-cli/cli/build" |
| 22 | 21 |
"github.com/docker/docker/integration-cli/cli/build/fakecontext" |
| 23 | 22 |
icmd "github.com/docker/docker/pkg/testutil/cmd" |
| 23 |
+ units "github.com/docker/go-units" |
|
| 24 | 24 |
"github.com/go-check/check" |
| 25 | 25 |
) |
| 26 | 26 |
|
| ... | ... |
@@ -20,6 +20,7 @@ import ( |
| 20 | 20 |
"github.com/docker/docker/pkg/testutil" |
| 21 | 21 |
icmd "github.com/docker/docker/pkg/testutil/cmd" |
| 22 | 22 |
"github.com/go-check/check" |
| 23 |
+ digest "github.com/opencontainers/go-digest" |
|
| 23 | 24 |
) |
| 24 | 25 |
|
| 25 | 26 |
// save a repo using gz compression and try to load it using stdout |
| ... | ... |
@@ -151,7 +151,7 @@ func (s *DockerSuite) TestDeprecatedStartWithTooLowMemoryLimit(c *check.C) {
|
| 151 | 151 |
|
| 152 | 152 |
res, body, err := request.Post(formatV123StartAPIURL("/containers/"+containerID+"/start"), request.RawString(config), request.JSON)
|
| 153 | 153 |
c.Assert(err, checker.IsNil) |
| 154 |
- b, err2 := testutil.ReadBody(body) |
|
| 154 |
+ b, err2 := request.ReadBody(body) |
|
| 155 | 155 |
c.Assert(err2, checker.IsNil) |
| 156 | 156 |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| 157 | 157 |
c.Assert(string(b), checker.Contains, "Minimum memory limit allowed is 4MB") |
| ... | ... |
@@ -21,7 +21,6 @@ import ( |
| 21 | 21 |
dclient "github.com/docker/docker/client" |
| 22 | 22 |
"github.com/docker/docker/opts" |
| 23 | 23 |
"github.com/docker/docker/pkg/ioutils" |
| 24 |
- "github.com/docker/docker/pkg/testutil" |
|
| 25 | 24 |
"github.com/docker/go-connections/sockets" |
| 26 | 25 |
"github.com/docker/go-connections/tlsconfig" |
| 27 | 26 |
"github.com/pkg/errors" |
| ... | ... |
@@ -214,10 +213,16 @@ func SockRequest(method, endpoint string, data interface{}, daemon string, modif
|
| 214 | 214 |
if err != nil {
|
| 215 | 215 |
return -1, nil, err |
| 216 | 216 |
} |
| 217 |
- b, err := testutil.ReadBody(body) |
|
| 217 |
+ b, err := ReadBody(body) |
|
| 218 | 218 |
return res.StatusCode, b, err |
| 219 | 219 |
} |
| 220 | 220 |
|
| 221 |
+// ReadBody read the specified ReadCloser content and returns it |
|
| 222 |
+func ReadBody(b io.ReadCloser) ([]byte, error) {
|
|
| 223 |
+ defer b.Close() |
|
| 224 |
+ return ioutil.ReadAll(b) |
|
| 225 |
+} |
|
| 226 |
+ |
|
| 221 | 227 |
// SockRequestRaw create a request against the specified host (with method, endpoint and other request modifier) and |
| 222 | 228 |
// returns the http response, the output as a io.ReadCloser |
| 223 | 229 |
// Deprecated: use request.Do (or Get, Delete, Post) instead |
| ... | ... |
@@ -4,7 +4,6 @@ import ( |
| 4 | 4 |
"errors" |
| 5 | 5 |
"fmt" |
| 6 | 6 |
"io" |
| 7 |
- "io/ioutil" |
|
| 8 | 7 |
"os" |
| 9 | 8 |
"os/exec" |
| 10 | 9 |
"path/filepath" |
| ... | ... |
@@ -117,9 +116,3 @@ func ParseCgroupPaths(procCgroupData string) map[string]string {
|
| 117 | 117 |
} |
| 118 | 118 |
return cgroupPaths |
| 119 | 119 |
} |
| 120 |
- |
|
| 121 |
-// ReadBody read the specified ReadCloser content and returns it |
|
| 122 |
-func ReadBody(b io.ReadCloser) ([]byte, error) {
|
|
| 123 |
- defer b.Close() |
|
| 124 |
- return ioutil.ReadAll(b) |
|
| 125 |
-} |