Browse code

COPY should be the last op in the Dockerfile

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

Brian Goff authored on 2017/11/10 05:45:11
Showing 3 changed files
... ...
@@ -189,8 +189,9 @@ RUN ln -s /usr/local/completion/bash/docker /etc/bash_completion.d/docker
189 189
 # Wrap all commands in the "docker-in-docker" script to allow nested containers
190 190
 ENTRYPOINT ["hack/dind"]
191 191
 
192
+# Options for hack/validate/gometalinter
193
+ENV GOMETALINTER_OPTS="--deadline 2m"
194
+
192 195
 # Upload docker source
193 196
 COPY . /go/src/github.com/docker/docker
194 197
 
195
-# Options for hack/validate/gometalinter
196
-ENV GOMETALINTER_OPTS="--deadline 2m"
... ...
@@ -158,8 +158,8 @@ ENV PATH=/usr/local/cli:$PATH
158 158
 # Wrap all commands in the "docker-in-docker" script to allow nested containers
159 159
 ENTRYPOINT ["hack/dind"]
160 160
 
161
-# Upload docker source
162
-COPY . /go/src/github.com/docker/docker
163
-
164 161
 # Options for hack/validate/gometalinter
165 162
 ENV GOMETALINTER_OPTS="--deadline 4m -j2"
163
+
164
+# Upload docker source
165
+COPY . /go/src/github.com/docker/docker
... ...
@@ -146,8 +146,8 @@ ENV PATH=/usr/local/cli:$PATH
146 146
 
147 147
 ENTRYPOINT ["hack/dind"]
148 148
 
149
-# Upload docker source
150
-COPY . /go/src/github.com/docker/docker
151
-
152 149
 # Options for hack/validate/gometalinter
153 150
 ENV GOMETALINTER_OPTS="--deadline 10m -j2"
151
+
152
+# Upload docker source
153
+COPY . /go/src/github.com/docker/docker