Signed-off-by: Alexandr Morozov <lk4d4@docker.com>
Alexandr Morozov authored on 2014/09/24 18:15:55... | ... |
@@ -633,17 +633,23 @@ func TestBuildForceRm(t *testing.T) { |
633 | 633 |
} |
634 | 634 |
|
635 | 635 |
func TestBuildRm(t *testing.T) { |
636 |
+ name := "testbuildrm" |
|
637 |
+ defer deleteImages(name) |
|
638 |
+ ctx, err := fakeContext("FROM scratch\nADD foo /\nADD foo /", map[string]string{"foo": "bar"}) |
|
639 |
+ if err != nil { |
|
640 |
+ t.Fatal(err) |
|
641 |
+ } |
|
642 |
+ defer ctx.Close() |
|
636 | 643 |
{ |
637 | 644 |
containerCountBefore, err := getContainerCount() |
638 | 645 |
if err != nil { |
639 | 646 |
t.Fatalf("failed to get the container count: %s", err) |
640 | 647 |
} |
641 | 648 |
|
642 |
- buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm") |
|
643 |
- _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "--rm", "-t", "testbuildrm", ".") |
|
649 |
+ out, exitCode, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm", "-t", name, ".") |
|
644 | 650 |
|
645 | 651 |
if err != nil || exitCode != 0 { |
646 |
- t.Fatal("failed to build the image") |
|
652 |
+ t.Fatal("failed to build the image", out) |
|
647 | 653 |
} |
648 | 654 |
|
649 | 655 |
containerCountAfter, err := getContainerCount() |
... | ... |
@@ -654,7 +660,7 @@ func TestBuildRm(t *testing.T) { |
654 | 654 |
if containerCountBefore != containerCountAfter { |
655 | 655 |
t.Fatalf("-rm shouldn't have left containers behind") |
656 | 656 |
} |
657 |
- deleteImages("testbuildrm") |
|
657 |
+ deleteImages(name) |
|
658 | 658 |
} |
659 | 659 |
|
660 | 660 |
{ |
... | ... |
@@ -663,11 +669,10 @@ func TestBuildRm(t *testing.T) { |
663 | 663 |
t.Fatalf("failed to get the container count: %s", err) |
664 | 664 |
} |
665 | 665 |
|
666 |
- buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm") |
|
667 |
- _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testbuildrm", ".") |
|
666 |
+ out, exitCode, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name, ".") |
|
668 | 667 |
|
669 | 668 |
if err != nil || exitCode != 0 { |
670 |
- t.Fatal("failed to build the image") |
|
669 |
+ t.Fatal("failed to build the image", out) |
|
671 | 670 |
} |
672 | 671 |
|
673 | 672 |
containerCountAfter, err := getContainerCount() |
... | ... |
@@ -678,7 +683,7 @@ func TestBuildRm(t *testing.T) { |
678 | 678 |
if containerCountBefore != containerCountAfter { |
679 | 679 |
t.Fatalf("--rm shouldn't have left containers behind") |
680 | 680 |
} |
681 |
- deleteImages("testbuildrm") |
|
681 |
+ deleteImages(name) |
|
682 | 682 |
} |
683 | 683 |
|
684 | 684 |
{ |
... | ... |
@@ -687,11 +692,10 @@ func TestBuildRm(t *testing.T) { |
687 | 687 |
t.Fatalf("failed to get the container count: %s", err) |
688 | 688 |
} |
689 | 689 |
|
690 |
- buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm") |
|
691 |
- _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "--rm=false", "-t", "testbuildrm", ".") |
|
690 |
+ out, exitCode, err := dockerCmdInDir(t, ctx.Dir, "build", "--rm=false", "-t", name, ".") |
|
692 | 691 |
|
693 | 692 |
if err != nil || exitCode != 0 { |
694 |
- t.Fatal("failed to build the image") |
|
693 |
+ t.Fatal("failed to build the image", out) |
|
695 | 694 |
} |
696 | 695 |
|
697 | 696 |
containerCountAfter, err := getContainerCount() |
... | ... |
@@ -703,7 +707,7 @@ func TestBuildRm(t *testing.T) { |
703 | 703 |
t.Fatalf("--rm=false should have left containers behind") |
704 | 704 |
} |
705 | 705 |
deleteAllContainers() |
706 |
- deleteImages("testbuildrm") |
|
706 |
+ deleteImages(name) |
|
707 | 707 |
|
708 | 708 |
} |
709 | 709 |
|