Browse code

Merge pull request #38486 from thaJeztah/dont_use_deprecated_envclient

Remove use of deprecated client.NewEnvClient()

Sebastiaan van Stijn authored on 2019/01/05 19:23:19
Showing 26 changed files
... ...
@@ -16,7 +16,7 @@ import (
16 16
 )
17 17
 
18 18
 func main() {
19
-	cli, err := client.NewEnvClient()
19
+	cli, err := client.NewClientWithOpts(client.FromEnv)
20 20
 	if err != nil {
21 21
 		panic(err)
22 22
 	}
... ...
@@ -23,7 +23,7 @@ For example, to list running containers (the equivalent of "docker ps"):
23 23
 	)
24 24
 
25 25
 	func main() {
26
-		cli, err := client.NewEnvClient()
26
+		cli, err := client.NewClientWithOpts(client.FromEnv)
27 27
 		if err != nil {
28 28
 			panic(err)
29 29
 		}
... ...
@@ -16,7 +16,7 @@ import (
16 16
 	"gotest.tools/skip"
17 17
 )
18 18
 
19
-func TestNewEnvClient(t *testing.T) {
19
+func TestNewClientWithOpsFromEnv(t *testing.T) {
20 20
 	skip.If(t, runtime.GOOS == "windows")
21 21
 
22 22
 	testcases := []struct {
... ...
@@ -86,7 +86,7 @@ func TestNewEnvClient(t *testing.T) {
86 86
 	defer env.PatchAll(t, nil)()
87 87
 	for _, c := range testcases {
88 88
 		env.PatchAll(t, c.envs)
89
-		apiclient, err := NewEnvClient()
89
+		apiclient, err := NewClientWithOpts(FromEnv)
90 90
 		if c.expectedError != "" {
91 91
 			assert.Check(t, is.Error(err, c.expectedError), c.doc)
92 92
 		} else {
... ...
@@ -167,7 +167,7 @@ func TestParseHostURL(t *testing.T) {
167 167
 	}
168 168
 }
169 169
 
170
-func TestNewEnvClientSetsDefaultVersion(t *testing.T) {
170
+func TestNewClientWithOpsFromEnvSetsDefaultVersion(t *testing.T) {
171 171
 	defer env.PatchAll(t, map[string]string{
172 172
 		"DOCKER_HOST":        "",
173 173
 		"DOCKER_API_VERSION": "",
... ...
@@ -175,7 +175,7 @@ func TestNewEnvClientSetsDefaultVersion(t *testing.T) {
175 175
 		"DOCKER_CERT_PATH":   "",
176 176
 	})()
177 177
 
178
-	client, err := NewEnvClient()
178
+	client, err := NewClientWithOpts(FromEnv)
179 179
 	if err != nil {
180 180
 		t.Fatal(err)
181 181
 	}
... ...
@@ -183,7 +183,7 @@ func TestNewEnvClientSetsDefaultVersion(t *testing.T) {
183 183
 
184 184
 	expected := "1.22"
185 185
 	os.Setenv("DOCKER_API_VERSION", expected)
186
-	client, err = NewEnvClient()
186
+	client, err = NewClientWithOpts(FromEnv)
187 187
 	if err != nil {
188 188
 		t.Fatal(err)
189 189
 	}
... ...
@@ -195,7 +195,7 @@ func TestNewEnvClientSetsDefaultVersion(t *testing.T) {
195 195
 func TestNegotiateAPIVersionEmpty(t *testing.T) {
196 196
 	defer env.PatchAll(t, map[string]string{"DOCKER_API_VERSION": ""})()
197 197
 
198
-	client, err := NewEnvClient()
198
+	client, err := NewClientWithOpts(FromEnv)
199 199
 	assert.NilError(t, err)
200 200
 
201 201
 	ping := types.Ping{
... ...
@@ -219,7 +219,7 @@ func TestNegotiateAPIVersionEmpty(t *testing.T) {
219 219
 // TestNegotiateAPIVersion asserts that client.Client can
220 220
 // negotiate a compatible APIVersion with the server
221 221
 func TestNegotiateAPIVersion(t *testing.T) {
222
-	client, err := NewEnvClient()
222
+	client, err := NewClientWithOpts(FromEnv)
223 223
 	assert.NilError(t, err)
224 224
 
225 225
 	expected := "1.21"
... ...
@@ -251,7 +251,7 @@ func TestNegotiateAPVersionOverride(t *testing.T) {
251 251
 	expected := "9.99"
252 252
 	defer env.PatchAll(t, map[string]string{"DOCKER_API_VERSION": expected})()
253 253
 
254
-	client, err := NewEnvClient()
254
+	client, err := NewClientWithOpts(FromEnv)
255 255
 	assert.NilError(t, err)
256 256
 
257 257
 	ping := types.Ping{
... ...
@@ -153,7 +153,7 @@ func ExampleClient_ContainerLogs_withTimeout() {
153 153
 	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
154 154
 	defer cancel()
155 155
 
156
-	client, _ := NewEnvClient()
156
+	client, _ := NewClientWithOpts(FromEnv)
157 157
 	reader, err := client.ContainerLogs(ctx, "container_id", types.ContainerLogsOptions{})
158 158
 	if err != nil {
159 159
 		log.Fatal(err)
... ...
@@ -65,7 +65,7 @@ func ExampleClient_ContainerWait_withTimeout() {
65 65
 	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
66 66
 	defer cancel()
67 67
 
68
-	client, _ := NewEnvClient()
68
+	client, _ := NewClientWithOpts(FromEnv)
69 69
 	_, errC := client.ContainerWait(ctx, "container_id", "")
70 70
 	if err := <-errC; err != nil {
71 71
 		log.Fatal(err)
... ...
@@ -122,7 +122,7 @@ func ExampleClient_ServiceLogs_withTimeout() {
122 122
 	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
123 123
 	defer cancel()
124 124
 
125
-	client, _ := NewEnvClient()
125
+	client, _ := NewClientWithOpts(FromEnv)
126 126
 	reader, err := client.ServiceLogs(ctx, "service_id", types.ContainerLogsOptions{})
127 127
 	if err != nil {
128 128
 		log.Fatal(err)
... ...
@@ -29,7 +29,7 @@ func dryTestChunkExecutor() testChunkExecutor {
29 29
 // service via bind-mounted API socket so as to execute the test chunk
30 30
 func privilegedTestChunkExecutor(autoRemove bool) testChunkExecutor {
31 31
 	return func(image string, tests []string) (int64, string, error) {
32
-		cli, err := client.NewEnvClient()
32
+		cli, err := client.NewClientWithOpts(client.FromEnv)
33 33
 		if err != nil {
34 34
 			return 0, "", err
35 35
 		}
... ...
@@ -50,7 +50,7 @@ func xmain() (int, error) {
50 50
 	if *randSeed == int64(0) {
51 51
 		*randSeed = time.Now().UnixNano()
52 52
 	}
53
-	cli, err := client.NewEnvClient()
53
+	cli, err := client.NewClientWithOpts(client.FromEnv)
54 54
 	if err != nil {
55 55
 		return 1, err
56 56
 	}
... ...
@@ -177,7 +177,7 @@ func (s *DockerSuite) TestPostContainersAttach(c *check.C) {
177 177
 	expectTimeout(conn, br, "stdout")
178 178
 
179 179
 	// Test the client API
180
-	client, err := client.NewEnvClient()
180
+	client, err := client.NewClientWithOpts(client.FromEnv)
181 181
 	c.Assert(err, checker.IsNil)
182 182
 	defer client.Close()
183 183
 
... ...
@@ -43,7 +43,7 @@ func (s *DockerSuite) TestContainerAPIGetAll(c *check.C) {
43 43
 	name := "getall"
44 44
 	dockerCmd(c, "run", "--name", name, "busybox", "true")
45 45
 
46
-	cli, err := client.NewEnvClient()
46
+	cli, err := client.NewClientWithOpts(client.FromEnv)
47 47
 	c.Assert(err, checker.IsNil)
48 48
 	defer cli.Close()
49 49
 
... ...
@@ -62,7 +62,7 @@ func (s *DockerSuite) TestContainerAPIGetJSONNoFieldsOmitted(c *check.C) {
62 62
 	startCount := getContainerCount(c)
63 63
 	dockerCmd(c, "run", "busybox", "true")
64 64
 
65
-	cli, err := client.NewEnvClient()
65
+	cli, err := client.NewClientWithOpts(client.FromEnv)
66 66
 	c.Assert(err, checker.IsNil)
67 67
 	defer cli.Close()
68 68
 
... ...
@@ -111,7 +111,7 @@ func (s *DockerSuite) TestContainerAPIPsOmitFields(c *check.C) {
111 111
 	port := 80
112 112
 	runSleepingContainer(c, "--name", name, "--expose", strconv.Itoa(port))
113 113
 
114
-	cli, err := client.NewEnvClient()
114
+	cli, err := client.NewClientWithOpts(client.FromEnv)
115 115
 	c.Assert(err, checker.IsNil)
116 116
 	defer cli.Close()
117 117
 
... ...
@@ -143,7 +143,7 @@ func (s *DockerSuite) TestContainerAPIGetExport(c *check.C) {
143 143
 	name := "exportcontainer"
144 144
 	dockerCmd(c, "run", "--name", name, "busybox", "touch", "/test")
145 145
 
146
-	cli, err := client.NewEnvClient()
146
+	cli, err := client.NewClientWithOpts(client.FromEnv)
147 147
 	c.Assert(err, checker.IsNil)
148 148
 	defer cli.Close()
149 149
 
... ...
@@ -170,7 +170,7 @@ func (s *DockerSuite) TestContainerAPIGetChanges(c *check.C) {
170 170
 	name := "changescontainer"
171 171
 	dockerCmd(c, "run", "--name", name, "busybox", "rm", "/etc/passwd")
172 172
 
173
-	cli, err := client.NewEnvClient()
173
+	cli, err := client.NewClientWithOpts(client.FromEnv)
174 174
 	c.Assert(err, checker.IsNil)
175 175
 	defer cli.Close()
176 176
 
... ...
@@ -200,7 +200,7 @@ func (s *DockerSuite) TestGetContainerStats(c *check.C) {
200 200
 
201 201
 	bc := make(chan b, 1)
202 202
 	go func() {
203
-		cli, err := client.NewEnvClient()
203
+		cli, err := client.NewClientWithOpts(client.FromEnv)
204 204
 		c.Assert(err, checker.IsNil)
205 205
 		defer cli.Close()
206 206
 
... ...
@@ -234,7 +234,7 @@ func (s *DockerSuite) TestGetContainerStatsRmRunning(c *check.C) {
234 234
 	buf := &ChannelBuffer{C: make(chan []byte, 1)}
235 235
 	defer buf.Close()
236 236
 
237
-	cli, err := client.NewEnvClient()
237
+	cli, err := client.NewClientWithOpts(client.FromEnv)
238 238
 	c.Assert(err, checker.IsNil)
239 239
 	defer cli.Close()
240 240
 
... ...
@@ -305,7 +305,7 @@ func (s *DockerSuite) TestGetContainerStatsStream(c *check.C) {
305 305
 
306 306
 	bc := make(chan b, 1)
307 307
 	go func() {
308
-		cli, err := client.NewEnvClient()
308
+		cli, err := client.NewClientWithOpts(client.FromEnv)
309 309
 		c.Assert(err, checker.IsNil)
310 310
 		defer cli.Close()
311 311
 
... ...
@@ -347,7 +347,7 @@ func (s *DockerSuite) TestGetContainerStatsNoStream(c *check.C) {
347 347
 	bc := make(chan b, 1)
348 348
 
349 349
 	go func() {
350
-		cli, err := client.NewEnvClient()
350
+		cli, err := client.NewClientWithOpts(client.FromEnv)
351 351
 		c.Assert(err, checker.IsNil)
352 352
 		defer cli.Close()
353 353
 
... ...
@@ -384,7 +384,7 @@ func (s *DockerSuite) TestGetStoppedContainerStats(c *check.C) {
384 384
 	// We expect an immediate response, but if it's not immediate, the test would hang, so put it in a goroutine
385 385
 	// below we'll check this on a timeout.
386 386
 	go func() {
387
-		cli, err := client.NewEnvClient()
387
+		cli, err := client.NewClientWithOpts(client.FromEnv)
388 388
 		c.Assert(err, checker.IsNil)
389 389
 		defer cli.Close()
390 390
 
... ...
@@ -412,7 +412,7 @@ func (s *DockerSuite) TestContainerAPIPause(c *check.C) {
412 412
 	out := cli.DockerCmd(c, "run", "-d", "busybox", "sleep", "30").Combined()
413 413
 	ContainerID := strings.TrimSpace(out)
414 414
 
415
-	cli, err := client.NewEnvClient()
415
+	cli, err := client.NewClientWithOpts(client.FromEnv)
416 416
 	c.Assert(err, checker.IsNil)
417 417
 	defer cli.Close()
418 418
 
... ...
@@ -438,7 +438,7 @@ func (s *DockerSuite) TestContainerAPITop(c *check.C) {
438 438
 	id := strings.TrimSpace(string(out))
439 439
 	c.Assert(waitRun(id), checker.IsNil)
440 440
 
441
-	cli, err := client.NewEnvClient()
441
+	cli, err := client.NewClientWithOpts(client.FromEnv)
442 442
 	c.Assert(err, checker.IsNil)
443 443
 	defer cli.Close()
444 444
 
... ...
@@ -461,7 +461,7 @@ func (s *DockerSuite) TestContainerAPITopWindows(c *check.C) {
461 461
 	id := strings.TrimSpace(string(out))
462 462
 	c.Assert(waitRun(id), checker.IsNil)
463 463
 
464
-	cli, err := client.NewEnvClient()
464
+	cli, err := client.NewClientWithOpts(client.FromEnv)
465 465
 	c.Assert(err, checker.IsNil)
466 466
 	defer cli.Close()
467 467
 
... ...
@@ -490,7 +490,7 @@ func (s *DockerSuite) TestContainerAPICommit(c *check.C) {
490 490
 	cName := "testapicommit"
491 491
 	dockerCmd(c, "run", "--name="+cName, "busybox", "/bin/sh", "-c", "touch /test")
492 492
 
493
-	cli, err := client.NewEnvClient()
493
+	cli, err := client.NewClientWithOpts(client.FromEnv)
494 494
 	c.Assert(err, checker.IsNil)
495 495
 	defer cli.Close()
496 496
 
... ...
@@ -512,7 +512,7 @@ func (s *DockerSuite) TestContainerAPICommitWithLabelInConfig(c *check.C) {
512 512
 	cName := "testapicommitwithconfig"
513 513
 	dockerCmd(c, "run", "--name="+cName, "busybox", "/bin/sh", "-c", "touch /test")
514 514
 
515
-	cli, err := client.NewEnvClient()
515
+	cli, err := client.NewClientWithOpts(client.FromEnv)
516 516
 	c.Assert(err, checker.IsNil)
517 517
 	defer cli.Close()
518 518
 
... ...
@@ -559,7 +559,7 @@ func (s *DockerSuite) TestContainerAPIBadPort(c *check.C) {
559 559
 		},
560 560
 	}
561 561
 
562
-	cli, err := client.NewEnvClient()
562
+	cli, err := client.NewClientWithOpts(client.FromEnv)
563 563
 	c.Assert(err, checker.IsNil)
564 564
 	defer cli.Close()
565 565
 
... ...
@@ -573,7 +573,7 @@ func (s *DockerSuite) TestContainerAPICreate(c *check.C) {
573 573
 		Cmd:   []string{"/bin/sh", "-c", "touch /test && ls /test"},
574 574
 	}
575 575
 
576
-	cli, err := client.NewEnvClient()
576
+	cli, err := client.NewClientWithOpts(client.FromEnv)
577 577
 	c.Assert(err, checker.IsNil)
578 578
 	defer cli.Close()
579 579
 
... ...
@@ -586,7 +586,7 @@ func (s *DockerSuite) TestContainerAPICreate(c *check.C) {
586 586
 
587 587
 func (s *DockerSuite) TestContainerAPICreateEmptyConfig(c *check.C) {
588 588
 
589
-	cli, err := client.NewEnvClient()
589
+	cli, err := client.NewClientWithOpts(client.FromEnv)
590 590
 	c.Assert(err, checker.IsNil)
591 591
 	defer cli.Close()
592 592
 
... ...
@@ -610,7 +610,7 @@ func (s *DockerSuite) TestContainerAPICreateMultipleNetworksConfig(c *check.C) {
610 610
 		},
611 611
 	}
612 612
 
613
-	cli, err := client.NewEnvClient()
613
+	cli, err := client.NewClientWithOpts(client.FromEnv)
614 614
 	c.Assert(err, checker.IsNil)
615 615
 	defer cli.Close()
616 616
 
... ...
@@ -632,7 +632,7 @@ func (s *DockerSuite) TestContainerAPICreateWithHostName(c *check.C) {
632 632
 		Domainname: domainName,
633 633
 	}
634 634
 
635
-	cli, err := client.NewEnvClient()
635
+	cli, err := client.NewClientWithOpts(client.FromEnv)
636 636
 	c.Assert(err, checker.IsNil)
637 637
 	defer cli.Close()
638 638
 
... ...
@@ -668,7 +668,7 @@ func UtilCreateNetworkMode(c *check.C, networkMode containertypes.NetworkMode) {
668 668
 		NetworkMode: networkMode,
669 669
 	}
670 670
 
671
-	cli, err := client.NewEnvClient()
671
+	cli, err := client.NewClientWithOpts(client.FromEnv)
672 672
 	c.Assert(err, checker.IsNil)
673 673
 	defer cli.Close()
674 674
 
... ...
@@ -695,7 +695,7 @@ func (s *DockerSuite) TestContainerAPICreateWithCpuSharesCpuset(c *check.C) {
695 695
 		},
696 696
 	}
697 697
 
698
-	cli, err := client.NewEnvClient()
698
+	cli, err := client.NewClientWithOpts(client.FromEnv)
699 699
 	c.Assert(err, checker.IsNil)
700 700
 	defer cli.Close()
701 701
 
... ...
@@ -943,7 +943,7 @@ func (s *DockerSuite) TestContainerAPIRename(c *check.C) {
943 943
 	containerID := strings.TrimSpace(out)
944 944
 	newName := "TestContainerAPIRenameNew"
945 945
 
946
-	cli, err := client.NewEnvClient()
946
+	cli, err := client.NewClientWithOpts(client.FromEnv)
947 947
 	c.Assert(err, checker.IsNil)
948 948
 	defer cli.Close()
949 949
 
... ...
@@ -958,7 +958,7 @@ func (s *DockerSuite) TestContainerAPIKill(c *check.C) {
958 958
 	name := "test-api-kill"
959 959
 	runSleepingContainer(c, "-i", "--name", name)
960 960
 
961
-	cli, err := client.NewEnvClient()
961
+	cli, err := client.NewClientWithOpts(client.FromEnv)
962 962
 	c.Assert(err, checker.IsNil)
963 963
 	defer cli.Close()
964 964
 
... ...
@@ -972,7 +972,7 @@ func (s *DockerSuite) TestContainerAPIKill(c *check.C) {
972 972
 func (s *DockerSuite) TestContainerAPIRestart(c *check.C) {
973 973
 	name := "test-api-restart"
974 974
 	runSleepingContainer(c, "-di", "--name", name)
975
-	cli, err := client.NewEnvClient()
975
+	cli, err := client.NewClientWithOpts(client.FromEnv)
976 976
 	c.Assert(err, checker.IsNil)
977 977
 	defer cli.Close()
978 978
 
... ...
@@ -989,7 +989,7 @@ func (s *DockerSuite) TestContainerAPIRestartNotimeoutParam(c *check.C) {
989 989
 	id := strings.TrimSpace(out)
990 990
 	c.Assert(waitRun(id), checker.IsNil)
991 991
 
992
-	cli, err := client.NewEnvClient()
992
+	cli, err := client.NewClientWithOpts(client.FromEnv)
993 993
 	c.Assert(err, checker.IsNil)
994 994
 	defer cli.Close()
995 995
 
... ...
@@ -1007,7 +1007,7 @@ func (s *DockerSuite) TestContainerAPIStart(c *check.C) {
1007 1007
 		OpenStdin: true,
1008 1008
 	}
1009 1009
 
1010
-	cli, err := client.NewEnvClient()
1010
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1011 1011
 	c.Assert(err, checker.IsNil)
1012 1012
 	defer cli.Close()
1013 1013
 
... ...
@@ -1030,7 +1030,7 @@ func (s *DockerSuite) TestContainerAPIStop(c *check.C) {
1030 1030
 	runSleepingContainer(c, "-i", "--name", name)
1031 1031
 	timeout := 30 * time.Second
1032 1032
 
1033
-	cli, err := client.NewEnvClient()
1033
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1034 1034
 	c.Assert(err, checker.IsNil)
1035 1035
 	defer cli.Close()
1036 1036
 
... ...
@@ -1053,7 +1053,7 @@ func (s *DockerSuite) TestContainerAPIWait(c *check.C) {
1053 1053
 	}
1054 1054
 	dockerCmd(c, "run", "--name", name, "busybox", sleepCmd, "2")
1055 1055
 
1056
-	cli, err := client.NewEnvClient()
1056
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1057 1057
 	c.Assert(err, checker.IsNil)
1058 1058
 	defer cli.Close()
1059 1059
 
... ...
@@ -1171,7 +1171,7 @@ func (s *DockerSuite) TestContainerAPIDelete(c *check.C) {
1171 1171
 
1172 1172
 	dockerCmd(c, "stop", id)
1173 1173
 
1174
-	cli, err := client.NewEnvClient()
1174
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1175 1175
 	c.Assert(err, checker.IsNil)
1176 1176
 	defer cli.Close()
1177 1177
 
... ...
@@ -1180,7 +1180,7 @@ func (s *DockerSuite) TestContainerAPIDelete(c *check.C) {
1180 1180
 }
1181 1181
 
1182 1182
 func (s *DockerSuite) TestContainerAPIDeleteNotExist(c *check.C) {
1183
-	cli, err := client.NewEnvClient()
1183
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1184 1184
 	c.Assert(err, checker.IsNil)
1185 1185
 	defer cli.Close()
1186 1186
 
... ...
@@ -1197,7 +1197,7 @@ func (s *DockerSuite) TestContainerAPIDeleteForce(c *check.C) {
1197 1197
 		Force: true,
1198 1198
 	}
1199 1199
 
1200
-	cli, err := client.NewEnvClient()
1200
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1201 1201
 	c.Assert(err, checker.IsNil)
1202 1202
 	defer cli.Close()
1203 1203
 
... ...
@@ -1225,7 +1225,7 @@ func (s *DockerSuite) TestContainerAPIDeleteRemoveLinks(c *check.C) {
1225 1225
 		RemoveLinks: true,
1226 1226
 	}
1227 1227
 
1228
-	cli, err := client.NewEnvClient()
1228
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1229 1229
 	c.Assert(err, checker.IsNil)
1230 1230
 	defer cli.Close()
1231 1231
 
... ...
@@ -1242,7 +1242,7 @@ func (s *DockerSuite) TestContainerAPIDeleteConflict(c *check.C) {
1242 1242
 	id := strings.TrimSpace(out)
1243 1243
 	c.Assert(waitRun(id), checker.IsNil)
1244 1244
 
1245
-	cli, err := client.NewEnvClient()
1245
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1246 1246
 	c.Assert(err, checker.IsNil)
1247 1247
 	defer cli.Close()
1248 1248
 
... ...
@@ -1274,7 +1274,7 @@ func (s *DockerSuite) TestContainerAPIDeleteRemoveVolume(c *check.C) {
1274 1274
 		RemoveVolumes: true,
1275 1275
 	}
1276 1276
 
1277
-	cli, err := client.NewEnvClient()
1277
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1278 1278
 	c.Assert(err, checker.IsNil)
1279 1279
 	defer cli.Close()
1280 1280
 
... ...
@@ -1312,7 +1312,7 @@ func (s *DockerSuite) TestContainerAPIPostContainerStop(c *check.C) {
1312 1312
 	containerID := strings.TrimSpace(out)
1313 1313
 	c.Assert(waitRun(containerID), checker.IsNil)
1314 1314
 
1315
-	cli, err := client.NewEnvClient()
1315
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1316 1316
 	c.Assert(err, checker.IsNil)
1317 1317
 	defer cli.Close()
1318 1318
 
... ...
@@ -1329,7 +1329,7 @@ func (s *DockerSuite) TestPostContainerAPICreateWithStringOrSliceEntrypoint(c *c
1329 1329
 		Cmd:        []string{"hello", "world"},
1330 1330
 	}
1331 1331
 
1332
-	cli, err := client.NewEnvClient()
1332
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1333 1333
 	c.Assert(err, checker.IsNil)
1334 1334
 	defer cli.Close()
1335 1335
 
... ...
@@ -1356,7 +1356,7 @@ func (s *DockerSuite) TestPostContainersCreateWithStringOrSliceCmd(c *check.C) {
1356 1356
 		Cmd:   []string{"echo", "hello", "world"},
1357 1357
 	}
1358 1358
 
1359
-	cli, err := client.NewEnvClient()
1359
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1360 1360
 	c.Assert(err, checker.IsNil)
1361 1361
 	defer cli.Close()
1362 1362
 
... ...
@@ -1397,7 +1397,7 @@ func (s *DockerSuite) TestPostContainersCreateWithStringOrSliceCapAddDrop(c *che
1397 1397
 		CapDrop: []string{"SETGID"},
1398 1398
 	}
1399 1399
 
1400
-	cli, err := client.NewEnvClient()
1400
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1401 1401
 	c.Assert(err, checker.IsNil)
1402 1402
 	defer cli.Close()
1403 1403
 
... ...
@@ -1453,7 +1453,7 @@ func (s *DockerSuite) TestPostContainersCreateWithWrongCpusetValues(c *check.C)
1453 1453
 	// Not supported on Windows
1454 1454
 	testRequires(c, DaemonIsLinux)
1455 1455
 
1456
-	cli, err := client.NewEnvClient()
1456
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1457 1457
 	c.Assert(err, checker.IsNil)
1458 1458
 	defer cli.Close()
1459 1459
 
... ...
@@ -1492,7 +1492,7 @@ func (s *DockerSuite) TestPostContainersCreateShmSizeNegative(c *check.C) {
1492 1492
 		ShmSize: -1,
1493 1493
 	}
1494 1494
 
1495
-	cli, err := client.NewEnvClient()
1495
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1496 1496
 	c.Assert(err, checker.IsNil)
1497 1497
 	defer cli.Close()
1498 1498
 
... ...
@@ -1509,7 +1509,7 @@ func (s *DockerSuite) TestPostContainersCreateShmSizeHostConfigOmitted(c *check.
1509 1509
 		Cmd:   []string{"mount"},
1510 1510
 	}
1511 1511
 
1512
-	cli, err := client.NewEnvClient()
1512
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1513 1513
 	c.Assert(err, checker.IsNil)
1514 1514
 	defer cli.Close()
1515 1515
 
... ...
@@ -1536,7 +1536,7 @@ func (s *DockerSuite) TestPostContainersCreateShmSizeOmitted(c *check.C) {
1536 1536
 		Cmd:   []string{"mount"},
1537 1537
 	}
1538 1538
 
1539
-	cli, err := client.NewEnvClient()
1539
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1540 1540
 	c.Assert(err, checker.IsNil)
1541 1541
 	defer cli.Close()
1542 1542
 
... ...
@@ -1567,7 +1567,7 @@ func (s *DockerSuite) TestPostContainersCreateWithShmSize(c *check.C) {
1567 1567
 		ShmSize: 1073741824,
1568 1568
 	}
1569 1569
 
1570
-	cli, err := client.NewEnvClient()
1570
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1571 1571
 	c.Assert(err, checker.IsNil)
1572 1572
 	defer cli.Close()
1573 1573
 
... ...
@@ -1593,7 +1593,7 @@ func (s *DockerSuite) TestPostContainersCreateMemorySwappinessHostConfigOmitted(
1593 1593
 		Image: "busybox",
1594 1594
 	}
1595 1595
 
1596
-	cli, err := client.NewEnvClient()
1596
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1597 1597
 	c.Assert(err, checker.IsNil)
1598 1598
 	defer cli.Close()
1599 1599
 
... ...
@@ -1623,7 +1623,7 @@ func (s *DockerSuite) TestPostContainersCreateWithOomScoreAdjInvalidRange(c *che
1623 1623
 		OomScoreAdj: 1001,
1624 1624
 	}
1625 1625
 
1626
-	cli, err := client.NewEnvClient()
1626
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1627 1627
 	c.Assert(err, checker.IsNil)
1628 1628
 	defer cli.Close()
1629 1629
 
... ...
@@ -1646,7 +1646,7 @@ func (s *DockerSuite) TestPostContainersCreateWithOomScoreAdjInvalidRange(c *che
1646 1646
 
1647 1647
 // test case for #22210 where an empty container name caused panic.
1648 1648
 func (s *DockerSuite) TestContainerAPIDeleteWithEmptyName(c *check.C) {
1649
-	cli, err := client.NewEnvClient()
1649
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1650 1650
 	c.Assert(err, checker.IsNil)
1651 1651
 	defer cli.Close()
1652 1652
 
... ...
@@ -1666,7 +1666,7 @@ func (s *DockerSuite) TestContainerAPIStatsWithNetworkDisabled(c *check.C) {
1666 1666
 		NetworkDisabled: true,
1667 1667
 	}
1668 1668
 
1669
-	cli, err := client.NewEnvClient()
1669
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1670 1670
 	c.Assert(err, checker.IsNil)
1671 1671
 	defer cli.Close()
1672 1672
 
... ...
@@ -1978,7 +1978,7 @@ func (s *DockerSuite) TestContainersAPICreateMountsValidation(c *check.C) {
1978 1978
 		}...)
1979 1979
 
1980 1980
 	}
1981
-	cli, err := client.NewEnvClient()
1981
+	cli, err := client.NewClientWithOpts(client.FromEnv)
1982 1982
 	c.Assert(err, checker.IsNil)
1983 1983
 	defer cli.Close()
1984 1984
 
... ...
@@ -2013,7 +2013,7 @@ func (s *DockerSuite) TestContainerAPICreateMountsBindRead(c *check.C) {
2013 2013
 			{Type: "bind", Source: tmpDir, Target: destPath},
2014 2014
 		},
2015 2015
 	}
2016
-	cli, err := client.NewEnvClient()
2016
+	cli, err := client.NewClientWithOpts(client.FromEnv)
2017 2017
 	c.Assert(err, checker.IsNil)
2018 2018
 	defer cli.Close()
2019 2019
 
... ...
@@ -2264,7 +2264,7 @@ func (s *DockerSuite) TestContainersAPICreateMountsTmpfs(c *check.C) {
2264 2264
 		},
2265 2265
 	}
2266 2266
 
2267
-	cli, err := client.NewEnvClient()
2267
+	cli, err := client.NewClientWithOpts(client.FromEnv)
2268 2268
 	c.Assert(err, checker.IsNil)
2269 2269
 	defer cli.Close()
2270 2270
 
... ...
@@ -71,7 +71,7 @@ func (s *DockerSuite) TestExecAPICreateContainerPaused(c *check.C) {
71 71
 
72 72
 	dockerCmd(c, "pause", name)
73 73
 
74
-	cli, err := client.NewEnvClient()
74
+	cli, err := client.NewClientWithOpts(client.FromEnv)
75 75
 	c.Assert(err, checker.IsNil)
76 76
 	defer cli.Close()
77 77
 
... ...
@@ -155,7 +155,7 @@ func (s *DockerSuite) TestExecAPIStartWithDetach(c *check.C) {
155 155
 		AttachStderr: true,
156 156
 	}
157 157
 
158
-	cli, err := client.NewEnvClient()
158
+	cli, err := client.NewClientWithOpts(client.FromEnv)
159 159
 	c.Assert(err, checker.IsNil)
160 160
 	defer cli.Close()
161 161
 
... ...
@@ -20,7 +20,7 @@ import (
20 20
 )
21 21
 
22 22
 func (s *DockerSuite) TestAPIImagesFilter(c *check.C) {
23
-	cli, err := client.NewEnvClient()
23
+	cli, err := client.NewClientWithOpts(client.FromEnv)
24 24
 	c.Assert(err, checker.IsNil)
25 25
 	defer cli.Close()
26 26
 
... ...
@@ -88,7 +88,7 @@ func (s *DockerSuite) TestAPIImagesSaveAndLoad(c *check.C) {
88 88
 }
89 89
 
90 90
 func (s *DockerSuite) TestAPIImagesDelete(c *check.C) {
91
-	cli, err := client.NewEnvClient()
91
+	cli, err := client.NewClientWithOpts(client.FromEnv)
92 92
 	c.Assert(err, checker.IsNil)
93 93
 	defer cli.Close()
94 94
 
... ...
@@ -112,7 +112,7 @@ func (s *DockerSuite) TestAPIImagesDelete(c *check.C) {
112 112
 }
113 113
 
114 114
 func (s *DockerSuite) TestAPIImagesHistory(c *check.C) {
115
-	cli, err := client.NewEnvClient()
115
+	cli, err := client.NewClientWithOpts(client.FromEnv)
116 116
 	c.Assert(err, checker.IsNil)
117 117
 	defer cli.Close()
118 118
 
... ...
@@ -107,7 +107,7 @@ func (s *DockerSuite) TestInspectAPIContainerVolumeDriver(c *check.C) {
107 107
 
108 108
 func (s *DockerSuite) TestInspectAPIImageResponse(c *check.C) {
109 109
 	dockerCmd(c, "tag", "busybox:latest", "busybox:mytag")
110
-	cli, err := client.NewEnvClient()
110
+	cli, err := client.NewClientWithOpts(client.FromEnv)
111 111
 	c.Assert(err, checker.IsNil)
112 112
 	defer cli.Close()
113 113
 
... ...
@@ -59,7 +59,7 @@ func (s *DockerSuite) TestLogsAPIWithStdout(c *check.C) {
59 59
 func (s *DockerSuite) TestLogsAPINoStdoutNorStderr(c *check.C) {
60 60
 	name := "logs_test"
61 61
 	dockerCmd(c, "run", "-d", "-t", "--name", name, "busybox", "/bin/sh")
62
-	cli, err := client.NewEnvClient()
62
+	cli, err := client.NewClientWithOpts(client.FromEnv)
63 63
 	c.Assert(err, checker.IsNil)
64 64
 	defer cli.Close()
65 65
 
... ...
@@ -102,7 +102,7 @@ func (s *DockerSuite) TestLogsAPIUntilFutureFollow(c *check.C) {
102 102
 	c.Assert(err, checker.IsNil)
103 103
 	until := daemonTime(c).Add(untilDur)
104 104
 
105
-	client, err := client.NewEnvClient()
105
+	client, err := client.NewClientWithOpts(client.FromEnv)
106 106
 	if err != nil {
107 107
 		c.Fatal(err)
108 108
 	}
... ...
@@ -153,7 +153,7 @@ func (s *DockerSuite) TestLogsAPIUntil(c *check.C) {
153 153
 	name := "logsuntil"
154 154
 	dockerCmd(c, "run", "--name", name, "busybox", "/bin/sh", "-c", "for i in $(seq 1 3); do echo log$i; sleep 1; done")
155 155
 
156
-	client, err := client.NewEnvClient()
156
+	client, err := client.NewClientWithOpts(client.FromEnv)
157 157
 	if err != nil {
158 158
 		c.Fatal(err)
159 159
 	}
... ...
@@ -190,7 +190,7 @@ func (s *DockerSuite) TestLogsAPIUntilDefaultValue(c *check.C) {
190 190
 	name := "logsuntildefaultval"
191 191
 	dockerCmd(c, "run", "--name", name, "busybox", "/bin/sh", "-c", "for i in $(seq 1 3); do echo log$i; done")
192 192
 
193
-	client, err := client.NewEnvClient()
193
+	client, err := client.NewClientWithOpts(client.FromEnv)
194 194
 	if err != nil {
195 195
 		c.Fatal(err)
196 196
 	}
... ...
@@ -262,7 +262,7 @@ func jsonBlobHasGTE121NetworkStats(blob map[string]interface{}) bool {
262 262
 
263 263
 func (s *DockerSuite) TestAPIStatsContainerNotFound(c *check.C) {
264 264
 	testRequires(c, DaemonIsLinux)
265
-	cli, err := client.NewEnvClient()
265
+	cli, err := client.NewClientWithOpts(client.FromEnv)
266 266
 	c.Assert(err, checker.IsNil)
267 267
 	defer cli.Close()
268 268
 
... ...
@@ -458,7 +458,7 @@ func (s *DockerSuite) TestEventsResize(c *check.C) {
458 458
 	cID := strings.TrimSpace(out)
459 459
 	c.Assert(waitRun(cID), checker.IsNil)
460 460
 
461
-	cli, err := client.NewEnvClient()
461
+	cli, err := client.NewClientWithOpts(client.FromEnv)
462 462
 	c.Assert(err, checker.IsNil)
463 463
 	defer cli.Close()
464 464
 
... ...
@@ -359,7 +359,7 @@ func (s *DockerSuite) TestExecInspectID(c *check.C) {
359 359
 	}
360 360
 
361 361
 	// But we should still be able to query the execID
362
-	cli, err := client.NewEnvClient()
362
+	cli, err := client.NewClientWithOpts(client.FromEnv)
363 363
 	c.Assert(err, checker.IsNil)
364 364
 	defer cli.Close()
365 365
 
... ...
@@ -35,7 +35,7 @@ func (s *DockerSuite) TestPluginLogDriverInfoList(c *check.C) {
35 35
 
36 36
 	dockerCmd(c, "plugin", "install", pluginName)
37 37
 
38
-	cli, err := client.NewEnvClient()
38
+	cli, err := client.NewClientWithOpts(client.FromEnv)
39 39
 	c.Assert(err, checker.IsNil)
40 40
 	defer cli.Close()
41 41
 
... ...
@@ -3893,7 +3893,7 @@ func (s *DockerSuite) TestRunNamedVolumesFromNotRemoved(c *check.C) {
3893 3893
 	cid, _ := dockerCmd(c, "run", "-d", "--name=parent", "-v", "test:"+prefix+"/foo", "-v", prefix+"/bar", "busybox", "true")
3894 3894
 	dockerCmd(c, "run", "--name=child", "--volumes-from=parent", "busybox", "true")
3895 3895
 
3896
-	cli, err := client.NewEnvClient()
3896
+	cli, err := client.NewClientWithOpts(client.FromEnv)
3897 3897
 	c.Assert(err, checker.IsNil)
3898 3898
 	defer cli.Close()
3899 3899
 
... ...
@@ -1568,7 +1568,7 @@ func (s *DockerSuite) TestRunWithNanoCPUs(c *check.C) {
1568 1568
 	out, _ := dockerCmd(c, "run", "--cpus", "0.5", "--name", "test", "busybox", "sh", "-c", fmt.Sprintf("cat %s && cat %s", file1, file2))
1569 1569
 	c.Assert(strings.TrimSpace(out), checker.Equals, "50000\n100000")
1570 1570
 
1571
-	clt, err := client.NewEnvClient()
1571
+	clt, err := client.NewClientWithOpts(client.FromEnv)
1572 1572
 	c.Assert(err, checker.IsNil)
1573 1573
 	inspect, err := clt.ContainerInspect(context.Background(), "test")
1574 1574
 	c.Assert(err, checker.IsNil)
... ...
@@ -309,7 +309,7 @@ func (s *DockerSuite) TestUpdateWithNanoCPUs(c *check.C) {
309 309
 	out, _ = dockerCmd(c, "exec", "top", "sh", "-c", fmt.Sprintf("cat %s && cat %s", file1, file2))
310 310
 	c.Assert(strings.TrimSpace(out), checker.Equals, "50000\n100000")
311 311
 
312
-	clt, err := client.NewEnvClient()
312
+	clt, err := client.NewClientWithOpts(client.FromEnv)
313 313
 	c.Assert(err, checker.IsNil)
314 314
 	inspect, err := clt.ContainerInspect(context.Background(), "top")
315 315
 	c.Assert(err, checker.IsNil)
... ...
@@ -600,7 +600,7 @@ func (s *DockerSuite) TestDuplicateMountpointsForVolumesFromAndMounts(c *check.C
600 600
 	err := os.MkdirAll("/tmp/data", 0755)
601 601
 	c.Assert(err, checker.IsNil)
602 602
 	// Mounts is available in API
603
-	cli, err := client.NewEnvClient()
603
+	cli, err := client.NewClientWithOpts(client.FromEnv)
604 604
 	c.Assert(err, checker.IsNil)
605 605
 	defer cli.Close()
606 606
 
... ...
@@ -261,7 +261,7 @@ func daemonTime(c *check.C) time.Time {
261 261
 	if testEnv.IsLocalDaemon() {
262 262
 		return time.Now()
263 263
 	}
264
-	cli, err := client.NewEnvClient()
264
+	cli, err := client.NewClientWithOpts(client.FromEnv)
265 265
 	c.Assert(err, check.IsNil)
266 266
 	defer cli.Close()
267 267
 
... ...
@@ -373,7 +373,7 @@ func minimalBaseImage() string {
373 373
 }
374 374
 
375 375
 func getGoroutineNumber() (int, error) {
376
-	cli, err := client.NewEnvClient()
376
+	cli, err := client.NewClientWithOpts(client.FromEnv)
377 377
 	if err != nil {
378 378
 		return 0, err
379 379
 	}
... ...
@@ -49,7 +49,7 @@ func MinimumAPIVersion(version string) func() bool {
49 49
 }
50 50
 
51 51
 func OnlyDefaultNetworks() bool {
52
-	cli, err := client.NewEnvClient()
52
+	cli, err := client.NewClientWithOpts(client.FromEnv)
53 53
 	if err != nil {
54 54
 		return false
55 55
 	}
... ...
@@ -59,7 +59,7 @@ func TestContainerNetworkMountsNoChown(t *testing.T) {
59 59
 		},
60 60
 	}
61 61
 
62
-	cli, err := client.NewEnvClient()
62
+	cli, err := client.NewClientWithOpts(client.FromEnv)
63 63
 	assert.NilError(t, err)
64 64
 	defer cli.Close()
65 65
 
... ...
@@ -559,7 +559,7 @@ func (d *Daemon) LoadBusybox(t assert.TestingT) {
559 559
 	if ht, ok := t.(test.HelperT); ok {
560 560
 		ht.Helper()
561 561
 	}
562
-	clientHost, err := client.NewEnvClient()
562
+	clientHost, err := client.NewClientWithOpts(client.FromEnv)
563 563
 	assert.NilError(t, err, "failed to create client")
564 564
 	defer clientHost.Close()
565 565