Browse code

'docker daemon' deprecation message doesn't use the new versioning scheme

Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>

yuexiao-wang authored on 2017/03/01 02:28:33
Showing 6 changed files
... ...
@@ -271,7 +271,7 @@ func prettyPrintInfo(dockerCli *command.DockerCli, info types.Info) error {
271 271
 			fmt.Fprintf(dockerCli.Out(), " %s\n", attribute)
272 272
 		}
273 273
 		// TODO: Engine labels with duplicate keys has been deprecated in 1.13 and will be error out
274
-		// after 3 release cycles (1.16). For now, a WARNING will be generated. The following will
274
+		// after 3 release cycles (17.12). For now, a WARNING will be generated. The following will
275 275
 		// be removed eventually.
276 276
 		labelMap := map[string]string{}
277 277
 		for _, label := range info.Labels {
... ...
@@ -437,7 +437,7 @@ func loadDaemonCliConfig(opts daemonOptions) (*config.Config, error) {
437 437
 	// This is deprecated in 1.13, and, be removed after 3 release cycles.
438 438
 	// The following will check the conflict of labels, and report a warning for deprecation.
439 439
 	//
440
-	// TODO: After 3 release cycles (1.16) an error will be returned, and labels will be
440
+	// TODO: After 3 release cycles (17.12) an error will be returned, and labels will be
441 441
 	// sanitized to consolidate duplicate key-value pairs (config.Labels = newLabels):
442 442
 	//
443 443
 	// newLabels, err := daemon.GetConflictFreeLabels(config.Labels)
... ...
@@ -242,7 +242,7 @@ func Reload(configFile string, flags *pflag.FlagSet, reload func(*Config)) error
242 242
 	// This is deprecated in 1.13, and, be removed after 3 release cycles.
243 243
 	// The following will check the conflict of labels, and report a warning for deprecation.
244 244
 	//
245
-	// TODO: After 3 release cycles (1.16) an error will be returned, and labels will be
245
+	// TODO: After 3 release cycles (17.12) an error will be returned, and labels will be
246 246
 	// sanitized to consolidate duplicate key-value pairs (config.Labels = newLabels):
247 247
 	//
248 248
 	// newLabels, err := GetConflictFreeLabels(newConfig.Labels)
... ...
@@ -146,7 +146,7 @@ func Init(home string, options []string, uidMaps, gidMaps []idtools.IDMap) (grap
146 146
 		return nil, err
147 147
 	}
148 148
 	if !supportsDType {
149
-		// not a fatal error until v1.16 (#27443)
149
+		// not a fatal error until v17.12 (#27443)
150 150
 		logrus.Warn(overlayutils.ErrDTypeNotSupported("overlay", backingFs))
151 151
 	}
152 152
 
... ...
@@ -172,7 +172,7 @@ func Init(home string, options []string, uidMaps, gidMaps []idtools.IDMap) (grap
172 172
 		return nil, err
173 173
 	}
174 174
 	if !supportsDType {
175
-		// not a fatal error until v1.16 (#27443)
175
+		// not a fatal error until v17.12 (#27443)
176 176
 		logrus.Warn(overlayutils.ErrDTypeNotSupported("overlay2", backingFs))
177 177
 	}
178 178
 
... ...
@@ -13,6 +13,6 @@ func ErrDTypeNotSupported(driver, backingFs string) error {
13 13
 	if backingFs == "xfs" {
14 14
 		msg += " Reformat the filesystem with ftype=1 to enable d_type support."
15 15
 	}
16
-	msg += " Running without d_type support will no longer be supported in Docker 1.16."
16
+	msg += " Running without d_type support will no longer be supported in Docker 17.12."
17 17
 	return errors.New(msg)
18 18
 }