GitList

Browse code

validate: address SC2155 (shellcheck)

see https://github.com/koalaman/shellcheck/wiki/SC2155

Looking at how these were used, I don't think we even need to
export them, so removing that.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2022/08/26 23:08:14
Showing 9 changed files

hack/validate/all index 3224fe5..281684a 100755
hack/validate/dco index 0e61ccc..6354d2b 100755
hack/validate/default index b48d9fa..bb53177 100755
hack/validate/default-seccomp index c5f8c7e..aea27d1 100755
hack/validate/deprecate-integration-cli index f53b48e..f7b273c 100755
hack/validate/pkg-imports index bba762d..c8ba223 100755
hack/validate/swagger index 1ed8d3b..5313221 100755
hack/validate/swagger-gen index 0d000ea..4063170 100755
hack/validate/toml index 7f1739a..fe86cac 100755

hack/validate/all

History View file @ 5cfc9c3

@@ -2,7 +2,7 @@
+                     #
                      # Run all validation
                     -export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                     +SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                      . ${SCRIPTDIR}/default
                      . ${SCRIPTDIR}/vendor

hack/validate/dco

History View file @ 5cfc9c3

@@ -1,6 +1,6 @@
                      #!/usr/bin/env bash
                     -export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                     +SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                      source "${SCRIPTDIR}/.validate"
                      adds=$(validate_diff --numstat | awk '{ s += $1 } END { print s }')

hack/validate/default

History View file @ 5cfc9c3

@@ -2,7 +2,7 @@
+                     #
                      # Run default validation, exclude vendor because it's slow
                     -export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                     +SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                      # Skip DCO check here, as it's already checked in a separate stage in the Jenkinsfile
                      #. "${SCRIPTDIR}"/dco

hack/validate/default-seccomp

History View file @ 5cfc9c3

@@ -1,6 +1,6 @@
                      #!/usr/bin/env bash
                     -export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                     +SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                      source "${SCRIPTDIR}/.validate"
                      IFS=$'\n'

hack/validate/deprecate-integration-cli

History View file @ 5cfc9c3

@@ -1,7 +1,7 @@
                      #!/usr/bin/env bash
                      # Check that no new tests are being added to integration-cli
                     -export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                     +SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                      source "${SCRIPTDIR}/.validate"
                      new_tests=$(

hack/validate/pkg-imports

History View file @ 5cfc9c3

@@ -1,7 +1,7 @@
                      #!/usr/bin/env bash
                      set -e
                     -export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                     +SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                      source "${SCRIPTDIR}/.validate"
                      IFS=$'\n'

hack/validate/swagger

History View file @ 5cfc9c3

@@ -1,6 +1,6 @@
                      #!/usr/bin/env bash
                      set -e
                     -export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                     +SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                      source "${SCRIPTDIR}/.validate"
                      IFS=$'\n'

hack/validate/swagger-gen

History View file @ 5cfc9c3

@@ -1,6 +1,6 @@
                      #!/usr/bin/env bash
                     -export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                     +SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                      source "${SCRIPTDIR}/.validate"
                      IFS=$'\n'

hack/validate/toml

History View file @ 5cfc9c3

@@ -1,6 +1,6 @@
                      #!/usr/bin/env bash
                     -export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                     +SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
                      source "${SCRIPTDIR}/.validate"
                      IFS=$'\n'