Browse code

Deprecate repo:shortid syntax

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

Tonis Tiigi authored on 2016/10/07 09:12:17
Showing 2 changed files
... ...
@@ -5,6 +5,7 @@ import (
5 5
 
6 6
 	"github.com/docker/docker/builder"
7 7
 	"github.com/docker/docker/image"
8
+	"github.com/docker/docker/pkg/stringid"
8 9
 	"github.com/docker/docker/reference"
9 10
 )
10 11
 
... ...
@@ -34,11 +35,15 @@ func (daemon *Daemon) GetImageID(refOrID string) (image.ID, error) {
34 34
 	if id, err := daemon.referenceStore.Get(ref); err == nil {
35 35
 		return image.IDFromDigest(id), nil
36 36
 	}
37
+
38
+	// deprecated: repo:shortid https://github.com/docker/docker/pull/799
37 39
 	if tagged, ok := ref.(reference.NamedTagged); ok {
38
-		if id, err := daemon.imageStore.Search(tagged.Tag()); err == nil {
39
-			for _, namedRef := range daemon.referenceStore.References(id.Digest()) {
40
-				if namedRef.Name() == ref.Name() {
41
-					return id, nil
40
+		if tag := tagged.Tag(); stringid.IsShortID(stringid.TruncateID(tag)) {
41
+			if id, err := daemon.imageStore.Search(tag); err == nil {
42
+				for _, namedRef := range daemon.referenceStore.References(id.Digest()) {
43
+					if namedRef.Name() == ref.Name() {
44
+						return id, nil
45
+					}
42 46
 				}
43 47
 			}
44 48
 		}
... ...
@@ -17,6 +17,13 @@ To learn more about Docker Engine's deprecation policy,
17 17
 see [Feature Deprecation Policy](index.md#feature-deprecation-policy).
18 18
 
19 19
 
20
+### `repository:shortid` image references
21
+**Deprecated In Release: [v1.13](https://github.com/docker/docker/releases/)**
22
+
23
+**Target For Removal In Release: v1.16**
24
+
25
+`repository:shortid` syntax for referencing images is very little used, collides with with tag references can be confused with digest references.
26
+
20 27
 ### `docker daemon` subcommand
21 28
 **Deprecated In Release: [v1.13](https://github.com/docker/docker/releases/)**
22 29