Browse code

builder: Add TODOBuildkit test requirement, specifically for TestBuildCancellationKillsSleep

Signed-off-by: Tibor Vass <tibor@docker.com>

Tibor Vass authored on 2018/05/16 09:11:25
Showing 2 changed files
... ...
@@ -126,8 +126,12 @@ func (s *DockerSuite) TestBuildAddChangeOwnership(c *check.C) {
126 126
 // * Run a 1-year-long sleep from a docker build.
127 127
 // * When docker events sees container start, close the "docker build" command
128 128
 // * Wait for docker events to emit a dying event.
129
+//
130
+// TODO(buildkit): this test needs to be rewritten for buildkit.
131
+// It has been manually tested positive. Confirmed issue: docker build output parsing.
132
+// Potential issue: newEventObserver uses docker events, which is not hooked up to buildkit.
129 133
 func (s *DockerSuite) TestBuildCancellationKillsSleep(c *check.C) {
130
-	testRequires(c, DaemonIsLinux)
134
+	testRequires(c, DaemonIsLinux, TODOBuildkit)
131 135
 	name := "testbuildcancellation"
132 136
 
133 137
 	observer, err := newEventObserver(c)
... ...
@@ -208,6 +208,10 @@ func SwarmInactive() bool {
208 208
 	return testEnv.DaemonInfo.Swarm.LocalNodeState == swarm.LocalNodeStateInactive
209 209
 }
210 210
 
211
+func TODOBuildkit() bool {
212
+	return os.Getenv("DOCKER_BUILDKIT") == ""
213
+}
214
+
211 215
 // testRequires checks if the environment satisfies the requirements
212 216
 // for the test to run or skips the tests.
213 217
 func testRequires(c requirement.SkipT, requirements ...requirement.Test) {