Signed-off-by: Vincent Demeester <vincent@sbr.pm>
| 1 | 1 |
deleted file mode 100644 |
| ... | ... |
@@ -1,400 +0,0 @@ |
| 1 |
-package client |
|
| 2 |
- |
|
| 3 |
-import ( |
|
| 4 |
- "archive/tar" |
|
| 5 |
- "bufio" |
|
| 6 |
- "bytes" |
|
| 7 |
- "fmt" |
|
| 8 |
- "io" |
|
| 9 |
- "os" |
|
| 10 |
- "path/filepath" |
|
| 11 |
- "regexp" |
|
| 12 |
- "runtime" |
|
| 13 |
- |
|
| 14 |
- "golang.org/x/net/context" |
|
| 15 |
- |
|
| 16 |
- "github.com/docker/docker/api" |
|
| 17 |
- "github.com/docker/docker/builder" |
|
| 18 |
- "github.com/docker/docker/builder/dockerignore" |
|
| 19 |
- Cli "github.com/docker/docker/cli" |
|
| 20 |
- "github.com/docker/docker/opts" |
|
| 21 |
- "github.com/docker/docker/pkg/archive" |
|
| 22 |
- "github.com/docker/docker/pkg/fileutils" |
|
| 23 |
- "github.com/docker/docker/pkg/jsonmessage" |
|
| 24 |
- flag "github.com/docker/docker/pkg/mflag" |
|
| 25 |
- "github.com/docker/docker/pkg/progress" |
|
| 26 |
- "github.com/docker/docker/pkg/streamformatter" |
|
| 27 |
- "github.com/docker/docker/pkg/urlutil" |
|
| 28 |
- "github.com/docker/docker/reference" |
|
| 29 |
- runconfigopts "github.com/docker/docker/runconfig/opts" |
|
| 30 |
- "github.com/docker/engine-api/types" |
|
| 31 |
- "github.com/docker/engine-api/types/container" |
|
| 32 |
- "github.com/docker/go-units" |
|
| 33 |
-) |
|
| 34 |
- |
|
| 35 |
-type translatorFunc func(context.Context, reference.NamedTagged) (reference.Canonical, error) |
|
| 36 |
- |
|
| 37 |
-// CmdBuild builds a new image from the source code at a given path. |
|
| 38 |
-// |
|
| 39 |
-// If '-' is provided instead of a path or URL, Docker will build an image from either a Dockerfile or tar archive read from STDIN. |
|
| 40 |
-// |
|
| 41 |
-// Usage: docker build [OPTIONS] PATH | URL | - |
|
| 42 |
-func (cli *DockerCli) CmdBuild(args ...string) error {
|
|
| 43 |
- cmd := Cli.Subcmd("build", []string{"PATH | URL | -"}, Cli.DockerCommands["build"].Description, true)
|
|
| 44 |
- flTags := opts.NewListOpts(validateTag) |
|
| 45 |
- cmd.Var(&flTags, []string{"t", "-tag"}, "Name and optionally a tag in the 'name:tag' format")
|
|
| 46 |
- suppressOutput := cmd.Bool([]string{"q", "-quiet"}, false, "Suppress the build output and print image ID on success")
|
|
| 47 |
- noCache := cmd.Bool([]string{"-no-cache"}, false, "Do not use cache when building the image")
|
|
| 48 |
- rm := cmd.Bool([]string{"-rm"}, true, "Remove intermediate containers after a successful build")
|
|
| 49 |
- forceRm := cmd.Bool([]string{"-force-rm"}, false, "Always remove intermediate containers")
|
|
| 50 |
- pull := cmd.Bool([]string{"-pull"}, false, "Always attempt to pull a newer version of the image")
|
|
| 51 |
- dockerfileName := cmd.String([]string{"f", "-file"}, "", "Name of the Dockerfile (Default is 'PATH/Dockerfile')")
|
|
| 52 |
- flMemoryString := cmd.String([]string{"m", "-memory"}, "", "Memory limit")
|
|
| 53 |
- flMemorySwap := cmd.String([]string{"-memory-swap"}, "", "Swap limit equal to memory plus swap: '-1' to enable unlimited swap")
|
|
| 54 |
- flShmSize := cmd.String([]string{"-shm-size"}, "", "Size of /dev/shm, default value is 64MB")
|
|
| 55 |
- flCPUShares := cmd.Int64([]string{"c", "-cpu-shares"}, 0, "CPU shares (relative weight)")
|
|
| 56 |
- flCPUPeriod := cmd.Int64([]string{"-cpu-period"}, 0, "Limit the CPU CFS (Completely Fair Scheduler) period")
|
|
| 57 |
- flCPUQuota := cmd.Int64([]string{"-cpu-quota"}, 0, "Limit the CPU CFS (Completely Fair Scheduler) quota")
|
|
| 58 |
- flCPUSetCpus := cmd.String([]string{"-cpuset-cpus"}, "", "CPUs in which to allow execution (0-3, 0,1)")
|
|
| 59 |
- flCPUSetMems := cmd.String([]string{"-cpuset-mems"}, "", "MEMs in which to allow execution (0-3, 0,1)")
|
|
| 60 |
- flCgroupParent := cmd.String([]string{"-cgroup-parent"}, "", "Optional parent cgroup for the container")
|
|
| 61 |
- flBuildArg := opts.NewListOpts(runconfigopts.ValidateEnv) |
|
| 62 |
- cmd.Var(&flBuildArg, []string{"-build-arg"}, "Set build-time variables")
|
|
| 63 |
- isolation := cmd.String([]string{"-isolation"}, "", "Container isolation technology")
|
|
| 64 |
- |
|
| 65 |
- flLabels := opts.NewListOpts(nil) |
|
| 66 |
- cmd.Var(&flLabels, []string{"-label"}, "Set metadata for an image")
|
|
| 67 |
- |
|
| 68 |
- ulimits := make(map[string]*units.Ulimit) |
|
| 69 |
- flUlimits := runconfigopts.NewUlimitOpt(&ulimits) |
|
| 70 |
- cmd.Var(flUlimits, []string{"-ulimit"}, "Ulimit options")
|
|
| 71 |
- |
|
| 72 |
- cmd.Require(flag.Exact, 1) |
|
| 73 |
- |
|
| 74 |
- // For trusted pull on "FROM <image>" instruction. |
|
| 75 |
- addTrustedFlags(cmd, true) |
|
| 76 |
- |
|
| 77 |
- cmd.ParseFlags(args, true) |
|
| 78 |
- |
|
| 79 |
- var ( |
|
| 80 |
- buildCtx io.ReadCloser |
|
| 81 |
- err error |
|
| 82 |
- ) |
|
| 83 |
- |
|
| 84 |
- specifiedContext := cmd.Arg(0) |
|
| 85 |
- |
|
| 86 |
- var ( |
|
| 87 |
- contextDir string |
|
| 88 |
- tempDir string |
|
| 89 |
- relDockerfile string |
|
| 90 |
- progBuff io.Writer |
|
| 91 |
- buildBuff io.Writer |
|
| 92 |
- ) |
|
| 93 |
- |
|
| 94 |
- progBuff = cli.out |
|
| 95 |
- buildBuff = cli.out |
|
| 96 |
- if *suppressOutput {
|
|
| 97 |
- progBuff = bytes.NewBuffer(nil) |
|
| 98 |
- buildBuff = bytes.NewBuffer(nil) |
|
| 99 |
- } |
|
| 100 |
- |
|
| 101 |
- switch {
|
|
| 102 |
- case specifiedContext == "-": |
|
| 103 |
- buildCtx, relDockerfile, err = builder.GetContextFromReader(cli.in, *dockerfileName) |
|
| 104 |
- case urlutil.IsGitURL(specifiedContext): |
|
| 105 |
- tempDir, relDockerfile, err = builder.GetContextFromGitURL(specifiedContext, *dockerfileName) |
|
| 106 |
- case urlutil.IsURL(specifiedContext): |
|
| 107 |
- buildCtx, relDockerfile, err = builder.GetContextFromURL(progBuff, specifiedContext, *dockerfileName) |
|
| 108 |
- default: |
|
| 109 |
- contextDir, relDockerfile, err = builder.GetContextFromLocalDir(specifiedContext, *dockerfileName) |
|
| 110 |
- } |
|
| 111 |
- |
|
| 112 |
- if err != nil {
|
|
| 113 |
- if *suppressOutput && urlutil.IsURL(specifiedContext) {
|
|
| 114 |
- fmt.Fprintln(cli.err, progBuff) |
|
| 115 |
- } |
|
| 116 |
- return fmt.Errorf("unable to prepare context: %s", err)
|
|
| 117 |
- } |
|
| 118 |
- |
|
| 119 |
- if tempDir != "" {
|
|
| 120 |
- defer os.RemoveAll(tempDir) |
|
| 121 |
- contextDir = tempDir |
|
| 122 |
- } |
|
| 123 |
- |
|
| 124 |
- if buildCtx == nil {
|
|
| 125 |
- // And canonicalize dockerfile name to a platform-independent one |
|
| 126 |
- relDockerfile, err = archive.CanonicalTarNameForPath(relDockerfile) |
|
| 127 |
- if err != nil {
|
|
| 128 |
- return fmt.Errorf("cannot canonicalize dockerfile path %s: %v", relDockerfile, err)
|
|
| 129 |
- } |
|
| 130 |
- |
|
| 131 |
- f, err := os.Open(filepath.Join(contextDir, ".dockerignore")) |
|
| 132 |
- if err != nil && !os.IsNotExist(err) {
|
|
| 133 |
- return err |
|
| 134 |
- } |
|
| 135 |
- |
|
| 136 |
- var excludes []string |
|
| 137 |
- if err == nil {
|
|
| 138 |
- excludes, err = dockerignore.ReadAll(f) |
|
| 139 |
- if err != nil {
|
|
| 140 |
- return err |
|
| 141 |
- } |
|
| 142 |
- } |
|
| 143 |
- |
|
| 144 |
- if err := builder.ValidateContextDirectory(contextDir, excludes); err != nil {
|
|
| 145 |
- return fmt.Errorf("Error checking context: '%s'.", err)
|
|
| 146 |
- } |
|
| 147 |
- |
|
| 148 |
- // If .dockerignore mentions .dockerignore or the Dockerfile |
|
| 149 |
- // then make sure we send both files over to the daemon |
|
| 150 |
- // because Dockerfile is, obviously, needed no matter what, and |
|
| 151 |
- // .dockerignore is needed to know if either one needs to be |
|
| 152 |
- // removed. The daemon will remove them for us, if needed, after it |
|
| 153 |
- // parses the Dockerfile. Ignore errors here, as they will have been |
|
| 154 |
- // caught by validateContextDirectory above. |
|
| 155 |
- var includes = []string{"."}
|
|
| 156 |
- keepThem1, _ := fileutils.Matches(".dockerignore", excludes)
|
|
| 157 |
- keepThem2, _ := fileutils.Matches(relDockerfile, excludes) |
|
| 158 |
- if keepThem1 || keepThem2 {
|
|
| 159 |
- includes = append(includes, ".dockerignore", relDockerfile) |
|
| 160 |
- } |
|
| 161 |
- |
|
| 162 |
- buildCtx, err = archive.TarWithOptions(contextDir, &archive.TarOptions{
|
|
| 163 |
- Compression: archive.Uncompressed, |
|
| 164 |
- ExcludePatterns: excludes, |
|
| 165 |
- IncludeFiles: includes, |
|
| 166 |
- }) |
|
| 167 |
- if err != nil {
|
|
| 168 |
- return err |
|
| 169 |
- } |
|
| 170 |
- } |
|
| 171 |
- |
|
| 172 |
- ctx := context.Background() |
|
| 173 |
- |
|
| 174 |
- var resolvedTags []*resolvedTag |
|
| 175 |
- if IsTrusted() {
|
|
| 176 |
- // Wrap the tar archive to replace the Dockerfile entry with the rewritten |
|
| 177 |
- // Dockerfile which uses trusted pulls. |
|
| 178 |
- buildCtx = replaceDockerfileTarWrapper(ctx, buildCtx, relDockerfile, cli.TrustedReference, &resolvedTags) |
|
| 179 |
- } |
|
| 180 |
- |
|
| 181 |
- // Setup an upload progress bar |
|
| 182 |
- progressOutput := streamformatter.NewStreamFormatter().NewProgressOutput(progBuff, true) |
|
| 183 |
- |
|
| 184 |
- var body io.Reader = progress.NewProgressReader(buildCtx, progressOutput, 0, "", "Sending build context to Docker daemon") |
|
| 185 |
- |
|
| 186 |
- var memory int64 |
|
| 187 |
- if *flMemoryString != "" {
|
|
| 188 |
- parsedMemory, err := units.RAMInBytes(*flMemoryString) |
|
| 189 |
- if err != nil {
|
|
| 190 |
- return err |
|
| 191 |
- } |
|
| 192 |
- memory = parsedMemory |
|
| 193 |
- } |
|
| 194 |
- |
|
| 195 |
- var memorySwap int64 |
|
| 196 |
- if *flMemorySwap != "" {
|
|
| 197 |
- if *flMemorySwap == "-1" {
|
|
| 198 |
- memorySwap = -1 |
|
| 199 |
- } else {
|
|
| 200 |
- parsedMemorySwap, err := units.RAMInBytes(*flMemorySwap) |
|
| 201 |
- if err != nil {
|
|
| 202 |
- return err |
|
| 203 |
- } |
|
| 204 |
- memorySwap = parsedMemorySwap |
|
| 205 |
- } |
|
| 206 |
- } |
|
| 207 |
- |
|
| 208 |
- var shmSize int64 |
|
| 209 |
- if *flShmSize != "" {
|
|
| 210 |
- shmSize, err = units.RAMInBytes(*flShmSize) |
|
| 211 |
- if err != nil {
|
|
| 212 |
- return err |
|
| 213 |
- } |
|
| 214 |
- } |
|
| 215 |
- |
|
| 216 |
- options := types.ImageBuildOptions{
|
|
| 217 |
- Memory: memory, |
|
| 218 |
- MemorySwap: memorySwap, |
|
| 219 |
- Tags: flTags.GetAll(), |
|
| 220 |
- SuppressOutput: *suppressOutput, |
|
| 221 |
- NoCache: *noCache, |
|
| 222 |
- Remove: *rm, |
|
| 223 |
- ForceRemove: *forceRm, |
|
| 224 |
- PullParent: *pull, |
|
| 225 |
- Isolation: container.Isolation(*isolation), |
|
| 226 |
- CPUSetCPUs: *flCPUSetCpus, |
|
| 227 |
- CPUSetMems: *flCPUSetMems, |
|
| 228 |
- CPUShares: *flCPUShares, |
|
| 229 |
- CPUQuota: *flCPUQuota, |
|
| 230 |
- CPUPeriod: *flCPUPeriod, |
|
| 231 |
- CgroupParent: *flCgroupParent, |
|
| 232 |
- Dockerfile: relDockerfile, |
|
| 233 |
- ShmSize: shmSize, |
|
| 234 |
- Ulimits: flUlimits.GetList(), |
|
| 235 |
- BuildArgs: runconfigopts.ConvertKVStringsToMap(flBuildArg.GetAll()), |
|
| 236 |
- AuthConfigs: cli.retrieveAuthConfigs(), |
|
| 237 |
- Labels: runconfigopts.ConvertKVStringsToMap(flLabels.GetAll()), |
|
| 238 |
- } |
|
| 239 |
- |
|
| 240 |
- response, err := cli.client.ImageBuild(ctx, body, options) |
|
| 241 |
- if err != nil {
|
|
| 242 |
- return err |
|
| 243 |
- } |
|
| 244 |
- defer response.Body.Close() |
|
| 245 |
- |
|
| 246 |
- err = jsonmessage.DisplayJSONMessagesStream(response.Body, buildBuff, cli.outFd, cli.isTerminalOut, nil) |
|
| 247 |
- if err != nil {
|
|
| 248 |
- if jerr, ok := err.(*jsonmessage.JSONError); ok {
|
|
| 249 |
- // If no error code is set, default to 1 |
|
| 250 |
- if jerr.Code == 0 {
|
|
| 251 |
- jerr.Code = 1 |
|
| 252 |
- } |
|
| 253 |
- if *suppressOutput {
|
|
| 254 |
- fmt.Fprintf(cli.err, "%s%s", progBuff, buildBuff) |
|
| 255 |
- } |
|
| 256 |
- return Cli.StatusError{Status: jerr.Message, StatusCode: jerr.Code}
|
|
| 257 |
- } |
|
| 258 |
- } |
|
| 259 |
- |
|
| 260 |
- // Windows: show error message about modified file permissions if the |
|
| 261 |
- // daemon isn't running Windows. |
|
| 262 |
- if response.OSType != "windows" && runtime.GOOS == "windows" {
|
|
| 263 |
- fmt.Fprintln(cli.err, `SECURITY WARNING: You are building a Docker image from Windows against a non-Windows Docker host. All files and directories added to build context will have '-rwxr-xr-x' permissions. It is recommended to double check and reset permissions for sensitive files and directories.`) |
|
| 264 |
- } |
|
| 265 |
- |
|
| 266 |
- // Everything worked so if -q was provided the output from the daemon |
|
| 267 |
- // should be just the image ID and we'll print that to stdout. |
|
| 268 |
- if *suppressOutput {
|
|
| 269 |
- fmt.Fprintf(cli.out, "%s", buildBuff) |
|
| 270 |
- } |
|
| 271 |
- |
|
| 272 |
- if IsTrusted() {
|
|
| 273 |
- // Since the build was successful, now we must tag any of the resolved |
|
| 274 |
- // images from the above Dockerfile rewrite. |
|
| 275 |
- for _, resolved := range resolvedTags {
|
|
| 276 |
- if err := cli.TagTrusted(ctx, resolved.digestRef, resolved.tagRef); err != nil {
|
|
| 277 |
- return err |
|
| 278 |
- } |
|
| 279 |
- } |
|
| 280 |
- } |
|
| 281 |
- |
|
| 282 |
- return nil |
|
| 283 |
-} |
|
| 284 |
- |
|
| 285 |
-// validateTag checks if the given image name can be resolved. |
|
| 286 |
-func validateTag(rawRepo string) (string, error) {
|
|
| 287 |
- _, err := reference.ParseNamed(rawRepo) |
|
| 288 |
- if err != nil {
|
|
| 289 |
- return "", err |
|
| 290 |
- } |
|
| 291 |
- |
|
| 292 |
- return rawRepo, nil |
|
| 293 |
-} |
|
| 294 |
- |
|
| 295 |
-var dockerfileFromLinePattern = regexp.MustCompile(`(?i)^[\s]*FROM[ \f\r\t\v]+(?P<image>[^ \f\r\t\v\n#]+)`) |
|
| 296 |
- |
|
| 297 |
-// resolvedTag records the repository, tag, and resolved digest reference |
|
| 298 |
-// from a Dockerfile rewrite. |
|
| 299 |
-type resolvedTag struct {
|
|
| 300 |
- digestRef reference.Canonical |
|
| 301 |
- tagRef reference.NamedTagged |
|
| 302 |
-} |
|
| 303 |
- |
|
| 304 |
-// rewriteDockerfileFrom rewrites the given Dockerfile by resolving images in |
|
| 305 |
-// "FROM <image>" instructions to a digest reference. `translator` is a |
|
| 306 |
-// function that takes a repository name and tag reference and returns a |
|
| 307 |
-// trusted digest reference. |
|
| 308 |
-func rewriteDockerfileFrom(ctx context.Context, dockerfile io.Reader, translator translatorFunc) (newDockerfile []byte, resolvedTags []*resolvedTag, err error) {
|
|
| 309 |
- scanner := bufio.NewScanner(dockerfile) |
|
| 310 |
- buf := bytes.NewBuffer(nil) |
|
| 311 |
- |
|
| 312 |
- // Scan the lines of the Dockerfile, looking for a "FROM" line. |
|
| 313 |
- for scanner.Scan() {
|
|
| 314 |
- line := scanner.Text() |
|
| 315 |
- |
|
| 316 |
- matches := dockerfileFromLinePattern.FindStringSubmatch(line) |
|
| 317 |
- if matches != nil && matches[1] != api.NoBaseImageSpecifier {
|
|
| 318 |
- // Replace the line with a resolved "FROM repo@digest" |
|
| 319 |
- ref, err := reference.ParseNamed(matches[1]) |
|
| 320 |
- if err != nil {
|
|
| 321 |
- return nil, nil, err |
|
| 322 |
- } |
|
| 323 |
- ref = reference.WithDefaultTag(ref) |
|
| 324 |
- if ref, ok := ref.(reference.NamedTagged); ok && IsTrusted() {
|
|
| 325 |
- trustedRef, err := translator(ctx, ref) |
|
| 326 |
- if err != nil {
|
|
| 327 |
- return nil, nil, err |
|
| 328 |
- } |
|
| 329 |
- |
|
| 330 |
- line = dockerfileFromLinePattern.ReplaceAllLiteralString(line, fmt.Sprintf("FROM %s", trustedRef.String()))
|
|
| 331 |
- resolvedTags = append(resolvedTags, &resolvedTag{
|
|
| 332 |
- digestRef: trustedRef, |
|
| 333 |
- tagRef: ref, |
|
| 334 |
- }) |
|
| 335 |
- } |
|
| 336 |
- } |
|
| 337 |
- |
|
| 338 |
- _, err := fmt.Fprintln(buf, line) |
|
| 339 |
- if err != nil {
|
|
| 340 |
- return nil, nil, err |
|
| 341 |
- } |
|
| 342 |
- } |
|
| 343 |
- |
|
| 344 |
- return buf.Bytes(), resolvedTags, scanner.Err() |
|
| 345 |
-} |
|
| 346 |
- |
|
| 347 |
-// replaceDockerfileTarWrapper wraps the given input tar archive stream and |
|
| 348 |
-// replaces the entry with the given Dockerfile name with the contents of the |
|
| 349 |
-// new Dockerfile. Returns a new tar archive stream with the replaced |
|
| 350 |
-// Dockerfile. |
|
| 351 |
-func replaceDockerfileTarWrapper(ctx context.Context, inputTarStream io.ReadCloser, dockerfileName string, translator translatorFunc, resolvedTags *[]*resolvedTag) io.ReadCloser {
|
|
| 352 |
- pipeReader, pipeWriter := io.Pipe() |
|
| 353 |
- go func() {
|
|
| 354 |
- tarReader := tar.NewReader(inputTarStream) |
|
| 355 |
- tarWriter := tar.NewWriter(pipeWriter) |
|
| 356 |
- |
|
| 357 |
- defer inputTarStream.Close() |
|
| 358 |
- |
|
| 359 |
- for {
|
|
| 360 |
- hdr, err := tarReader.Next() |
|
| 361 |
- if err == io.EOF {
|
|
| 362 |
- // Signals end of archive. |
|
| 363 |
- tarWriter.Close() |
|
| 364 |
- pipeWriter.Close() |
|
| 365 |
- return |
|
| 366 |
- } |
|
| 367 |
- if err != nil {
|
|
| 368 |
- pipeWriter.CloseWithError(err) |
|
| 369 |
- return |
|
| 370 |
- } |
|
| 371 |
- |
|
| 372 |
- var content io.Reader = tarReader |
|
| 373 |
- if hdr.Name == dockerfileName {
|
|
| 374 |
- // This entry is the Dockerfile. Since the tar archive was |
|
| 375 |
- // generated from a directory on the local filesystem, the |
|
| 376 |
- // Dockerfile will only appear once in the archive. |
|
| 377 |
- var newDockerfile []byte |
|
| 378 |
- newDockerfile, *resolvedTags, err = rewriteDockerfileFrom(ctx, content, translator) |
|
| 379 |
- if err != nil {
|
|
| 380 |
- pipeWriter.CloseWithError(err) |
|
| 381 |
- return |
|
| 382 |
- } |
|
| 383 |
- hdr.Size = int64(len(newDockerfile)) |
|
| 384 |
- content = bytes.NewBuffer(newDockerfile) |
|
| 385 |
- } |
|
| 386 |
- |
|
| 387 |
- if err := tarWriter.WriteHeader(hdr); err != nil {
|
|
| 388 |
- pipeWriter.CloseWithError(err) |
|
| 389 |
- return |
|
| 390 |
- } |
|
| 391 |
- |
|
| 392 |
- if _, err := io.Copy(tarWriter, content); err != nil {
|
|
| 393 |
- pipeWriter.CloseWithError(err) |
|
| 394 |
- return |
|
| 395 |
- } |
|
| 396 |
- } |
|
| 397 |
- }() |
|
| 398 |
- |
|
| 399 |
- return pipeReader |
|
| 400 |
-} |
| ... | ... |
@@ -3,7 +3,6 @@ package client |
| 3 | 3 |
// Command returns a cli command handler if one exists |
| 4 | 4 |
func (cli *DockerCli) Command(name string) func(...string) error {
|
| 5 | 5 |
return map[string]func(...string) error{
|
| 6 |
- "build": cli.CmdBuild, |
|
| 7 | 6 |
"commit": cli.CmdCommit, |
| 8 | 7 |
"cp": cli.CmdCp, |
| 9 | 8 |
"events": cli.CmdEvents, |
| 10 | 9 |
new file mode 100644 |
| ... | ... |
@@ -0,0 +1,432 @@ |
| 0 |
+package image |
|
| 1 |
+ |
|
| 2 |
+import ( |
|
| 3 |
+ "archive/tar" |
|
| 4 |
+ "bufio" |
|
| 5 |
+ "bytes" |
|
| 6 |
+ "fmt" |
|
| 7 |
+ "io" |
|
| 8 |
+ "os" |
|
| 9 |
+ "path/filepath" |
|
| 10 |
+ "regexp" |
|
| 11 |
+ "runtime" |
|
| 12 |
+ |
|
| 13 |
+ "golang.org/x/net/context" |
|
| 14 |
+ |
|
| 15 |
+ "github.com/docker/docker/api" |
|
| 16 |
+ "github.com/docker/docker/api/client" |
|
| 17 |
+ "github.com/docker/docker/builder" |
|
| 18 |
+ "github.com/docker/docker/builder/dockerignore" |
|
| 19 |
+ "github.com/docker/docker/cli" |
|
| 20 |
+ "github.com/docker/docker/opts" |
|
| 21 |
+ "github.com/docker/docker/pkg/archive" |
|
| 22 |
+ "github.com/docker/docker/pkg/fileutils" |
|
| 23 |
+ "github.com/docker/docker/pkg/jsonmessage" |
|
| 24 |
+ "github.com/docker/docker/pkg/progress" |
|
| 25 |
+ "github.com/docker/docker/pkg/streamformatter" |
|
| 26 |
+ "github.com/docker/docker/pkg/urlutil" |
|
| 27 |
+ "github.com/docker/docker/reference" |
|
| 28 |
+ runconfigopts "github.com/docker/docker/runconfig/opts" |
|
| 29 |
+ "github.com/docker/engine-api/types" |
|
| 30 |
+ "github.com/docker/engine-api/types/container" |
|
| 31 |
+ "github.com/docker/go-units" |
|
| 32 |
+ "github.com/spf13/cobra" |
|
| 33 |
+) |
|
| 34 |
+ |
|
| 35 |
+type buildOptions struct {
|
|
| 36 |
+ context string |
|
| 37 |
+ dockerfileName string |
|
| 38 |
+ tags opts.ListOpts |
|
| 39 |
+ labels []string |
|
| 40 |
+ buildArgs opts.ListOpts |
|
| 41 |
+ ulimits *runconfigopts.UlimitOpt |
|
| 42 |
+ memory string |
|
| 43 |
+ memorySwap string |
|
| 44 |
+ shmSize string |
|
| 45 |
+ cpuShares int64 |
|
| 46 |
+ cpuPeriod int64 |
|
| 47 |
+ cpuQuota int64 |
|
| 48 |
+ cpuSetCpus string |
|
| 49 |
+ cpuSetMems string |
|
| 50 |
+ cgroupParent string |
|
| 51 |
+ isolation string |
|
| 52 |
+ quiet bool |
|
| 53 |
+ noCache bool |
|
| 54 |
+ rm bool |
|
| 55 |
+ forceRm bool |
|
| 56 |
+ pull bool |
|
| 57 |
+} |
|
| 58 |
+ |
|
| 59 |
+// NewBuildCommand creates a new `docker build` command |
|
| 60 |
+func NewBuildCommand(dockerCli *client.DockerCli) *cobra.Command {
|
|
| 61 |
+ ulimits := make(map[string]*units.Ulimit) |
|
| 62 |
+ options := buildOptions{
|
|
| 63 |
+ tags: opts.NewListOpts(validateTag), |
|
| 64 |
+ buildArgs: opts.NewListOpts(runconfigopts.ValidateEnv), |
|
| 65 |
+ ulimits: runconfigopts.NewUlimitOpt(&ulimits), |
|
| 66 |
+ } |
|
| 67 |
+ |
|
| 68 |
+ cmd := &cobra.Command{
|
|
| 69 |
+ Use: "build PATH | URL | -", |
|
| 70 |
+ Short: "Build an image from a Dockerfile", |
|
| 71 |
+ Args: cli.ExactArgs(1), |
|
| 72 |
+ RunE: func(cmd *cobra.Command, args []string) error {
|
|
| 73 |
+ options.context = args[0] |
|
| 74 |
+ return runBuild(dockerCli, options) |
|
| 75 |
+ }, |
|
| 76 |
+ } |
|
| 77 |
+ |
|
| 78 |
+ flags := cmd.Flags() |
|
| 79 |
+ |
|
| 80 |
+ flags.VarP(&options.tags, "tag", "t", "Name and optionally a tag in the 'name:tag' format") |
|
| 81 |
+ flags.Var(&options.buildArgs, "build-arg", "Set build-time variables") |
|
| 82 |
+ flags.Var(options.ulimits, "ulimit", "Ulimit options") |
|
| 83 |
+ flags.StringVarP(&options.dockerfileName, "file", "f", "", "Name of the Dockerfile (Default is 'PATH/Dockerfile')") |
|
| 84 |
+ flags.StringVarP(&options.memory, "memory", "m", "", "Memory limit") |
|
| 85 |
+ flags.StringVar(&options.memorySwap, "memory-swap", "", "Swap limit equal to memory plus swap: '-1' to enable unlimited swap") |
|
| 86 |
+ flags.StringVar(&options.shmSize, "shm-size", "", "Size of /dev/shm, default value is 64MB") |
|
| 87 |
+ flags.Int64VarP(&options.cpuShares, "cpu-shares", "c", 0, "CPU shares (relative weight)") |
|
| 88 |
+ flags.Int64Var(&options.cpuPeriod, "cpu-period", 0, "Limit the CPU CFS (Completely Fair Scheduler) period") |
|
| 89 |
+ flags.Int64Var(&options.cpuQuota, "cpu-quota", 0, "Limit the CPU CFS (Completely Fair Scheduler) quota") |
|
| 90 |
+ flags.StringVar(&options.cpuSetCpus, "cpuset-cpus", "", "CPUs in which to allow execution (0-3, 0,1)") |
|
| 91 |
+ flags.StringVar(&options.cpuSetMems, "cpuset-mems", "", "MEMs in which to allow execution (0-3, 0,1)") |
|
| 92 |
+ flags.StringVar(&options.cgroupParent, "cgroup-parent", "", "Optional parent cgroup for the container") |
|
| 93 |
+ flags.StringVar(&options.isolation, "isolation", "", "Container isolation technology") |
|
| 94 |
+ flags.StringSliceVar(&options.labels, "label", []string{}, "Set metadata for an image")
|
|
| 95 |
+ flags.BoolVar(&options.noCache, "no-cache", false, "Do not use cache when building the image") |
|
| 96 |
+ flags.BoolVar(&options.rm, "rm", true, "Remove intermediate containers after a successful build") |
|
| 97 |
+ flags.BoolVar(&options.forceRm, "force-rm", false, "Always remove intermediate containers") |
|
| 98 |
+ flags.BoolVarP(&options.quiet, "quiet", "q", false, "Suppress the build output and print image ID on success") |
|
| 99 |
+ flags.BoolVar(&options.pull, "pull", false, "Always attempt to pull a newer version of the image") |
|
| 100 |
+ |
|
| 101 |
+ client.AddTrustedFlags(flags, true) |
|
| 102 |
+ |
|
| 103 |
+ return cmd |
|
| 104 |
+} |
|
| 105 |
+ |
|
| 106 |
+func runBuild(dockerCli *client.DockerCli, options buildOptions) error {
|
|
| 107 |
+ |
|
| 108 |
+ var ( |
|
| 109 |
+ buildCtx io.ReadCloser |
|
| 110 |
+ err error |
|
| 111 |
+ ) |
|
| 112 |
+ |
|
| 113 |
+ specifiedContext := options.context |
|
| 114 |
+ |
|
| 115 |
+ var ( |
|
| 116 |
+ contextDir string |
|
| 117 |
+ tempDir string |
|
| 118 |
+ relDockerfile string |
|
| 119 |
+ progBuff io.Writer |
|
| 120 |
+ buildBuff io.Writer |
|
| 121 |
+ ) |
|
| 122 |
+ |
|
| 123 |
+ progBuff = dockerCli.Out() |
|
| 124 |
+ buildBuff = dockerCli.Out() |
|
| 125 |
+ if options.quiet {
|
|
| 126 |
+ progBuff = bytes.NewBuffer(nil) |
|
| 127 |
+ buildBuff = bytes.NewBuffer(nil) |
|
| 128 |
+ } |
|
| 129 |
+ |
|
| 130 |
+ switch {
|
|
| 131 |
+ case specifiedContext == "-": |
|
| 132 |
+ buildCtx, relDockerfile, err = builder.GetContextFromReader(dockerCli.In(), options.dockerfileName) |
|
| 133 |
+ case urlutil.IsGitURL(specifiedContext): |
|
| 134 |
+ tempDir, relDockerfile, err = builder.GetContextFromGitURL(specifiedContext, options.dockerfileName) |
|
| 135 |
+ case urlutil.IsURL(specifiedContext): |
|
| 136 |
+ buildCtx, relDockerfile, err = builder.GetContextFromURL(progBuff, specifiedContext, options.dockerfileName) |
|
| 137 |
+ default: |
|
| 138 |
+ contextDir, relDockerfile, err = builder.GetContextFromLocalDir(specifiedContext, options.dockerfileName) |
|
| 139 |
+ } |
|
| 140 |
+ |
|
| 141 |
+ if err != nil {
|
|
| 142 |
+ if options.quiet && urlutil.IsURL(specifiedContext) {
|
|
| 143 |
+ fmt.Fprintln(dockerCli.Err(), progBuff) |
|
| 144 |
+ } |
|
| 145 |
+ return fmt.Errorf("unable to prepare context: %s", err)
|
|
| 146 |
+ } |
|
| 147 |
+ |
|
| 148 |
+ if tempDir != "" {
|
|
| 149 |
+ defer os.RemoveAll(tempDir) |
|
| 150 |
+ contextDir = tempDir |
|
| 151 |
+ } |
|
| 152 |
+ |
|
| 153 |
+ if buildCtx == nil {
|
|
| 154 |
+ // And canonicalize dockerfile name to a platform-independent one |
|
| 155 |
+ relDockerfile, err = archive.CanonicalTarNameForPath(relDockerfile) |
|
| 156 |
+ if err != nil {
|
|
| 157 |
+ return fmt.Errorf("cannot canonicalize dockerfile path %s: %v", relDockerfile, err)
|
|
| 158 |
+ } |
|
| 159 |
+ |
|
| 160 |
+ f, err := os.Open(filepath.Join(contextDir, ".dockerignore")) |
|
| 161 |
+ if err != nil && !os.IsNotExist(err) {
|
|
| 162 |
+ return err |
|
| 163 |
+ } |
|
| 164 |
+ |
|
| 165 |
+ var excludes []string |
|
| 166 |
+ if err == nil {
|
|
| 167 |
+ excludes, err = dockerignore.ReadAll(f) |
|
| 168 |
+ if err != nil {
|
|
| 169 |
+ return err |
|
| 170 |
+ } |
|
| 171 |
+ } |
|
| 172 |
+ |
|
| 173 |
+ if err := builder.ValidateContextDirectory(contextDir, excludes); err != nil {
|
|
| 174 |
+ return fmt.Errorf("Error checking context: '%s'.", err)
|
|
| 175 |
+ } |
|
| 176 |
+ |
|
| 177 |
+ // If .dockerignore mentions .dockerignore or the Dockerfile |
|
| 178 |
+ // then make sure we send both files over to the daemon |
|
| 179 |
+ // because Dockerfile is, obviously, needed no matter what, and |
|
| 180 |
+ // .dockerignore is needed to know if either one needs to be |
|
| 181 |
+ // removed. The daemon will remove them for us, if needed, after it |
|
| 182 |
+ // parses the Dockerfile. Ignore errors here, as they will have been |
|
| 183 |
+ // caught by validateContextDirectory above. |
|
| 184 |
+ var includes = []string{"."}
|
|
| 185 |
+ keepThem1, _ := fileutils.Matches(".dockerignore", excludes)
|
|
| 186 |
+ keepThem2, _ := fileutils.Matches(relDockerfile, excludes) |
|
| 187 |
+ if keepThem1 || keepThem2 {
|
|
| 188 |
+ includes = append(includes, ".dockerignore", relDockerfile) |
|
| 189 |
+ } |
|
| 190 |
+ |
|
| 191 |
+ buildCtx, err = archive.TarWithOptions(contextDir, &archive.TarOptions{
|
|
| 192 |
+ Compression: archive.Uncompressed, |
|
| 193 |
+ ExcludePatterns: excludes, |
|
| 194 |
+ IncludeFiles: includes, |
|
| 195 |
+ }) |
|
| 196 |
+ if err != nil {
|
|
| 197 |
+ return err |
|
| 198 |
+ } |
|
| 199 |
+ } |
|
| 200 |
+ |
|
| 201 |
+ ctx := context.Background() |
|
| 202 |
+ |
|
| 203 |
+ var resolvedTags []*resolvedTag |
|
| 204 |
+ if client.IsTrusted() {
|
|
| 205 |
+ // Wrap the tar archive to replace the Dockerfile entry with the rewritten |
|
| 206 |
+ // Dockerfile which uses trusted pulls. |
|
| 207 |
+ buildCtx = replaceDockerfileTarWrapper(ctx, buildCtx, relDockerfile, dockerCli.TrustedReference, &resolvedTags) |
|
| 208 |
+ } |
|
| 209 |
+ |
|
| 210 |
+ // Setup an upload progress bar |
|
| 211 |
+ progressOutput := streamformatter.NewStreamFormatter().NewProgressOutput(progBuff, true) |
|
| 212 |
+ |
|
| 213 |
+ var body io.Reader = progress.NewProgressReader(buildCtx, progressOutput, 0, "", "Sending build context to Docker daemon") |
|
| 214 |
+ |
|
| 215 |
+ var memory int64 |
|
| 216 |
+ if options.memory != "" {
|
|
| 217 |
+ parsedMemory, err := units.RAMInBytes(options.memory) |
|
| 218 |
+ if err != nil {
|
|
| 219 |
+ return err |
|
| 220 |
+ } |
|
| 221 |
+ memory = parsedMemory |
|
| 222 |
+ } |
|
| 223 |
+ |
|
| 224 |
+ var memorySwap int64 |
|
| 225 |
+ if options.memorySwap != "" {
|
|
| 226 |
+ if options.memorySwap == "-1" {
|
|
| 227 |
+ memorySwap = -1 |
|
| 228 |
+ } else {
|
|
| 229 |
+ parsedMemorySwap, err := units.RAMInBytes(options.memorySwap) |
|
| 230 |
+ if err != nil {
|
|
| 231 |
+ return err |
|
| 232 |
+ } |
|
| 233 |
+ memorySwap = parsedMemorySwap |
|
| 234 |
+ } |
|
| 235 |
+ } |
|
| 236 |
+ |
|
| 237 |
+ var shmSize int64 |
|
| 238 |
+ if options.shmSize != "" {
|
|
| 239 |
+ shmSize, err = units.RAMInBytes(options.shmSize) |
|
| 240 |
+ if err != nil {
|
|
| 241 |
+ return err |
|
| 242 |
+ } |
|
| 243 |
+ } |
|
| 244 |
+ |
|
| 245 |
+ buildOptions := types.ImageBuildOptions{
|
|
| 246 |
+ Memory: memory, |
|
| 247 |
+ MemorySwap: memorySwap, |
|
| 248 |
+ Tags: options.tags.GetAll(), |
|
| 249 |
+ SuppressOutput: options.quiet, |
|
| 250 |
+ NoCache: options.noCache, |
|
| 251 |
+ Remove: options.rm, |
|
| 252 |
+ ForceRemove: options.forceRm, |
|
| 253 |
+ PullParent: options.pull, |
|
| 254 |
+ Isolation: container.Isolation(options.isolation), |
|
| 255 |
+ CPUSetCPUs: options.cpuSetCpus, |
|
| 256 |
+ CPUSetMems: options.cpuSetMems, |
|
| 257 |
+ CPUShares: options.cpuShares, |
|
| 258 |
+ CPUQuota: options.cpuQuota, |
|
| 259 |
+ CPUPeriod: options.cpuPeriod, |
|
| 260 |
+ CgroupParent: options.cgroupParent, |
|
| 261 |
+ Dockerfile: relDockerfile, |
|
| 262 |
+ ShmSize: shmSize, |
|
| 263 |
+ Ulimits: options.ulimits.GetList(), |
|
| 264 |
+ BuildArgs: runconfigopts.ConvertKVStringsToMap(options.buildArgs.GetAll()), |
|
| 265 |
+ AuthConfigs: dockerCli.RetrieveAuthConfigs(), |
|
| 266 |
+ Labels: runconfigopts.ConvertKVStringsToMap(options.labels), |
|
| 267 |
+ } |
|
| 268 |
+ |
|
| 269 |
+ response, err := dockerCli.Client().ImageBuild(ctx, body, buildOptions) |
|
| 270 |
+ if err != nil {
|
|
| 271 |
+ return err |
|
| 272 |
+ } |
|
| 273 |
+ defer response.Body.Close() |
|
| 274 |
+ |
|
| 275 |
+ err = jsonmessage.DisplayJSONMessagesStream(response.Body, buildBuff, dockerCli.OutFd(), dockerCli.IsTerminalOut(), nil) |
|
| 276 |
+ if err != nil {
|
|
| 277 |
+ if jerr, ok := err.(*jsonmessage.JSONError); ok {
|
|
| 278 |
+ // If no error code is set, default to 1 |
|
| 279 |
+ if jerr.Code == 0 {
|
|
| 280 |
+ jerr.Code = 1 |
|
| 281 |
+ } |
|
| 282 |
+ if options.quiet {
|
|
| 283 |
+ fmt.Fprintf(dockerCli.Err(), "%s%s", progBuff, buildBuff) |
|
| 284 |
+ } |
|
| 285 |
+ return cli.StatusError{Status: jerr.Message, StatusCode: jerr.Code}
|
|
| 286 |
+ } |
|
| 287 |
+ } |
|
| 288 |
+ |
|
| 289 |
+ // Windows: show error message about modified file permissions if the |
|
| 290 |
+ // daemon isn't running Windows. |
|
| 291 |
+ if response.OSType != "windows" && runtime.GOOS == "windows" {
|
|
| 292 |
+ fmt.Fprintln(dockerCli.Err(), `SECURITY WARNING: You are building a Docker image from Windows against a non-Windows Docker host. All files and directories added to build context will have '-rwxr-xr-x' permissions. It is recommended to double check and reset permissions for sensitive files and directories.`) |
|
| 293 |
+ } |
|
| 294 |
+ |
|
| 295 |
+ // Everything worked so if -q was provided the output from the daemon |
|
| 296 |
+ // should be just the image ID and we'll print that to stdout. |
|
| 297 |
+ if options.quiet {
|
|
| 298 |
+ fmt.Fprintf(dockerCli.Out(), "%s", buildBuff) |
|
| 299 |
+ } |
|
| 300 |
+ |
|
| 301 |
+ if client.IsTrusted() {
|
|
| 302 |
+ // Since the build was successful, now we must tag any of the resolved |
|
| 303 |
+ // images from the above Dockerfile rewrite. |
|
| 304 |
+ for _, resolved := range resolvedTags {
|
|
| 305 |
+ if err := dockerCli.TagTrusted(ctx, resolved.digestRef, resolved.tagRef); err != nil {
|
|
| 306 |
+ return err |
|
| 307 |
+ } |
|
| 308 |
+ } |
|
| 309 |
+ } |
|
| 310 |
+ |
|
| 311 |
+ return nil |
|
| 312 |
+} |
|
| 313 |
+ |
|
| 314 |
+type translatorFunc func(context.Context, reference.NamedTagged) (reference.Canonical, error) |
|
| 315 |
+ |
|
| 316 |
+// validateTag checks if the given image name can be resolved. |
|
| 317 |
+func validateTag(rawRepo string) (string, error) {
|
|
| 318 |
+ _, err := reference.ParseNamed(rawRepo) |
|
| 319 |
+ if err != nil {
|
|
| 320 |
+ return "", err |
|
| 321 |
+ } |
|
| 322 |
+ |
|
| 323 |
+ return rawRepo, nil |
|
| 324 |
+} |
|
| 325 |
+ |
|
| 326 |
+var dockerfileFromLinePattern = regexp.MustCompile(`(?i)^[\s]*FROM[ \f\r\t\v]+(?P<image>[^ \f\r\t\v\n#]+)`) |
|
| 327 |
+ |
|
| 328 |
+// resolvedTag records the repository, tag, and resolved digest reference |
|
| 329 |
+// from a Dockerfile rewrite. |
|
| 330 |
+type resolvedTag struct {
|
|
| 331 |
+ digestRef reference.Canonical |
|
| 332 |
+ tagRef reference.NamedTagged |
|
| 333 |
+} |
|
| 334 |
+ |
|
| 335 |
+// rewriteDockerfileFrom rewrites the given Dockerfile by resolving images in |
|
| 336 |
+// "FROM <image>" instructions to a digest reference. `translator` is a |
|
| 337 |
+// function that takes a repository name and tag reference and returns a |
|
| 338 |
+// trusted digest reference. |
|
| 339 |
+func rewriteDockerfileFrom(ctx context.Context, dockerfile io.Reader, translator translatorFunc) (newDockerfile []byte, resolvedTags []*resolvedTag, err error) {
|
|
| 340 |
+ scanner := bufio.NewScanner(dockerfile) |
|
| 341 |
+ buf := bytes.NewBuffer(nil) |
|
| 342 |
+ |
|
| 343 |
+ // Scan the lines of the Dockerfile, looking for a "FROM" line. |
|
| 344 |
+ for scanner.Scan() {
|
|
| 345 |
+ line := scanner.Text() |
|
| 346 |
+ |
|
| 347 |
+ matches := dockerfileFromLinePattern.FindStringSubmatch(line) |
|
| 348 |
+ if matches != nil && matches[1] != api.NoBaseImageSpecifier {
|
|
| 349 |
+ // Replace the line with a resolved "FROM repo@digest" |
|
| 350 |
+ ref, err := reference.ParseNamed(matches[1]) |
|
| 351 |
+ if err != nil {
|
|
| 352 |
+ return nil, nil, err |
|
| 353 |
+ } |
|
| 354 |
+ ref = reference.WithDefaultTag(ref) |
|
| 355 |
+ if ref, ok := ref.(reference.NamedTagged); ok && client.IsTrusted() {
|
|
| 356 |
+ trustedRef, err := translator(ctx, ref) |
|
| 357 |
+ if err != nil {
|
|
| 358 |
+ return nil, nil, err |
|
| 359 |
+ } |
|
| 360 |
+ |
|
| 361 |
+ line = dockerfileFromLinePattern.ReplaceAllLiteralString(line, fmt.Sprintf("FROM %s", trustedRef.String()))
|
|
| 362 |
+ resolvedTags = append(resolvedTags, &resolvedTag{
|
|
| 363 |
+ digestRef: trustedRef, |
|
| 364 |
+ tagRef: ref, |
|
| 365 |
+ }) |
|
| 366 |
+ } |
|
| 367 |
+ } |
|
| 368 |
+ |
|
| 369 |
+ _, err := fmt.Fprintln(buf, line) |
|
| 370 |
+ if err != nil {
|
|
| 371 |
+ return nil, nil, err |
|
| 372 |
+ } |
|
| 373 |
+ } |
|
| 374 |
+ |
|
| 375 |
+ return buf.Bytes(), resolvedTags, scanner.Err() |
|
| 376 |
+} |
|
| 377 |
+ |
|
| 378 |
+// replaceDockerfileTarWrapper wraps the given input tar archive stream and |
|
| 379 |
+// replaces the entry with the given Dockerfile name with the contents of the |
|
| 380 |
+// new Dockerfile. Returns a new tar archive stream with the replaced |
|
| 381 |
+// Dockerfile. |
|
| 382 |
+func replaceDockerfileTarWrapper(ctx context.Context, inputTarStream io.ReadCloser, dockerfileName string, translator translatorFunc, resolvedTags *[]*resolvedTag) io.ReadCloser {
|
|
| 383 |
+ pipeReader, pipeWriter := io.Pipe() |
|
| 384 |
+ go func() {
|
|
| 385 |
+ tarReader := tar.NewReader(inputTarStream) |
|
| 386 |
+ tarWriter := tar.NewWriter(pipeWriter) |
|
| 387 |
+ |
|
| 388 |
+ defer inputTarStream.Close() |
|
| 389 |
+ |
|
| 390 |
+ for {
|
|
| 391 |
+ hdr, err := tarReader.Next() |
|
| 392 |
+ if err == io.EOF {
|
|
| 393 |
+ // Signals end of archive. |
|
| 394 |
+ tarWriter.Close() |
|
| 395 |
+ pipeWriter.Close() |
|
| 396 |
+ return |
|
| 397 |
+ } |
|
| 398 |
+ if err != nil {
|
|
| 399 |
+ pipeWriter.CloseWithError(err) |
|
| 400 |
+ return |
|
| 401 |
+ } |
|
| 402 |
+ |
|
| 403 |
+ var content io.Reader = tarReader |
|
| 404 |
+ if hdr.Name == dockerfileName {
|
|
| 405 |
+ // This entry is the Dockerfile. Since the tar archive was |
|
| 406 |
+ // generated from a directory on the local filesystem, the |
|
| 407 |
+ // Dockerfile will only appear once in the archive. |
|
| 408 |
+ var newDockerfile []byte |
|
| 409 |
+ newDockerfile, *resolvedTags, err = rewriteDockerfileFrom(ctx, content, translator) |
|
| 410 |
+ if err != nil {
|
|
| 411 |
+ pipeWriter.CloseWithError(err) |
|
| 412 |
+ return |
|
| 413 |
+ } |
|
| 414 |
+ hdr.Size = int64(len(newDockerfile)) |
|
| 415 |
+ content = bytes.NewBuffer(newDockerfile) |
|
| 416 |
+ } |
|
| 417 |
+ |
|
| 418 |
+ if err := tarWriter.WriteHeader(hdr); err != nil {
|
|
| 419 |
+ pipeWriter.CloseWithError(err) |
|
| 420 |
+ return |
|
| 421 |
+ } |
|
| 422 |
+ |
|
| 423 |
+ if _, err := io.Copy(tarWriter, content); err != nil {
|
|
| 424 |
+ pipeWriter.CloseWithError(err) |
|
| 425 |
+ return |
|
| 426 |
+ } |
|
| 427 |
+ } |
|
| 428 |
+ }() |
|
| 429 |
+ |
|
| 430 |
+ return pipeReader |
|
| 431 |
+} |
| ... | ... |
@@ -202,7 +202,8 @@ func (cli *DockerCli) ResolveAuthConfig(ctx context.Context, index *registrytype |
| 202 | 202 |
return a |
| 203 | 203 |
} |
| 204 | 204 |
|
| 205 |
-func (cli *DockerCli) retrieveAuthConfigs() map[string]types.AuthConfig {
|
|
| 205 |
+// RetrieveAuthConfigs return all credentials. |
|
| 206 |
+func (cli *DockerCli) RetrieveAuthConfigs() map[string]types.AuthConfig {
|
|
| 206 | 207 |
acs, _ := getAllCredentials(cli.configFile) |
| 207 | 208 |
return acs |
| 208 | 209 |
} |
| ... | ... |
@@ -50,6 +50,7 @@ func NewCobraAdaptor(clientFlags *cliflags.ClientFlags) CobraAdaptor {
|
| 50 | 50 |
container.NewTopCommand(dockerCli), |
| 51 | 51 |
container.NewUnpauseCommand(dockerCli), |
| 52 | 52 |
container.NewWaitCommand(dockerCli), |
| 53 |
+ image.NewBuildCommand(dockerCli), |
|
| 53 | 54 |
image.NewHistoryCommand(dockerCli), |
| 54 | 55 |
image.NewRemoveCommand(dockerCli), |
| 55 | 56 |
image.NewSearchCommand(dockerCli), |
| ... | ... |
@@ -8,7 +8,6 @@ type Command struct {
|
| 8 | 8 |
|
| 9 | 9 |
// DockerCommandUsage lists the top level docker commands and their short usage |
| 10 | 10 |
var DockerCommandUsage = []Command{
|
| 11 |
- {"build", "Build an image from a Dockerfile"},
|
|
| 12 | 11 |
{"commit", "Create a new image from a container's changes"},
|
| 13 | 12 |
{"cp", "Copy files/folders between a container and the local filesystem"},
|
| 14 | 13 |
{"events", "Get real time events from the server"},
|
| ... | ... |
@@ -4685,16 +4685,17 @@ func (s *DockerSuite) TestBuildNotVerboseFailure(c *check.C) {
|
| 4685 | 4685 |
|
| 4686 | 4686 |
func (s *DockerSuite) TestBuildNotVerboseFailureRemote(c *check.C) {
|
| 4687 | 4687 |
// This test ensures that when given a wrong URL, stderr in quiet mode and |
| 4688 |
- // stdout and stderr in verbose mode are identical. |
|
| 4689 |
- URL := "http://bla.bla.com" |
|
| 4688 |
+ // stderr in verbose mode are identical. |
|
| 4689 |
+ // TODO(vdemeester) with cobra, stdout has a carriage return too much so this test should not check stdout |
|
| 4690 |
+ URL := "http://something.invalid" |
|
| 4690 | 4691 |
Name := "quiet_build_wrong_remote" |
| 4691 | 4692 |
_, _, qstderr, qerr := buildImageWithStdoutStderr(Name, "", false, "-q", "--force-rm", "--rm", URL) |
| 4692 |
- _, vstdout, vstderr, verr := buildImageWithStdoutStderr(Name, "", false, "--force-rm", "--rm", URL) |
|
| 4693 |
+ _, _, vstderr, verr := buildImageWithStdoutStderr(Name, "", false, "--force-rm", "--rm", URL) |
|
| 4693 | 4694 |
if qerr == nil || verr == nil {
|
| 4694 | 4695 |
c.Fatal(fmt.Errorf("Test [%s] expected to fail but didn't", Name))
|
| 4695 | 4696 |
} |
| 4696 |
- if qstderr != vstdout+vstderr {
|
|
| 4697 |
- c.Fatal(fmt.Errorf("Test[%s] expected that quiet stderr and verbose stdout are equal; quiet [%v], verbose [%v]", Name, qstderr, vstdout))
|
|
| 4697 |
+ if qstderr != vstderr {
|
|
| 4698 |
+ c.Fatal(fmt.Errorf("Test[%s] expected that quiet stderr and verbose stdout are equal; quiet [%v], verbose [%v]", Name, qstderr, vstderr))
|
|
| 4698 | 4699 |
} |
| 4699 | 4700 |
} |
| 4700 | 4701 |
|