Browse code

devmapper: Rename DeviceSet.RemoveDevice to DeleteDevice

"Remove" is a bit overloaded, as it is also what deactivating a
device mapper device is called. Using "delete" is more clear here.

Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson)

Alexander Larsson authored on 2014/02/05 01:13:00
Showing 2 changed files
... ...
@@ -290,7 +290,7 @@ func (devices *DeviceSet) setupBaseImage() error {
290 290
 
291 291
 	if oldInfo != nil && !oldInfo.Initialized {
292 292
 		utils.Debugf("Removing uninitialized base image")
293
-		if err := devices.removeDevice(""); err != nil {
293
+		if err := devices.deleteDevice(""); err != nil {
294 294
 			utils.Debugf("\n--->Err: %s\n", err)
295 295
 			return err
296 296
 		}
... ...
@@ -562,7 +562,7 @@ func (devices *DeviceSet) AddDevice(hash, baseHash string) error {
562 562
 	return nil
563 563
 }
564 564
 
565
-func (devices *DeviceSet) removeDevice(hash string) error {
565
+func (devices *DeviceSet) deleteDevice(hash string) error {
566 566
 	info := devices.Devices[hash]
567 567
 	if info == nil {
568 568
 		return fmt.Errorf("hash %s doesn't exists", hash)
... ...
@@ -610,11 +610,11 @@ func (devices *DeviceSet) removeDevice(hash string) error {
610 610
 	return nil
611 611
 }
612 612
 
613
-func (devices *DeviceSet) RemoveDevice(hash string) error {
613
+func (devices *DeviceSet) DeleteDevice(hash string) error {
614 614
 	devices.Lock()
615 615
 	defer devices.Unlock()
616 616
 
617
-	return devices.removeDevice(hash)
617
+	return devices.deleteDevice(hash)
618 618
 }
619 619
 
620 620
 func (devices *DeviceSet) deactivateDevice(hash string) error {
... ...
@@ -99,7 +99,7 @@ func (d *Driver) Remove(id string) error {
99 99
 	if err := d.unmount(id, mp); err != nil {
100 100
 		return err
101 101
 	}
102
-	return d.DeviceSet.RemoveDevice(id)
102
+	return d.DeviceSet.DeleteDevice(id)
103 103
 }
104 104
 
105 105
 func (d *Driver) Get(id string) (string, error) {