Signed-off-by: George MacRorie <gmacr31@gmail.com>
| ... | ... |
@@ -239,17 +239,18 @@ func parseJSON(rest string) (*Node, map[string]bool, error) {
|
| 239 | 239 |
|
| 240 | 240 |
var top, prev *Node |
| 241 | 241 |
for _, str := range myJson {
|
| 242 |
- if s, ok := str.(string); !ok {
|
|
| 242 |
+ s, ok := str.(string) |
|
| 243 |
+ if !ok {
|
|
| 243 | 244 |
return nil, nil, errDockerfileNotStringArray |
| 245 |
+ } |
|
| 246 |
+ |
|
| 247 |
+ node := &Node{Value: s}
|
|
| 248 |
+ if prev == nil {
|
|
| 249 |
+ top = node |
|
| 244 | 250 |
} else {
|
| 245 |
- node := &Node{Value: s}
|
|
| 246 |
- if prev == nil {
|
|
| 247 |
- top = node |
|
| 248 |
- } else {
|
|
| 249 |
- prev.Next = node |
|
| 250 |
- } |
|
| 251 |
- prev = node |
|
| 251 |
+ prev.Next = node |
|
| 252 | 252 |
} |
| 253 |
+ prev = node |
|
| 253 | 254 |
} |
| 254 | 255 |
|
| 255 | 256 |
return top, map[string]bool{"json": true}, nil
|
| ... | ... |
@@ -158,14 +158,13 @@ func (sw *shellWord) processDollar() (string, error) {
|
| 158 | 158 |
return sw.getEnv(name), nil |
| 159 | 159 |
} |
| 160 | 160 |
return "", fmt.Errorf("Unsupported ${} substitution: %s", sw.word)
|
| 161 |
- } else {
|
|
| 162 |
- // $xxx case |
|
| 163 |
- name := sw.processName() |
|
| 164 |
- if name == "" {
|
|
| 165 |
- return "$", nil |
|
| 166 |
- } |
|
| 167 |
- return sw.getEnv(name), nil |
|
| 168 | 161 |
} |
| 162 |
+ // $xxx case |
|
| 163 |
+ name := sw.processName() |
|
| 164 |
+ if name == "" {
|
|
| 165 |
+ return "$", nil |
|
| 166 |
+ } |
|
| 167 |
+ return sw.getEnv(name), nil |
|
| 169 | 168 |
} |
| 170 | 169 |
|
| 171 | 170 |
func (sw *shellWord) processName() string {
|
| ... | ... |
@@ -395,9 +395,8 @@ func getSliceOfPausedContainers() ([]string, error) {
|
| 395 | 395 |
if err == nil {
|
| 396 | 396 |
slice := strings.Split(strings.TrimSpace(out), "\n") |
| 397 | 397 |
return slice, err |
| 398 |
- } else {
|
|
| 399 |
- return []string{out}, err
|
|
| 400 | 398 |
} |
| 399 |
+ return []string{out}, err
|
|
| 401 | 400 |
} |
| 402 | 401 |
|
| 403 | 402 |
func unpauseContainer(container string) error {
|
| ... | ... |
@@ -192,9 +192,8 @@ func ValidateMACAddress(val string) (string, error) {
|
| 192 | 192 |
_, err := net.ParseMAC(strings.TrimSpace(val)) |
| 193 | 193 |
if err != nil {
|
| 194 | 194 |
return "", err |
| 195 |
- } else {
|
|
| 196 |
- return val, nil |
|
| 197 | 195 |
} |
| 196 |
+ return val, nil |
|
| 198 | 197 |
} |
| 199 | 198 |
|
| 200 | 199 |
// Validates domain for resolvconf search configuration. |