@@ -57,7 +57,7 @@ github.com/vishvananda/netlink                      b2de5d10e38ecce8607e6b438b6d

 github.com/BurntSushi/toml                          3012a1dbe2e4bd1391d42b32f0577cb7bbc7f005 # v0.3.1

 github.com/samuel/go-zookeeper                      d0e0d8e11f318e000a8cc434616d69e329edc374

 github.com/deckarep/golang-set                      ef32fa3046d9f249d399f98ebaf9be944430fd1d

-github.com/coreos/etcd                              fca8add78a9d926166eb739b8e4a124434025ba3 # v3.3.9

+github.com/coreos/etcd                              d57e8b8d97adfc4a6c224fe116714bf1a1f3beb9 # v3.3.12

 github.com/coreos/go-semver                         8ab6407b697782a06568d4b7f1db25550ec2e4c6 # v0.2.0

 github.com/ugorji/go                                b4c50a2b199d93b13dc15e78929cfb23bfdf21ab # v1.1.1

 github.com/hashicorp/consul                         9a9cc9341bb487651a0399e3fc5e1e8a42e62dd9 # v0.5.2

@@ -21,6 +21,7 @@ import (

 	"io/ioutil"

 	"os"

 	"path/filepath"

+	"time"

 	"github.com/coreos/etcd/pkg/fileutil"

 )

@@ -30,6 +31,8 @@ var ErrNoDBSnapshot = errors.New("snap: snapshot file doesn't exist")

 // SaveDBFrom saves snapshot of the database from the given reader. It

 // guarantees the save operation is atomic.

 func (s *Snapshotter) SaveDBFrom(r io.Reader, id uint64) (int64, error) {

+	start := time.Now()

+

 	f, err := ioutil.TempFile(s.dir, "tmp")

 	if err != nil {

 		return 0, err

@@ -37,7 +40,9 @@ func (s *Snapshotter) SaveDBFrom(r io.Reader, id uint64) (int64, error) {

 	var n int64

 	n, err = io.Copy(f, r)

 	if err == nil {

+		fsyncStart := time.Now()

 		err = fileutil.Fsync(f)

+		snapDBFsyncSec.Observe(time.Since(fsyncStart).Seconds())

 	}

 	f.Close()

 	if err != nil {

@@ -57,6 +62,7 @@ func (s *Snapshotter) SaveDBFrom(r io.Reader, id uint64) (int64, error) {

 	plog.Infof("saved database snapshot to disk [total bytes: %d]", n)

+	snapDBSaveSec.Observe(time.Since(start).Seconds())

 	return n, nil

 }

@@ -33,9 +33,33 @@ var (

 		Help:      "The marshalling cost distributions of save called by snapshot.",

 		Buckets:   prometheus.ExponentialBuckets(0.001, 2, 14),

 	})

+

+	snapDBSaveSec = prometheus.NewHistogram(prometheus.HistogramOpts{

+		Namespace: "etcd",

+		Subsystem: "snap_db",

+		Name:      "save_total_duration_seconds",

+		Help:      "The total latency distributions of v3 snapshot save",

+

+		// lowest bucket start of upper bound 0.1 sec (100 ms) with factor 2

+		// highest bucket start of 0.1 sec * 2^9 == 51.2 sec

+		Buckets: prometheus.ExponentialBuckets(0.1, 2, 10),

+	})

+

+	snapDBFsyncSec = prometheus.NewHistogram(prometheus.HistogramOpts{

+		Namespace: "etcd",

+		Subsystem: "snap_db",

+		Name:      "fsync_duration_seconds",

+		Help:      "The latency distributions of fsyncing .snap.db file",

+

+		// lowest bucket start of upper bound 0.001 sec (1 ms) with factor 2

+		// highest bucket start of 0.001 sec * 2^13 == 8.192 sec

+		Buckets: prometheus.ExponentialBuckets(0.001, 2, 14),

+	})

 )

 func init() {

 	prometheus.MustRegister(saveDurations)

 	prometheus.MustRegister(marshallingDurations)

+	prometheus.MustRegister(snapDBSaveSec)

+	prometheus.MustRegister(snapDBFsyncSec)

 }

@@ -26,7 +26,7 @@ import (

 var (

 	// MinClusterVersion is the min cluster version this etcd binary is compatible with.

 	MinClusterVersion = "3.0.0"

-	Version           = "3.3.9"

+	Version           = "3.3.12"

 	APIVersion        = "unknown"

 	// Git SHA Value will be set during build