Browse code
Improve TestParseHost
Guillaume J. Charmes authored on 2013/12/17 09:35:56Showing 1 changed files
| ... | ... |
@@ -299,28 +299,33 @@ func assertRAMInBytes(t *testing.T, size string, expectError bool, expectedBytes |
| 299 | 299 |
} |
| 300 | 300 |
|
| 301 | 301 |
func TestParseHost(t *testing.T) {
|
| 302 |
- if addr, err := ParseHost("127.0.0.1", 4243, "/var/run/docker.sock", "0.0.0.0"); err != nil || addr != "tcp://0.0.0.0:4243" {
|
|
| 302 |
+ var ( |
|
| 303 |
+ defaultHttpHost = "127.0.0.1" |
|
| 304 |
+ defaultHttpPort = 4243 |
|
| 305 |
+ defaultUnix = "/var/run/docker.sock" |
|
| 306 |
+ ) |
|
| 307 |
+ if addr, err := ParseHost(defaultHttpHost, defaultHttpPort, defaultUnix, "0.0.0.0"); err != nil || addr != "tcp://0.0.0.0:4243" {
|
|
| 303 | 308 |
t.Errorf("0.0.0.0 -> expected tcp://0.0.0.0:4243, got %s", addr)
|
| 304 | 309 |
} |
| 305 |
- if addr, err := ParseHost("127.0.0.1", 4243, "/var/run/docker.sock", "0.0.0.1:5555"); err != nil || addr != "tcp://0.0.0.1:5555" {
|
|
| 310 |
+ if addr, err := ParseHost(defaultHttpHost, defaultHttpPort, defaultUnix, "0.0.0.1:5555"); err != nil || addr != "tcp://0.0.0.1:5555" {
|
|
| 306 | 311 |
t.Errorf("0.0.0.1:5555 -> expected tcp://0.0.0.1:5555, got %s", addr)
|
| 307 | 312 |
} |
| 308 |
- if addr, err := ParseHost("127.0.0.1", 4243, "/var/run/docker.sock", ":6666"); err != nil || addr != "tcp://127.0.0.1:6666" {
|
|
| 313 |
+ if addr, err := ParseHost(defaultHttpHost, defaultHttpPort, defaultUnix, ":6666"); err != nil || addr != "tcp://127.0.0.1:6666" {
|
|
| 309 | 314 |
t.Errorf(":6666 -> expected tcp://127.0.0.1:6666, got %s", addr)
|
| 310 | 315 |
} |
| 311 |
- if addr, err := ParseHost("127.0.0.1", 4243, "/var/run/docker.sock", "tcp://:7777"); err != nil || addr != "tcp://127.0.0.1:7777" {
|
|
| 316 |
+ if addr, err := ParseHost(defaultHttpHost, defaultHttpPort, defaultUnix, "tcp://:7777"); err != nil || addr != "tcp://127.0.0.1:7777" {
|
|
| 312 | 317 |
t.Errorf("tcp://:7777 -> expected tcp://127.0.0.1:7777, got %s", addr)
|
| 313 | 318 |
} |
| 314 |
- if addr, err := ParseHost("127.0.0.1", 4243, "/var/run/docker.sock", "unix:///var/run/docker.sock"); err != nil || addr != "unix:///var/run/docker.sock" {
|
|
| 319 |
+ if addr, err := ParseHost(defaultHttpHost, defaultHttpPort, defaultUnix, "unix:///var/run/docker.sock"); err != nil || addr != "unix:///var/run/docker.sock" {
|
|
| 315 | 320 |
t.Errorf("unix:///var/run/docker.sock -> expected unix:///var/run/docker.sock, got %s", addr)
|
| 316 | 321 |
} |
| 317 |
- if addr, err := ParseHost("127.0.0.1", 4243, "/var/run/docker.sock", "unix://"); err != nil || addr != "unix:///var/run/docker.sock" {
|
|
| 322 |
+ if addr, err := ParseHost(defaultHttpHost, defaultHttpPort, defaultUnix, "unix://"); err != nil || addr != "unix:///var/run/docker.sock" {
|
|
| 318 | 323 |
t.Errorf("unix:///var/run/docker.sock -> expected unix:///var/run/docker.sock, got %s", addr)
|
| 319 | 324 |
} |
| 320 |
- if addr, err := ParseHost("127.0.0.1", 4243, "/var/run/docker.sock", "udp://127.0.0.1"); err == nil {
|
|
| 325 |
+ if addr, err := ParseHost(defaultHttpHost, defaultHttpPort, defaultUnix, "udp://127.0.0.1"); err == nil {
|
|
| 321 | 326 |
t.Errorf("udp protocol address expected error return, but err == nil. Got %s", addr)
|
| 322 | 327 |
} |
| 323 |
- if addr, err := ParseHost("127.0.0.1", 4243, "/var/run/docker.sock", "udp://127.0.0.1:4243"); err == nil {
|
|
| 328 |
+ if addr, err := ParseHost(defaultHttpHost, defaultHttpPort, defaultUnix, "udp://127.0.0.1:4243"); err == nil {
|
|
| 324 | 329 |
t.Errorf("udp protocol address expected error return, but err == nil. Got %s", addr)
|
| 325 | 330 |
} |
| 326 | 331 |
} |