Browse code

Windows: Remove linkmode internal hack

Signed-off-by: John Howard <jhoward@microsoft.com>

John Howard authored on 2016/01/14 09:27:53
Showing 3 changed files
... ...
@@ -234,10 +234,11 @@ RUN set -x \
234 234
 	&& rm -rf "$GOPATH"
235 235
 
236 236
 # Build/install the tool for embedding resources in Windows binaries
237
-ENV RSRC_VERSION v2
237
+ENV RSRC_COMMIT ba14da1f827188454a4591717fff29999010887f
238 238
 RUN set -x \
239 239
 	&& export GOPATH="$(mktemp -d)" \
240
-	&& git clone --depth 1 -b "$RSRC_VERSION" https://github.com/akavel/rsrc.git "$GOPATH/src/github.com/akavel/rsrc" \
240
+	&& git clone https://github.com/akavel/rsrc.git "$GOPATH/src/github.com/akavel/rsrc" \
241
+	&& (cd "$GOPATH/src/github.com/akavel/rsrc" && git checkout -q "$RSRC_COMMIT") \
241 242
 	&& go build -v -o /usr/local/bin/rsrc github.com/akavel/rsrc \
242 243
 	&& rm -rf "$GOPATH"
243 244
 
... ...
@@ -55,5 +55,12 @@ if [ "$(go env GOOS)" = 'windows' ]; then
55 55
 	rsrc \
56 56
 		-manifest hack/make/.resources-windows/docker.exe.manifest \
57 57
 		-ico      hack/make/.resources-windows/docker.ico \
58
-		-o        autogen/winresources/rsrc.syso > /dev/null
58
+		-arch     "amd64" \
59
+		-o        autogen/winresources/rsrc_amd64.syso > /dev/null
60
+
61
+	rsrc \
62
+		-manifest hack/make/.resources-windows/docker.exe.manifest \
63
+		-ico      hack/make/.resources-windows/docker.ico \
64
+		-arch     "386" \
65
+		-o        autogen/winresources/rsrc_386.syso > /dev/null
59 66
 fi
... ...
@@ -14,17 +14,10 @@ if [ "$(go env GOOS)/$(go env GOARCH)" != "$(go env GOHOSTOS)/$(go env GOHOSTARC
14 14
 		windows/amd64)
15 15
 			export CC=x86_64-w64-mingw32-gcc
16 16
 			export CGO_ENABLED=1
17
-			export LDFLAGS_STATIC_DOCKER="$LDFLAGS_STATIC_DOCKER -linkmode internal -extld=${CC}"
18 17
 			;;
19 18
 	esac
20 19
 fi
21 20
 
22
-if [ "$(go env GOHOSTOS)/$(go env GOHOSTARCH)" == "windows/amd64" ] && [ "$(go env GOOS)" == "windows" ]; then
23
-	# native compilation of Windows on Windows with golang 1.5+ needs linkmode internal
24
-	# https://github.com/golang/go/issues/13070
25
-	export LDFLAGS_STATIC_DOCKER="$LDFLAGS_STATIC_DOCKER -linkmode=internal"
26
-fi
27
-
28 21
 if [ "$(go env GOOS)" == "linux" ] ; then
29 22
 	case "$(go env GOARCH)" in
30 23
 		arm*|386)