Browse code

Update close fd issues for lxc

Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@docker.com> (github: crosbymichael)

Michael Crosby authored on 2014/06/20 03:57:09
Showing 2 changed files
... ...
@@ -19,7 +19,6 @@ import (
19 19
 	"github.com/docker/libcontainer/label"
20 20
 	"github.com/docker/libcontainer/mount/nodes"
21 21
 	"github.com/dotcloud/docker/daemon/execdriver"
22
-	"github.com/dotcloud/docker/pkg/system"
23 22
 	"github.com/dotcloud/docker/utils"
24 23
 )
25 24
 
... ...
@@ -37,12 +36,6 @@ func init() {
37 37
 		if err := setupNetworking(args); err != nil {
38 38
 			return err
39 39
 		}
40
-		if err := setupWorkingDirectory(args); err != nil {
41
-			return err
42
-		}
43
-		if err := system.CloseFdsFrom(3); err != nil {
44
-			return err
45
-		}
46 40
 		if err := finalizeNamespace(args); err != nil {
47 41
 			return err
48 42
 		}
... ...
@@ -8,6 +8,7 @@ import (
8 8
 
9 9
 	"github.com/docker/libcontainer/namespaces"
10 10
 	"github.com/docker/libcontainer/security/capabilities"
11
+	"github.com/docker/libcontainer/utils"
11 12
 	"github.com/dotcloud/docker/daemon/execdriver"
12 13
 	"github.com/dotcloud/docker/daemon/execdriver/native/template"
13 14
 	"github.com/dotcloud/docker/pkg/system"
... ...
@@ -18,6 +19,10 @@ func setHostname(hostname string) error {
18 18
 }
19 19
 
20 20
 func finalizeNamespace(args *execdriver.InitArgs) error {
21
+	if err := utils.CloseExecFrom(3); err != nil {
22
+		return err
23
+	}
24
+
21 25
 	// We use the native drivers default template so that things like caps are consistent
22 26
 	// across both drivers
23 27
 	container := template.New()
... ...
@@ -49,5 +54,9 @@ func finalizeNamespace(args *execdriver.InitArgs) error {
49 49
 		}
50 50
 	}
51 51
 
52
+	if err := setupWorkingDirectory(args); err != nil {
53
+		return err
54
+	}
55
+
52 56
 	return nil
53 57
 }