Names of tests are used as storage location for test-results, and using
a quote in the test-name resulted in CI failing to collect the results.
Commit 07a5e924ce0a1ae7f376b2932355e0a2c62c71b3 updated a grammar issue
in a sub-test, introducing a quote;
```patch
- t.Run("engine restart shouldnt kill alive containers", func(t *testing.T) {
+ t.Run("engine restart shouldn't kill alive containers", func(t *testing.T) {
```
Which caused CI to fail when collecting the files:
find bundles -path '*/root/*overlay2' -prune -o -type f \( -name '*-report.json' -o -name '*.log' -o -name '*.out' -o -name '*.prof' -o -name '*-report.xml' \) -print | xargs sudo tar -czf /tmp/reports.tar.gz
[...]
xargs: unmatched single quote; by default quotes are special to xargs unless you use the -0 option
We should make collecting reports less brittle, and probably consider
having some extra handling for the storage locations, but let's start
with changing this test name.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| ... | ... |
@@ -508,7 +508,7 @@ func testLiveRestoreAutoRemove(t *testing.T) {
|
| 508 | 508 |
return d, finishContainer, cID |
| 509 | 509 |
} |
| 510 | 510 |
|
| 511 |
- t.Run("engine restart shouldn't kill alive containers", func(t *testing.T) {
|
|
| 511 |
+ t.Run("engine restart should not kill alive containers", func(t *testing.T) {
|
|
| 512 | 512 |
d, finishContainer, cID := run(t) |
| 513 | 513 |
|
| 514 | 514 |
d.Restart(t, "--live-restore", "--iptables=false", "--ip6tables=false") |