Browse code

Cleaned up integration-cli/docker_api_network_test.go

Signed-off-by: Zachary Jaffee <zij@case.edu>

Zachary Jaffee authored on 2015/10/16 02:37:54
Showing 1 changed files
... ...
@@ -10,6 +10,7 @@ import (
10 10
 
11 11
 	"github.com/docker/docker/api/types"
12 12
 	"github.com/docker/docker/daemon/network"
13
+	"github.com/docker/docker/pkg/integration/checker"
13 14
 	"github.com/docker/docker/pkg/parsers/filters"
14 15
 	"github.com/go-check/check"
15 16
 )
... ...
@@ -18,7 +19,7 @@ func (s *DockerSuite) TestApiNetworkGetDefaults(c *check.C) {
18 18
 	// By default docker daemon creates 3 networks. check if they are present
19 19
 	defaults := []string{"bridge", "host", "none"}
20 20
 	for _, nn := range defaults {
21
-		c.Assert(isNetworkAvailable(c, nn), check.Equals, true)
21
+		c.Assert(isNetworkAvailable(c, nn), checker.Equals, true)
22 22
 	}
23 23
 }
24 24
 
... ...
@@ -30,25 +31,25 @@ func (s *DockerSuite) TestApiNetworkCreateDelete(c *check.C) {
30 30
 		CheckDuplicate: true,
31 31
 	}
32 32
 	id := createNetwork(c, config, true)
33
-	c.Assert(isNetworkAvailable(c, name), check.Equals, true)
33
+	c.Assert(isNetworkAvailable(c, name), checker.Equals, true)
34 34
 
35 35
 	// POST another network with same name and CheckDuplicate must fail
36 36
 	createNetwork(c, config, false)
37 37
 
38 38
 	// delete the network and make sure it is deleted
39 39
 	deleteNetwork(c, id, true)
40
-	c.Assert(isNetworkAvailable(c, name), check.Equals, false)
40
+	c.Assert(isNetworkAvailable(c, name), checker.Equals, false)
41 41
 }
42 42
 
43 43
 func (s *DockerSuite) TestApiNetworkFilter(c *check.C) {
44 44
 	nr := getNetworkResource(c, getNetworkIDByName(c, "bridge"))
45
-	c.Assert(nr.Name, check.Equals, "bridge")
45
+	c.Assert(nr.Name, checker.Equals, "bridge")
46 46
 }
47 47
 
48 48
 func (s *DockerSuite) TestApiNetworkInspect(c *check.C) {
49 49
 	// Inspect default bridge network
50 50
 	nr := getNetworkResource(c, "bridge")
51
-	c.Assert(nr.Name, check.Equals, "bridge")
51
+	c.Assert(nr.Name, checker.Equals, "bridge")
52 52
 
53 53
 	// run a container and attach it to the default bridge network
54 54
 	out, _ := dockerCmd(c, "run", "-d", "--name", "test", "busybox", "top")
... ...
@@ -57,15 +58,15 @@ func (s *DockerSuite) TestApiNetworkInspect(c *check.C) {
57 57
 
58 58
 	// inspect default bridge network again and make sure the container is connected
59 59
 	nr = getNetworkResource(c, nr.ID)
60
-	c.Assert(nr.Driver, check.Equals, "bridge")
61
-	c.Assert(nr.Scope, check.Equals, "local")
62
-	c.Assert(nr.IPAM.Driver, check.Equals, "default")
63
-	c.Assert(len(nr.Containers), check.Equals, 1)
64
-	c.Assert(nr.Containers[containerID], check.NotNil)
60
+	c.Assert(nr.Driver, checker.Equals, "bridge")
61
+	c.Assert(nr.Scope, checker.Equals, "local")
62
+	c.Assert(nr.IPAM.Driver, checker.Equals, "default")
63
+	c.Assert(len(nr.Containers), checker.Equals, 1)
64
+	c.Assert(nr.Containers[containerID], checker.NotNil)
65 65
 
66 66
 	ip, _, err := net.ParseCIDR(nr.Containers[containerID].IPv4Address)
67
-	c.Assert(err, check.IsNil)
68
-	c.Assert(ip.String(), check.Equals, containerIP)
67
+	c.Assert(err, checker.IsNil)
68
+	c.Assert(ip.String(), checker.Equals, containerIP)
69 69
 
70 70
 	// IPAM configuration inspect
71 71
 	ipam := network.IPAM{
... ...
@@ -78,16 +79,16 @@ func (s *DockerSuite) TestApiNetworkInspect(c *check.C) {
78 78
 		IPAM:   ipam,
79 79
 	}
80 80
 	id0 := createNetwork(c, config, true)
81
-	c.Assert(isNetworkAvailable(c, "br0"), check.Equals, true)
81
+	c.Assert(isNetworkAvailable(c, "br0"), checker.Equals, true)
82 82
 
83 83
 	nr = getNetworkResource(c, id0)
84
-	c.Assert(len(nr.IPAM.Config), check.Equals, 1)
85
-	c.Assert(nr.IPAM.Config[0].Subnet, check.Equals, "172.28.0.0/16")
86
-	c.Assert(nr.IPAM.Config[0].IPRange, check.Equals, "172.28.5.0/24")
87
-	c.Assert(nr.IPAM.Config[0].Gateway, check.Equals, "172.28.5.254")
84
+	c.Assert(len(nr.IPAM.Config), checker.Equals, 1)
85
+	c.Assert(nr.IPAM.Config[0].Subnet, checker.Equals, "172.28.0.0/16")
86
+	c.Assert(nr.IPAM.Config[0].IPRange, checker.Equals, "172.28.5.0/24")
87
+	c.Assert(nr.IPAM.Config[0].Gateway, checker.Equals, "172.28.5.254")
88 88
 	// delete the network and make sure it is deleted
89 89
 	deleteNetwork(c, id0, true)
90
-	c.Assert(isNetworkAvailable(c, "br0"), check.Equals, false)
90
+	c.Assert(isNetworkAvailable(c, "br0"), checker.Equals, false)
91 91
 }
92 92
 
93 93
 func (s *DockerSuite) TestApiNetworkConnectDisconnect(c *check.C) {
... ...
@@ -98,9 +99,9 @@ func (s *DockerSuite) TestApiNetworkConnectDisconnect(c *check.C) {
98 98
 	}
99 99
 	id := createNetwork(c, config, true)
100 100
 	nr := getNetworkResource(c, id)
101
-	c.Assert(nr.Name, check.Equals, name)
102
-	c.Assert(nr.ID, check.Equals, id)
103
-	c.Assert(len(nr.Containers), check.Equals, 0)
101
+	c.Assert(nr.Name, checker.Equals, name)
102
+	c.Assert(nr.ID, checker.Equals, id)
103
+	c.Assert(len(nr.Containers), checker.Equals, 0)
104 104
 
105 105
 	// run a container
106 106
 	out, _ := dockerCmd(c, "run", "-d", "--name", "test", "busybox", "top")
... ...
@@ -111,20 +112,20 @@ func (s *DockerSuite) TestApiNetworkConnectDisconnect(c *check.C) {
111 111
 
112 112
 	// inspect the network to make sure container is connected
113 113
 	nr = getNetworkResource(c, nr.ID)
114
-	c.Assert(len(nr.Containers), check.Equals, 1)
115
-	c.Assert(nr.Containers[containerID], check.NotNil)
114
+	c.Assert(len(nr.Containers), checker.Equals, 1)
115
+	c.Assert(nr.Containers[containerID], checker.NotNil)
116 116
 
117 117
 	// check if container IP matches network inspect
118 118
 	ip, _, err := net.ParseCIDR(nr.Containers[containerID].IPv4Address)
119
-	c.Assert(err, check.IsNil)
119
+	c.Assert(err, checker.IsNil)
120 120
 	containerIP := findContainerIP(c, "test")
121
-	c.Assert(ip.String(), check.Equals, containerIP)
121
+	c.Assert(ip.String(), checker.Equals, containerIP)
122 122
 
123 123
 	// disconnect container from the network
124 124
 	disconnectNetwork(c, nr.ID, containerID)
125 125
 	nr = getNetworkResource(c, nr.ID)
126
-	c.Assert(nr.Name, check.Equals, name)
127
-	c.Assert(len(nr.Containers), check.Equals, 0)
126
+	c.Assert(nr.Name, checker.Equals, name)
127
+	c.Assert(len(nr.Containers), checker.Equals, 0)
128 128
 
129 129
 	// delete the network
130 130
 	deleteNetwork(c, nr.ID, true)
... ...
@@ -142,7 +143,7 @@ func (s *DockerSuite) TestApiNetworkIpamMultipleBridgeNetworks(c *check.C) {
142 142
 		IPAM:   ipam0,
143 143
 	}
144 144
 	id0 := createNetwork(c, config0, true)
145
-	c.Assert(isNetworkAvailable(c, "test0"), check.Equals, true)
145
+	c.Assert(isNetworkAvailable(c, "test0"), checker.Equals, true)
146 146
 
147 147
 	ipam1 := network.IPAM{
148 148
 		Driver: "default",
... ...
@@ -155,7 +156,7 @@ func (s *DockerSuite) TestApiNetworkIpamMultipleBridgeNetworks(c *check.C) {
155 155
 		IPAM:   ipam1,
156 156
 	}
157 157
 	createNetwork(c, config1, false)
158
-	c.Assert(isNetworkAvailable(c, "test1"), check.Equals, false)
158
+	c.Assert(isNetworkAvailable(c, "test1"), checker.Equals, false)
159 159
 
160 160
 	ipam2 := network.IPAM{
161 161
 		Driver: "default",
... ...
@@ -168,20 +169,20 @@ func (s *DockerSuite) TestApiNetworkIpamMultipleBridgeNetworks(c *check.C) {
168 168
 		IPAM:   ipam2,
169 169
 	}
170 170
 	createNetwork(c, config2, true)
171
-	c.Assert(isNetworkAvailable(c, "test2"), check.Equals, true)
171
+	c.Assert(isNetworkAvailable(c, "test2"), checker.Equals, true)
172 172
 
173 173
 	// remove test0 and retry to create test1
174 174
 	deleteNetwork(c, id0, true)
175 175
 	createNetwork(c, config1, true)
176
-	c.Assert(isNetworkAvailable(c, "test1"), check.Equals, true)
176
+	c.Assert(isNetworkAvailable(c, "test1"), checker.Equals, true)
177 177
 
178 178
 	// for networks w/o ipam specified, docker will choose proper non-overlapping subnets
179 179
 	createNetwork(c, types.NetworkCreate{Name: "test3"}, true)
180
-	c.Assert(isNetworkAvailable(c, "test3"), check.Equals, true)
180
+	c.Assert(isNetworkAvailable(c, "test3"), checker.Equals, true)
181 181
 	createNetwork(c, types.NetworkCreate{Name: "test4"}, true)
182
-	c.Assert(isNetworkAvailable(c, "test4"), check.Equals, true)
182
+	c.Assert(isNetworkAvailable(c, "test4"), checker.Equals, true)
183 183
 	createNetwork(c, types.NetworkCreate{Name: "test5"}, true)
184
-	c.Assert(isNetworkAvailable(c, "test5"), check.Equals, true)
184
+	c.Assert(isNetworkAvailable(c, "test5"), checker.Equals, true)
185 185
 
186 186
 	for i := 1; i < 6; i++ {
187 187
 		deleteNetwork(c, fmt.Sprintf("test%d", i), true)
... ...
@@ -190,12 +191,12 @@ func (s *DockerSuite) TestApiNetworkIpamMultipleBridgeNetworks(c *check.C) {
190 190
 
191 191
 func isNetworkAvailable(c *check.C, name string) bool {
192 192
 	status, body, err := sockRequest("GET", "/networks", nil)
193
-	c.Assert(status, check.Equals, http.StatusOK)
194
-	c.Assert(err, check.IsNil)
193
+	c.Assert(status, checker.Equals, http.StatusOK)
194
+	c.Assert(err, checker.IsNil)
195 195
 
196 196
 	nJSON := []types.NetworkResource{}
197 197
 	err = json.Unmarshal(body, &nJSON)
198
-	c.Assert(err, check.IsNil)
198
+	c.Assert(err, checker.IsNil)
199 199
 
200 200
 	for _, n := range nJSON {
201 201
 		if n.Name == name {
... ...
@@ -212,28 +213,28 @@ func getNetworkIDByName(c *check.C, name string) string {
212 212
 	)
213 213
 	filterArgs["name"] = []string{name}
214 214
 	filterJSON, err := filters.ToParam(filterArgs)
215
-	c.Assert(err, check.IsNil)
215
+	c.Assert(err, checker.IsNil)
216 216
 	v.Set("filters", filterJSON)
217 217
 
218 218
 	status, body, err := sockRequest("GET", "/networks?"+v.Encode(), nil)
219
-	c.Assert(status, check.Equals, http.StatusOK)
220
-	c.Assert(err, check.IsNil)
219
+	c.Assert(status, checker.Equals, http.StatusOK)
220
+	c.Assert(err, checker.IsNil)
221 221
 
222 222
 	nJSON := []types.NetworkResource{}
223 223
 	err = json.Unmarshal(body, &nJSON)
224
-	c.Assert(err, check.IsNil)
225
-	c.Assert(len(nJSON), check.Equals, 1)
224
+	c.Assert(err, checker.IsNil)
225
+	c.Assert(len(nJSON), checker.Equals, 1)
226 226
 
227 227
 	return nJSON[0].ID
228 228
 }
229 229
 
230 230
 func getNetworkResource(c *check.C, id string) *types.NetworkResource {
231 231
 	_, obj, err := sockRequest("GET", "/networks/"+id, nil)
232
-	c.Assert(err, check.IsNil)
232
+	c.Assert(err, checker.IsNil)
233 233
 
234 234
 	nr := types.NetworkResource{}
235 235
 	err = json.Unmarshal(obj, &nr)
236
-	c.Assert(err, check.IsNil)
236
+	c.Assert(err, checker.IsNil)
237 237
 
238 238
 	return &nr
239 239
 }
... ...
@@ -241,16 +242,16 @@ func getNetworkResource(c *check.C, id string) *types.NetworkResource {
241 241
 func createNetwork(c *check.C, config types.NetworkCreate, shouldSucceed bool) string {
242 242
 	status, resp, err := sockRequest("POST", "/networks/create", config)
243 243
 	if !shouldSucceed {
244
-		c.Assert(status, check.Not(check.Equals), http.StatusCreated)
244
+		c.Assert(status, checker.Not(checker.Equals), http.StatusCreated)
245 245
 		return ""
246 246
 	}
247 247
 
248
-	c.Assert(status, check.Equals, http.StatusCreated)
249
-	c.Assert(err, check.IsNil)
248
+	c.Assert(status, checker.Equals, http.StatusCreated)
249
+	c.Assert(err, checker.IsNil)
250 250
 
251 251
 	var nr types.NetworkCreateResponse
252 252
 	err = json.Unmarshal(resp, &nr)
253
-	c.Assert(err, check.IsNil)
253
+	c.Assert(err, checker.IsNil)
254 254
 
255 255
 	return nr.ID
256 256
 }
... ...
@@ -261,8 +262,8 @@ func connectNetwork(c *check.C, nid, cid string) {
261 261
 	}
262 262
 
263 263
 	status, _, err := sockRequest("POST", "/networks/"+nid+"/connect", config)
264
-	c.Assert(status, check.Equals, http.StatusOK)
265
-	c.Assert(err, check.IsNil)
264
+	c.Assert(status, checker.Equals, http.StatusOK)
265
+	c.Assert(err, checker.IsNil)
266 266
 }
267 267
 
268 268
 func disconnectNetwork(c *check.C, nid, cid string) {
... ...
@@ -271,17 +272,17 @@ func disconnectNetwork(c *check.C, nid, cid string) {
271 271
 	}
272 272
 
273 273
 	status, _, err := sockRequest("POST", "/networks/"+nid+"/disconnect", config)
274
-	c.Assert(status, check.Equals, http.StatusOK)
275
-	c.Assert(err, check.IsNil)
274
+	c.Assert(status, checker.Equals, http.StatusOK)
275
+	c.Assert(err, checker.IsNil)
276 276
 }
277 277
 
278 278
 func deleteNetwork(c *check.C, id string, shouldSucceed bool) {
279 279
 	status, _, err := sockRequest("DELETE", "/networks/"+id, nil)
280 280
 	if !shouldSucceed {
281
-		c.Assert(status, check.Not(check.Equals), http.StatusOK)
282
-		c.Assert(err, check.NotNil)
281
+		c.Assert(status, checker.Not(checker.Equals), http.StatusOK)
282
+		c.Assert(err, checker.NotNil)
283 283
 		return
284 284
 	}
285
-	c.Assert(status, check.Equals, http.StatusOK)
286
-	c.Assert(err, check.IsNil)
285
+	c.Assert(status, checker.Equals, http.StatusOK)
286
+	c.Assert(err, checker.IsNil)
287 287
 }