Browse code

Fix flaky TestStackRemove test.

Signed-off-by: Daniel Nephin <dnephin@docker.com>

Daniel Nephin authored on 2017/03/25 04:31:08
Showing 2 changed files
... ...
@@ -11,6 +11,7 @@ import (
11 11
 
12 12
 	"github.com/docker/docker/api/types/swarm"
13 13
 	"github.com/docker/docker/integration-cli/checker"
14
+	icmd "github.com/docker/docker/pkg/testutil/cmd"
14 15
 	"github.com/go-check/check"
15 16
 )
16 17
 
... ...
@@ -111,18 +112,24 @@ func (s *DockerSwarmSuite) TestStackRemove(c *check.C) {
111 111
 		"--compose-file", "fixtures/deploy/remove.yaml",
112 112
 		stackName,
113 113
 	}
114
-	out, err := d.Cmd(stackArgs...)
115
-	c.Assert(err, checker.IsNil, check.Commentf(out))
116
-
117
-	out, err = d.Cmd("stack", "ps", stackName)
118
-	c.Assert(err, checker.IsNil)
119
-	c.Assert(strings.Split(strings.TrimSpace(out), "\n"), checker.HasLen, 2)
120
-
121
-	out, err = d.Cmd("stack", "rm", stackName)
122
-	c.Assert(err, checker.IsNil, check.Commentf(out))
123
-	c.Assert(out, checker.Contains, "Removing service testdeploy_web")
124
-	c.Assert(out, checker.Contains, "Removing network testdeploy_default")
125
-	c.Assert(out, checker.Contains, "Removing secret testdeploy_special")
114
+	result := icmd.RunCmd(d.Command(stackArgs...))
115
+	result.Assert(c, icmd.Expected{
116
+		Err: icmd.None,
117
+		Out: "Creating service testdeploy_web",
118
+	})
119
+
120
+	result = icmd.RunCmd(d.Command("service", "ls"))
121
+	result.Assert(c, icmd.Success)
122
+	c.Assert(
123
+		strings.Split(strings.TrimSpace(result.Stdout()), "\n"),
124
+		checker.HasLen, 2)
125
+
126
+	result = icmd.RunCmd(d.Command("stack", "rm", stackName))
127
+	result.Assert(c, icmd.Success)
128
+	stderr := result.Stderr()
129
+	c.Assert(stderr, checker.Contains, "Removing service testdeploy_web")
130
+	c.Assert(stderr, checker.Contains, "Removing network testdeploy_default")
131
+	c.Assert(stderr, checker.Contains, "Removing secret testdeploy_special")
126 132
 }
127 133
 
128 134
 type sortSecrets []swarm.SecretReference
... ...
@@ -2,7 +2,7 @@
2 2
 version: "3.1"
3 3
 services:
4 4
   web:
5
-    image: busybox@sha256:e4f93f6ed15a0cdd342f5aae387886fba0ab98af0a102da6276eaf24d6e6ade0
5
+    image: busybox:latest
6 6
     command: top
7 7
     secrets:
8 8
       - special