Browse code

Remove cluster storage advertise from reload.

Because libnetwork won't really send container information to the new
storage anyways.

Signed-off-by: David Calavera <david.calavera@gmail.com>

David Calavera authored on 2016/01/27 05:44:51
Showing 3 changed files
... ...
@@ -1538,13 +1538,12 @@ func (daemon *Daemon) initDiscovery(config *Config) error {
1538 1538
 // daemon according to those changes.
1539 1539
 // This are the settings that Reload changes:
1540 1540
 // - Daemon labels.
1541
-// - Cluster discovery (reconfigure and restart).
1542 1541
 func (daemon *Daemon) Reload(config *Config) error {
1543 1542
 	daemon.configStore.reloadLock.Lock()
1544
-	defer daemon.configStore.reloadLock.Unlock()
1545
-
1546 1543
 	daemon.configStore.Labels = config.Labels
1547
-	return daemon.reloadClusterDiscovery(config)
1544
+	daemon.configStore.reloadLock.Unlock()
1545
+
1546
+	return nil
1548 1547
 }
1549 1548
 
1550 1549
 func (daemon *Daemon) reloadClusterDiscovery(config *Config) error {
... ...
@@ -437,7 +437,7 @@ func TestDaemonDiscoveryReload(t *testing.T) {
437 437
 		&discovery.Entry{Host: "127.0.0.1", Port: "5555"},
438 438
 	}
439 439
 
440
-	if err := daemon.Reload(newConfig); err != nil {
440
+	if err := daemon.reloadClusterDiscovery(newConfig); err != nil {
441 441
 		t.Fatal(err)
442 442
 	}
443 443
 	ch, errCh = daemon.discoveryWatcher.Watch(stopCh)
... ...
@@ -469,7 +469,7 @@ func TestDaemonDiscoveryReloadFromEmptyDiscovery(t *testing.T) {
469 469
 		&discovery.Entry{Host: "127.0.0.1", Port: "5555"},
470 470
 	}
471 471
 
472
-	if err := daemon.Reload(newConfig); err != nil {
472
+	if err := daemon.reloadClusterDiscovery(newConfig); err != nil {
473 473
 		t.Fatal(err)
474 474
 	}
475 475
 	stopCh := make(chan struct{})
... ...
@@ -888,7 +888,4 @@ if there are conflicts, but it won't stop execution.
888 888
 The list of currently supported options that can be reconfigured is this:
889 889
 
890 890
 - `debug`: it changes the daemon to debug mode when set to true.
891
-- `label`: it replaces the daemon labels with a new set of labels.
892
-- `cluster-store`: it reloads the discovery store with the new address.
893
-- `cluster-store-opts`: it uses the new options to reload the discovery store.
894
-- `cluster-advertise`: it modifies the address advertised after reloading.
891
+- `labels`: it replaces the daemon labels with a new set of labels.