Browse code

Merge pull request #21634 from cpuguy83/add_beter_logging_for_TestDaemonNoSpaceleftOnDeviceError

More logs for `TestDaemonNoSpaceleftOnDeviceError`

Vincent Demeester authored on 2016/04/15 05:06:49
Showing 1 changed files
... ...
@@ -1914,27 +1914,28 @@ func (s *DockerDaemonSuite) TestDaemonNoSpaceleftOnDeviceError(c *check.C) {
1914 1914
 
1915 1915
 	// create a 2MiB image and mount it as graph root
1916 1916
 	cmd := exec.Command("dd", "of=/tmp/testfs.img", "bs=1M", "seek=2", "count=0")
1917
-	if err := cmd.Run(); err != nil {
1918
-		c.Fatalf("dd failed: %v", err)
1919
-	}
1917
+	out, err := cmd.CombinedOutput()
1918
+	c.Assert(err, checker.IsNil, check.Commentf(string(out)))
1919
+
1920 1920
 	cmd = exec.Command("mkfs.ext4", "-F", "/tmp/testfs.img")
1921
-	if err := cmd.Run(); err != nil {
1922
-		c.Fatalf("mkfs.ext4 failed: %v", err)
1923
-	}
1921
+	out, err = cmd.CombinedOutput()
1922
+	c.Assert(err, checker.IsNil, check.Commentf(string(out)))
1923
+
1924 1924
 	cmd = exec.Command("mkdir", "-p", "/tmp/testfs-mount")
1925
-	if err := cmd.Run(); err != nil {
1926
-		c.Fatalf("mkdir failed: %v", err)
1927
-	}
1925
+	out, err = cmd.CombinedOutput()
1926
+	c.Assert(err, checker.IsNil, check.Commentf(string(out)))
1927
+
1928 1928
 	cmd = exec.Command("mount", "-t", "ext4", "-no", "loop,rw", "/tmp/testfs.img", "/tmp/testfs-mount")
1929
-	if err := cmd.Run(); err != nil {
1930
-		c.Fatalf("mount failed: %v", err)
1931
-	}
1932
-	err := s.d.Start("--graph", "/tmp/testfs-mount")
1929
+	out, err = cmd.CombinedOutput()
1930
+	c.Assert(err, checker.IsNil, check.Commentf(string(out)))
1931
+
1932
+	err = s.d.Start("--graph", "/tmp/testfs-mount")
1933 1933
 	c.Assert(err, check.IsNil)
1934 1934
 
1935 1935
 	// pull a repository large enough to fill the mount point
1936
-	out, err := s.d.Cmd("pull", "registry:2")
1937
-	c.Assert(out, checker.Contains, "no space left on device")
1936
+	pullOut, err := s.d.Cmd("pull", "registry:2")
1937
+	c.Assert(err, checker.NotNil, check.Commentf(pullOut))
1938
+	c.Assert(pullOut, checker.Contains, "no space left on device")
1938 1939
 }
1939 1940
 
1940 1941
 // Test daemon restart with container links + auto restart