Browse code

Stop running symlink-volume tests on Windows

Signed-off-by: Darren Stahl <darst@microsoft.com>

Darren Stahl authored on 2016/04/06 05:21:20
Showing 1 changed files
... ...
@@ -359,7 +359,9 @@ func (s *DockerSuite) TestRunCreateVolumesInSymlinkDir(c *check.C) {
359 359
 		containerPath string
360 360
 		cmd           string
361 361
 	)
362
-	testRequires(c, SameHostDaemon)
362
+	// TODO Windows (Post TP5): This test cannot run on a Windows daemon as
363
+	// Windows does not support symlinks inside a volume path
364
+	testRequires(c, SameHostDaemon, DaemonIsLinux)
363 365
 	name := "test-volume-symlink"
364 366
 
365 367
 	dir, err := ioutil.TempDir("", name)
... ...
@@ -404,7 +406,9 @@ func (s *DockerSuite) TestRunCreateVolumesInSymlinkDir2(c *check.C) {
404 404
 		containerPath string
405 405
 		cmd           string
406 406
 	)
407
-	testRequires(c, SameHostDaemon)
407
+	// TODO Windows (Post TP5): This test cannot run on a Windows daemon as
408
+	// Windows does not support symlinks inside a volume path
409
+	testRequires(c, SameHostDaemon, DaemonIsLinux)
408 410
 	name := "test-volume-symlink2"
409 411
 
410 412
 	if daemonPlatform == "windows" {
... ...
@@ -614,6 +618,9 @@ func (s *DockerSuite) TestRunCreateVolumeWithSymlink(c *check.C) {
614 614
 
615 615
 // Tests that a volume path that has a symlink exists in a container mounting it with `--volumes-from`.
616 616
 func (s *DockerSuite) TestRunVolumesFromSymlinkPath(c *check.C) {
617
+	// TODO Windows (Post TP5): This test cannot run on a Windows daemon as
618
+	// Windows does not support symlinks inside a volume path
619
+	testRequires(c, DaemonIsLinux)
617 620
 	name := "docker-test-volumesfromsymlinkpath"
618 621
 	prefix := ""
619 622
 	dfContents := `FROM busybox