Tests generally already have a client instance, so it
probably makes more sense to just pass it, and make
this utility a bit more flexible to use.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| ... | ... |
@@ -269,7 +269,7 @@ func TestTemplatedConfig(t *testing.T) {
|
| 269 | 269 |
|
| 270 | 270 |
var tasks []swarmtypes.Task |
| 271 | 271 |
waitAndAssert(t, 60*time.Second, func(t *testing.T) bool {
|
| 272 |
- tasks = swarm.GetRunningTasks(t, d, serviceID) |
|
| 272 |
+ tasks = swarm.GetRunningTasks(t, client, serviceID) |
|
| 273 | 273 |
return len(tasks) > 0 |
| 274 | 274 |
}) |
| 275 | 275 |
|
| ... | ... |
@@ -9,6 +9,7 @@ import ( |
| 9 | 9 |
"github.com/docker/docker/api/types" |
| 10 | 10 |
"github.com/docker/docker/api/types/filters" |
| 11 | 11 |
swarmtypes "github.com/docker/docker/api/types/swarm" |
| 12 |
+ "github.com/docker/docker/client" |
|
| 12 | 13 |
"github.com/docker/docker/internal/test/daemon" |
| 13 | 14 |
"github.com/docker/docker/internal/test/environment" |
| 14 | 15 |
"gotest.tools/assert" |
| ... | ... |
@@ -180,19 +181,16 @@ func ServiceWithSysctls(sysctls map[string]string) ServiceSpecOpt {
|
| 180 | 180 |
} |
| 181 | 181 |
|
| 182 | 182 |
// GetRunningTasks gets the list of running tasks for a service |
| 183 |
-func GetRunningTasks(t *testing.T, d *daemon.Daemon, serviceID string) []swarmtypes.Task {
|
|
| 183 |
+func GetRunningTasks(t *testing.T, c client.ServiceAPIClient, serviceID string) []swarmtypes.Task {
|
|
| 184 | 184 |
t.Helper() |
| 185 |
- client := d.NewClientT(t) |
|
| 186 |
- defer client.Close() |
|
| 187 | 185 |
|
| 188 |
- filterArgs := filters.NewArgs() |
|
| 189 |
- filterArgs.Add("desired-state", "running")
|
|
| 190 |
- filterArgs.Add("service", serviceID)
|
|
| 186 |
+ tasks, err := c.TaskList(context.Background(), types.TaskListOptions{
|
|
| 187 |
+ Filters: filters.NewArgs( |
|
| 188 |
+ filters.Arg("service", serviceID),
|
|
| 189 |
+ filters.Arg("desired-state", "running"),
|
|
| 190 |
+ ), |
|
| 191 |
+ }) |
|
| 191 | 192 |
|
| 192 |
- options := types.TaskListOptions{
|
|
| 193 |
- Filters: filterArgs, |
|
| 194 |
- } |
|
| 195 |
- tasks, err := client.TaskList(context.Background(), options) |
|
| 196 | 193 |
assert.NilError(t, err) |
| 197 | 194 |
return tasks |
| 198 | 195 |
} |
| ... | ... |
@@ -303,7 +303,7 @@ func TestTemplatedSecret(t *testing.T) {
|
| 303 | 303 |
|
| 304 | 304 |
var tasks []swarmtypes.Task |
| 305 | 305 |
waitAndAssert(t, 60*time.Second, func(t *testing.T) bool {
|
| 306 |
- tasks = swarm.GetRunningTasks(t, d, serviceID) |
|
| 306 |
+ tasks = swarm.GetRunningTasks(t, client, serviceID) |
|
| 307 | 307 |
return len(tasks) > 0 |
| 308 | 308 |
}) |
| 309 | 309 |
|