sed -E -i 's#\bassert\.Assert\(c, (.*), checker\.Not\(checker\.Equals\), (.*)#assert.Assert(c, \1 != \2#g' \
-- "integration-cli/docker_api_containers_test.go" "integration-cli/docker_cli_build_test.go" "integration-cli/docker_cli_build_unix_test.go" "integration-cli/docker_cli_by_digest_test.go" "integration-cli/docker_cli_create_test.go" "integration-cli/docker_cli_daemon_test.go" "integration-cli/docker_cli_inspect_test.go" "integration-cli/docker_cli_network_unix_test.go" "integration-cli/docker_cli_prune_unix_test.go" "integration-cli/docker_cli_ps_test.go" "integration-cli/docker_cli_run_test.go" "integration-cli/docker_cli_save_load_test.go" "integration-cli/docker_cli_service_create_test.go" "integration-cli/docker_cli_swarm_test.go" "integration-cli/docker_cli_volume_test.go"
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 0fa116fa8f39117fab069110ff6d5887831420b3)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| ... | ... |
@@ -668,7 +668,7 @@ func (s *DockerSuite) TestContainerAPIVerifyHeader(c *testing.T) {
|
| 668 | 668 |
if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
|
| 669 | 669 |
assert.Equal(c, res.StatusCode, http.StatusBadRequest) |
| 670 | 670 |
} else {
|
| 671 |
- assert.Assert(c, res.StatusCode, checker.Not(checker.Equals), http.StatusOK) |
|
| 671 |
+ assert.Assert(c, res.StatusCode != http.StatusOK) |
|
| 672 | 672 |
} |
| 673 | 673 |
body.Close() |
| 674 | 674 |
|
| ... | ... |
@@ -678,7 +678,7 @@ func (s *DockerSuite) TestContainerAPIVerifyHeader(c *testing.T) {
|
| 678 | 678 |
if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
|
| 679 | 679 |
assert.Equal(c, res.StatusCode, http.StatusBadRequest) |
| 680 | 680 |
} else {
|
| 681 |
- assert.Assert(c, res.StatusCode, checker.Not(checker.Equals), http.StatusOK) |
|
| 681 |
+ assert.Assert(c, res.StatusCode != http.StatusOK) |
|
| 682 | 682 |
} |
| 683 | 683 |
body.Close() |
| 684 | 684 |
|
| ... | ... |
@@ -708,7 +708,7 @@ func (s *DockerSuite) TestContainerAPIInvalidPortSyntax(c *testing.T) {
|
| 708 | 708 |
if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
|
| 709 | 709 |
assert.Equal(c, res.StatusCode, http.StatusBadRequest) |
| 710 | 710 |
} else {
|
| 711 |
- assert.Assert(c, res.StatusCode, checker.Not(checker.Equals), http.StatusOK) |
|
| 711 |
+ assert.Assert(c, res.StatusCode != http.StatusOK) |
|
| 712 | 712 |
} |
| 713 | 713 |
|
| 714 | 714 |
b, err := request.ReadBody(body) |
| ... | ... |
@@ -732,7 +732,7 @@ func (s *DockerSuite) TestContainerAPIRestartPolicyInvalidPolicyName(c *testing. |
| 732 | 732 |
if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
|
| 733 | 733 |
assert.Equal(c, res.StatusCode, http.StatusBadRequest) |
| 734 | 734 |
} else {
|
| 735 |
- assert.Assert(c, res.StatusCode, checker.Not(checker.Equals), http.StatusOK) |
|
| 735 |
+ assert.Assert(c, res.StatusCode != http.StatusOK) |
|
| 736 | 736 |
} |
| 737 | 737 |
|
| 738 | 738 |
b, err := request.ReadBody(body) |
| ... | ... |
@@ -756,7 +756,7 @@ func (s *DockerSuite) TestContainerAPIRestartPolicyRetryMismatch(c *testing.T) {
|
| 756 | 756 |
if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
|
| 757 | 757 |
assert.Equal(c, res.StatusCode, http.StatusBadRequest) |
| 758 | 758 |
} else {
|
| 759 |
- assert.Assert(c, res.StatusCode, checker.Not(checker.Equals), http.StatusOK) |
|
| 759 |
+ assert.Assert(c, res.StatusCode != http.StatusOK) |
|
| 760 | 760 |
} |
| 761 | 761 |
|
| 762 | 762 |
b, err := request.ReadBody(body) |
| ... | ... |
@@ -780,7 +780,7 @@ func (s *DockerSuite) TestContainerAPIRestartPolicyNegativeRetryCount(c *testing |
| 780 | 780 |
if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
|
| 781 | 781 |
assert.Equal(c, res.StatusCode, http.StatusBadRequest) |
| 782 | 782 |
} else {
|
| 783 |
- assert.Assert(c, res.StatusCode, checker.Not(checker.Equals), http.StatusOK) |
|
| 783 |
+ assert.Assert(c, res.StatusCode != http.StatusOK) |
|
| 784 | 784 |
} |
| 785 | 785 |
|
| 786 | 786 |
b, err := request.ReadBody(body) |
| ... | ... |
@@ -869,7 +869,7 @@ func (s *DockerSuite) TestCreateWithTooLowMemoryLimit(c *testing.T) {
|
| 869 | 869 |
if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
|
| 870 | 870 |
assert.Equal(c, res.StatusCode, http.StatusBadRequest) |
| 871 | 871 |
} else {
|
| 872 |
- assert.Assert(c, res.StatusCode, checker.Not(checker.Equals), http.StatusOK) |
|
| 872 |
+ assert.Assert(c, res.StatusCode != http.StatusOK) |
|
| 873 | 873 |
} |
| 874 | 874 |
assert.Assert(c, string(b), checker.Contains, "Minimum memory limit allowed is 4MB") |
| 875 | 875 |
} |
| ... | ... |
@@ -1061,7 +1061,7 @@ func (s *DockerSuite) TestContainerAPICopyResourcePathEmptyPre124(c *testing.T) |
| 1061 | 1061 |
if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
|
| 1062 | 1062 |
assert.Equal(c, res.StatusCode, http.StatusBadRequest) |
| 1063 | 1063 |
} else {
|
| 1064 |
- assert.Assert(c, res.StatusCode, checker.Not(checker.Equals), http.StatusOK) |
|
| 1064 |
+ assert.Assert(c, res.StatusCode != http.StatusOK) |
|
| 1065 | 1065 |
} |
| 1066 | 1066 |
b, err := request.ReadBody(body) |
| 1067 | 1067 |
assert.NilError(c, err) |
| ... | ... |
@@ -5457,7 +5457,7 @@ func (s *DockerSuite) TestBuildCacheFrom(c *testing.T) {
|
| 5457 | 5457 |
// no cache match with unknown source |
| 5458 | 5458 |
result = cli.BuildCmd(c, "build2", cli.WithFlags("--cache-from=nosuchtag"), build.WithExternalBuildContext(ctx))
|
| 5459 | 5459 |
id2 = getIDByName(c, "build2") |
| 5460 |
- assert.Assert(c, id1, checker.Not(checker.Equals), id2) |
|
| 5460 |
+ assert.Assert(c, id1 != id2) |
|
| 5461 | 5461 |
assert.Assert(c, strings.Count(result.Combined(), "Using cache"), checker.Equals, 0) |
| 5462 | 5462 |
cli.DockerCmd(c, "rmi", "build2") |
| 5463 | 5463 |
|
| ... | ... |
@@ -5505,7 +5505,7 @@ func (s *DockerSuite) TestBuildCacheFrom(c *testing.T) {
|
| 5505 | 5505 |
|
| 5506 | 5506 |
result = cli.BuildCmd(c, "build2", cli.WithFlags("--cache-from=build1"), build.WithExternalBuildContext(ctx))
|
| 5507 | 5507 |
id2 = getIDByName(c, "build2") |
| 5508 |
- assert.Assert(c, id1, checker.Not(checker.Equals), id2) |
|
| 5508 |
+ assert.Assert(c, id1 != id2) |
|
| 5509 | 5509 |
assert.Assert(c, strings.Count(result.Combined(), "Using cache"), checker.Equals, 2) |
| 5510 | 5510 |
|
| 5511 | 5511 |
layers1Str := cli.DockerCmd(c, "inspect", "-f", "{{json .RootFS.Layers}}", "build1").Combined()
|
| ... | ... |
@@ -5520,7 +5520,7 @@ func (s *DockerSuite) TestBuildCacheFrom(c *testing.T) {
|
| 5520 | 5520 |
for i := 0; i < len(layers1)-1; i++ {
|
| 5521 | 5521 |
assert.Assert(c, layers1[i], checker.Equals, layers2[i]) |
| 5522 | 5522 |
} |
| 5523 |
- assert.Assert(c, layers1[len(layers1)-1], checker.Not(checker.Equals), layers2[len(layers1)-1]) |
|
| 5523 |
+ assert.Assert(c, layers1[len(layers1)-1] != layers2[len(layers1)-1]) |
|
| 5524 | 5524 |
} |
| 5525 | 5525 |
|
| 5526 | 5526 |
func (s *DockerSuite) TestBuildMultiStageCache(c *testing.T) {
|
| ... | ... |
@@ -76,12 +76,12 @@ func (s *DockerSuite) TestBuildResourceConstraintsAreUsed(c *testing.T) {
|
| 76 | 76 |
err = json.Unmarshal([]byte(cfg), &c2) |
| 77 | 77 |
assert.Assert(c, err, checker.IsNil, check.Commentf(cfg)) |
| 78 | 78 |
|
| 79 |
- assert.Assert(c, c2.Memory, checker.Not(checker.Equals), int64(64*1024*1024), check.Commentf("resource leaked from build for Memory"))
|
|
| 80 |
- assert.Assert(c, c2.MemorySwap, checker.Not(checker.Equals), int64(-1), check.Commentf("resource leaked from build for MemorySwap"))
|
|
| 81 |
- assert.Assert(c, c2.CpusetCpus, checker.Not(checker.Equals), "0", check.Commentf("resource leaked from build for CpusetCpus"))
|
|
| 82 |
- assert.Assert(c, c2.CpusetMems, checker.Not(checker.Equals), "0", check.Commentf("resource leaked from build for CpusetMems"))
|
|
| 83 |
- assert.Assert(c, c2.CPUShares, checker.Not(checker.Equals), int64(100), check.Commentf("resource leaked from build for CPUShares"))
|
|
| 84 |
- assert.Assert(c, c2.CPUQuota, checker.Not(checker.Equals), int64(8000), check.Commentf("resource leaked from build for CPUQuota"))
|
|
| 79 |
+ assert.Assert(c, c2.Memory != int64(64*1024*1024), check.Commentf("resource leaked from build for Memory"))
|
|
| 80 |
+ assert.Assert(c, c2.MemorySwap != int64(-1), check.Commentf("resource leaked from build for MemorySwap"))
|
|
| 81 |
+ assert.Assert(c, c2.CpusetCpus != "0", check.Commentf("resource leaked from build for CpusetCpus"))
|
|
| 82 |
+ assert.Assert(c, c2.CpusetMems != "0", check.Commentf("resource leaked from build for CpusetMems"))
|
|
| 83 |
+ assert.Assert(c, c2.CPUShares != int64(100), check.Commentf("resource leaked from build for CPUShares"))
|
|
| 84 |
+ assert.Assert(c, c2.CPUQuota != int64(8000), check.Commentf("resource leaked from build for CPUQuota"))
|
|
| 85 | 85 |
assert.Assert(c, c2.Ulimits, checker.IsNil, check.Commentf("resource leaked from build for Ulimits"))
|
| 86 | 86 |
} |
| 87 | 87 |
|
| ... | ... |
@@ -556,7 +556,7 @@ func (s *DockerRegistrySuite) TestPullFailsWithAlteredManifest(c *testing.T) {
|
| 556 | 556 |
// Pull from the registry using the <name>@<digest> reference. |
| 557 | 557 |
imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
|
| 558 | 558 |
out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
|
| 559 |
- assert.Assert(c, exitStatus, checker.Not(checker.Equals), 0) |
|
| 559 |
+ assert.Assert(c, exitStatus != 0) |
|
| 560 | 560 |
|
| 561 | 561 |
expectedErrorMsg := fmt.Sprintf("manifest verification failed for digest %s", manifestDigest)
|
| 562 | 562 |
assert.Assert(c, is.Contains(out, expectedErrorMsg)) |
| ... | ... |
@@ -598,7 +598,7 @@ func (s *DockerSchema1RegistrySuite) TestPullFailsWithAlteredManifest(c *testing |
| 598 | 598 |
// Pull from the registry using the <name>@<digest> reference. |
| 599 | 599 |
imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
|
| 600 | 600 |
out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
|
| 601 |
- assert.Assert(c, exitStatus, checker.Not(checker.Equals), 0) |
|
| 601 |
+ assert.Assert(c, exitStatus != 0) |
|
| 602 | 602 |
|
| 603 | 603 |
expectedErrorMsg := fmt.Sprintf("image verification failed for digest %s", manifestDigest)
|
| 604 | 604 |
assert.Assert(c, out, checker.Contains, expectedErrorMsg) |
| ... | ... |
@@ -641,7 +641,7 @@ func (s *DockerRegistrySuite) TestPullFailsWithAlteredLayer(c *testing.T) {
|
| 641 | 641 |
// Pull from the registry using the <name>@<digest> reference. |
| 642 | 642 |
imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
|
| 643 | 643 |
out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
|
| 644 |
- assert.Assert(c, exitStatus, checker.Not(checker.Equals), 0, check.Commentf("expected a non-zero exit status"))
|
|
| 644 |
+ assert.Assert(c, exitStatus != 0, check.Commentf("expected a non-zero exit status"))
|
|
| 645 | 645 |
|
| 646 | 646 |
expectedErrorMsg := fmt.Sprintf("filesystem layer verification failed for digest %s", targetLayerDigest)
|
| 647 | 647 |
assert.Assert(c, out, checker.Contains, expectedErrorMsg, check.Commentf("expected error message in output: %s", out))
|
| ... | ... |
@@ -684,7 +684,7 @@ func (s *DockerSchema1RegistrySuite) TestPullFailsWithAlteredLayer(c *testing.T) |
| 684 | 684 |
// Pull from the registry using the <name>@<digest> reference. |
| 685 | 685 |
imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
|
| 686 | 686 |
out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
|
| 687 |
- assert.Assert(c, exitStatus, checker.Not(checker.Equals), 0, check.Commentf("expected a non-zero exit status"))
|
|
| 687 |
+ assert.Assert(c, exitStatus != 0, check.Commentf("expected a non-zero exit status"))
|
|
| 688 | 688 |
|
| 689 | 689 |
expectedErrorMsg := fmt.Sprintf("filesystem layer verification failed for digest %s", targetLayerDigest)
|
| 690 | 690 |
assert.Assert(c, out, checker.Contains, expectedErrorMsg, check.Commentf("expected error message in output: %s", out))
|
| ... | ... |
@@ -362,7 +362,7 @@ exec "$@"`, |
| 362 | 362 |
|
| 363 | 363 |
out := cli.DockerCmd(c, "create", "--entrypoint=", name, "echo", "foo").Combined() |
| 364 | 364 |
id := strings.TrimSpace(out) |
| 365 |
- assert.Assert(c, id, checker.Not(checker.Equals), "") |
|
| 365 |
+ assert.Assert(c, id != "") |
|
| 366 | 366 |
out = cli.DockerCmd(c, "start", "-a", id).Combined() |
| 367 | 367 |
assert.Assert(c, strings.TrimSpace(out), checker.Equals, "foo") |
| 368 | 368 |
} |
| ... | ... |
@@ -1751,7 +1751,7 @@ func (s *DockerDaemonSuite) TestBridgeIPIsExcludedFromAllocatorPool(c *testing.T |
| 1751 | 1751 |
ip, err := s.d.Cmd("inspect", "--format", "'{{.NetworkSettings.IPAddress}}'", contName)
|
| 1752 | 1752 |
assert.Assert(c, err, checker.IsNil, check.Commentf("%s", ip))
|
| 1753 | 1753 |
|
| 1754 |
- assert.Assert(c, ip, checker.Not(checker.Equals), bridgeIP) |
|
| 1754 |
+ assert.Assert(c, ip != bridgeIP) |
|
| 1755 | 1755 |
cont++ |
| 1756 | 1756 |
} |
| 1757 | 1757 |
} |
| ... | ... |
@@ -1854,7 +1854,7 @@ func (s *DockerDaemonSuite) TestDaemonCgroupParent(c *testing.T) {
|
| 1854 | 1854 |
out, err := s.d.Cmd("run", "--name", name, "busybox", "cat", "/proc/self/cgroup")
|
| 1855 | 1855 |
assert.NilError(c, err) |
| 1856 | 1856 |
cgroupPaths := ParseCgroupPaths(string(out)) |
| 1857 |
- assert.Assert(c, len(cgroupPaths), checker.Not(checker.Equals), 0, check.Commentf("unexpected output - %q", string(out)))
|
|
| 1857 |
+ assert.Assert(c, len(cgroupPaths) != 0, check.Commentf("unexpected output - %q", string(out)))
|
|
| 1858 | 1858 |
out, err = s.d.Cmd("inspect", "-f", "{{.Id}}", name)
|
| 1859 | 1859 |
assert.NilError(c, err) |
| 1860 | 1860 |
id := strings.TrimSpace(string(out)) |
| ... | ... |
@@ -2166,7 +2166,7 @@ func (s *DockerDaemonSuite) TestDaemonStartWithoutColors(c *testing.T) {
|
| 2166 | 2166 |
s.d.Stop(c) |
| 2167 | 2167 |
// Wait for io.Copy() before checking output |
| 2168 | 2168 |
<-done |
| 2169 |
- assert.Assert(c, b.String(), checker.Not(checker.Equals), "") |
|
| 2169 |
+ assert.Assert(c, b.String() != "") |
|
| 2170 | 2170 |
assert.Assert(c, b.String(), checker.Not(checker.Contains), infoLog) |
| 2171 | 2171 |
} |
| 2172 | 2172 |
|
| ... | ... |
@@ -194,7 +194,7 @@ func (s *DockerSuite) TestInspectContainerGraphDriver(c *testing.T) {
|
| 194 | 194 |
|
| 195 | 195 |
deviceID := inspectField(c, out, "GraphDriver.Data.DeviceId") |
| 196 | 196 |
|
| 197 |
- assert.Assert(c, imageDeviceID, checker.Not(checker.Equals), deviceID) |
|
| 197 |
+ assert.Assert(c, imageDeviceID != deviceID) |
|
| 198 | 198 |
|
| 199 | 199 |
_, err := strconv.Atoi(deviceID) |
| 200 | 200 |
assert.Assert(c, err, checker.IsNil, check.Commentf("failed to inspect DeviceId of the image: %s, %v", deviceID, err))
|
| ... | ... |
@@ -255,7 +255,7 @@ func (s *DockerSuite) TestInspectNamedMountPoint(c *testing.T) {
|
| 255 | 255 |
|
| 256 | 256 |
assert.Assert(c, m.Name, checker.Equals, "data") |
| 257 | 257 |
assert.Assert(c, m.Driver, checker.Equals, "local") |
| 258 |
- assert.Assert(c, m.Source, checker.Not(checker.Equals), "") |
|
| 258 |
+ assert.Assert(c, m.Source != "") |
|
| 259 | 259 |
assert.Assert(c, m.Destination, checker.Equals, prefix+slash+"data") |
| 260 | 260 |
assert.Assert(c, m.RW, checker.Equals, true) |
| 261 | 261 |
} |
| ... | ... |
@@ -314,8 +314,8 @@ func (s *DockerSuite) TestInspectSizeFlagContainer(c *testing.T) {
|
| 314 | 314 |
out, _ := dockerCmd(c, "inspect", "-s", "--type=container", formatStr, "busybox") |
| 315 | 315 |
sz := strings.Split(out, ",") |
| 316 | 316 |
|
| 317 |
- assert.Assert(c, strings.TrimSpace(sz[0]), checker.Not(checker.Equals), "<nil>") |
|
| 318 |
- assert.Assert(c, strings.TrimSpace(sz[1]), checker.Not(checker.Equals), "<nil>") |
|
| 317 |
+ assert.Assert(c, strings.TrimSpace(sz[0]) != "<nil>") |
|
| 318 |
+ assert.Assert(c, strings.TrimSpace(sz[1]) != "<nil>") |
|
| 319 | 319 |
} |
| 320 | 320 |
|
| 321 | 321 |
func (s *DockerSuite) TestInspectTemplateError(c *testing.T) {
|
| ... | ... |
@@ -1060,7 +1060,7 @@ func verifyContainerIsConnectedToNetworks(c *testing.T, d *daemon.Daemon, cName |
| 1060 | 1060 |
for _, nw := range nws {
|
| 1061 | 1061 |
out, err := d.Cmd("inspect", "-f", fmt.Sprintf("{{.NetworkSettings.Networks.%s}}", nw), cName)
|
| 1062 | 1062 |
assert.NilError(c, err, out) |
| 1063 |
- assert.Assert(c, out, checker.Not(checker.Equals), "<no value>\n") |
|
| 1063 |
+ assert.Assert(c, out != "<no value>\n") |
|
| 1064 | 1064 |
} |
| 1065 | 1065 |
} |
| 1066 | 1066 |
|
| ... | ... |
@@ -1166,7 +1166,7 @@ func verifyPortMap(c *testing.T, container, port, originalMapping string, mustBe |
| 1166 | 1166 |
if mustBeEqual {
|
| 1167 | 1167 |
assert.Assert(c, currentMapping, checker.Equals, originalMapping) |
| 1168 | 1168 |
} else {
|
| 1169 |
- assert.Assert(c, currentMapping, checker.Not(checker.Equals), originalMapping) |
|
| 1169 |
+ assert.Assert(c, currentMapping != originalMapping) |
|
| 1170 | 1170 |
} |
| 1171 | 1171 |
} |
| 1172 | 1172 |
|
| ... | ... |
@@ -1216,7 +1216,7 @@ func (s *DockerNetworkSuite) TestDockerNetworkConnectWithMac(c *testing.T) {
|
| 1216 | 1216 |
assert.Assert(c, strings.TrimSpace(mac1), checker.Equals, macAddress) |
| 1217 | 1217 |
dockerCmd(c, "network", "connect", "mynetwork", "test") |
| 1218 | 1218 |
mac2 := inspectField(c, "test", "NetworkSettings.Networks.mynetwork.MacAddress") |
| 1219 |
- assert.Assert(c, strings.TrimSpace(mac2), checker.Not(checker.Equals), strings.TrimSpace(mac1)) |
|
| 1219 |
+ assert.Assert(c, strings.TrimSpace(mac2) != strings.TrimSpace(mac1)) |
|
| 1220 | 1220 |
} |
| 1221 | 1221 |
|
| 1222 | 1222 |
func (s *DockerNetworkSuite) TestDockerNetworkInspectCreatedContainer(c *testing.T) {
|
| ... | ... |
@@ -192,19 +192,19 @@ func (s *DockerSuite) TestPruneContainerLabel(c *testing.T) {
|
| 192 | 192 |
func (s *DockerSuite) TestPruneVolumeLabel(c *testing.T) {
|
| 193 | 193 |
out, _ := dockerCmd(c, "volume", "create", "--label", "foo") |
| 194 | 194 |
id1 := strings.TrimSpace(out) |
| 195 |
- assert.Assert(c, id1, checker.Not(checker.Equals), "") |
|
| 195 |
+ assert.Assert(c, id1 != "") |
|
| 196 | 196 |
|
| 197 | 197 |
out, _ = dockerCmd(c, "volume", "create", "--label", "bar") |
| 198 | 198 |
id2 := strings.TrimSpace(out) |
| 199 |
- assert.Assert(c, id2, checker.Not(checker.Equals), "") |
|
| 199 |
+ assert.Assert(c, id2 != "") |
|
| 200 | 200 |
|
| 201 | 201 |
out, _ = dockerCmd(c, "volume", "create") |
| 202 | 202 |
id3 := strings.TrimSpace(out) |
| 203 |
- assert.Assert(c, id3, checker.Not(checker.Equals), "") |
|
| 203 |
+ assert.Assert(c, id3 != "") |
|
| 204 | 204 |
|
| 205 | 205 |
out, _ = dockerCmd(c, "volume", "create", "--label", "foobar") |
| 206 | 206 |
id4 := strings.TrimSpace(out) |
| 207 |
- assert.Assert(c, id4, checker.Not(checker.Equals), "") |
|
| 207 |
+ assert.Assert(c, id4 != "") |
|
| 208 | 208 |
|
| 209 | 209 |
// Add a config file of label=foobar, that will have no impact if cli is label!=foobar |
| 210 | 210 |
config := `{"pruneFilters": ["label=foobar"]}`
|
| ... | ... |
@@ -605,7 +605,7 @@ func (s *DockerSuite) TestPsNotShowPortsOfStoppedContainer(c *testing.T) {
|
| 605 | 605 |
out, _ = dockerCmd(c, "ps", "-l") |
| 606 | 606 |
lines = strings.Split(strings.TrimSpace(string(out)), "\n") |
| 607 | 607 |
fields = strings.Fields(lines[1]) |
| 608 |
- assert.Assert(c, fields[len(fields)-2], checker.Not(checker.Equals), expected, check.Commentf("Should not got %v", expected))
|
|
| 608 |
+ assert.Assert(c, fields[len(fields)-2] != expected, check.Commentf("Should not got %v", expected))
|
|
| 609 | 609 |
} |
| 610 | 610 |
|
| 611 | 611 |
func (s *DockerSuite) TestPsShowMounts(c *testing.T) {
|
| ... | ... |
@@ -822,24 +822,24 @@ func (s *DockerSuite) TestPsListContainersFilterPorts(c *testing.T) {
|
| 822 | 822 |
assert.Assert(c, strings.TrimSpace(out), checker.Contains, id2) |
| 823 | 823 |
|
| 824 | 824 |
out, _ = dockerCmd(c, "ps", "--no-trunc", "-q", "--filter", "publish=80-8080/udp") |
| 825 |
- assert.Assert(c, strings.TrimSpace(out), checker.Not(checker.Equals), id1) |
|
| 826 |
- assert.Assert(c, strings.TrimSpace(out), checker.Not(checker.Equals), id2) |
|
| 825 |
+ assert.Assert(c, strings.TrimSpace(out) != id1) |
|
| 826 |
+ assert.Assert(c, strings.TrimSpace(out) != id2) |
|
| 827 | 827 |
|
| 828 | 828 |
out, _ = dockerCmd(c, "ps", "--no-trunc", "-q", "--filter", "expose=8081") |
| 829 |
- assert.Assert(c, strings.TrimSpace(out), checker.Not(checker.Equals), id1) |
|
| 830 |
- assert.Assert(c, strings.TrimSpace(out), checker.Not(checker.Equals), id2) |
|
| 829 |
+ assert.Assert(c, strings.TrimSpace(out) != id1) |
|
| 830 |
+ assert.Assert(c, strings.TrimSpace(out) != id2) |
|
| 831 | 831 |
|
| 832 | 832 |
out, _ = dockerCmd(c, "ps", "--no-trunc", "-q", "--filter", "publish=80-81") |
| 833 | 833 |
assert.Equal(c, strings.TrimSpace(out), id1) |
| 834 |
- assert.Assert(c, strings.TrimSpace(out), checker.Not(checker.Equals), id2) |
|
| 834 |
+ assert.Assert(c, strings.TrimSpace(out) != id2) |
|
| 835 | 835 |
|
| 836 | 836 |
out, _ = dockerCmd(c, "ps", "--no-trunc", "-q", "--filter", "expose=80/tcp") |
| 837 | 837 |
assert.Equal(c, strings.TrimSpace(out), id1) |
| 838 |
- assert.Assert(c, strings.TrimSpace(out), checker.Not(checker.Equals), id2) |
|
| 838 |
+ assert.Assert(c, strings.TrimSpace(out) != id2) |
|
| 839 | 839 |
|
| 840 | 840 |
out, _ = dockerCmd(c, "ps", "--no-trunc", "-q", "--filter", "expose=8080/tcp") |
| 841 | 841 |
out = RemoveOutputForExistingElements(out, existingContainers) |
| 842 |
- assert.Assert(c, strings.TrimSpace(out), checker.Not(checker.Equals), id1) |
|
| 842 |
+ assert.Assert(c, strings.TrimSpace(out) != id1) |
|
| 843 | 843 |
assert.Equal(c, strings.TrimSpace(out), id2) |
| 844 | 844 |
} |
| 845 | 845 |
|
| ... | ... |
@@ -3855,7 +3855,7 @@ func (s *DockerSuite) TestRunVolumesMountedAsSlave(c *testing.T) {
|
| 3855 | 3855 |
func (s *DockerSuite) TestRunNamedVolumesMountedAsShared(c *testing.T) {
|
| 3856 | 3856 |
testRequires(c, DaemonIsLinux, NotUserNamespace) |
| 3857 | 3857 |
out, exitCode, _ := dockerCmdWithError("run", "-v", "foo:/test:shared", "busybox", "touch", "/test/somefile")
|
| 3858 |
- assert.Assert(c, exitCode, checker.Not(checker.Equals), 0) |
|
| 3858 |
+ assert.Assert(c, exitCode != 0) |
|
| 3859 | 3859 |
assert.Assert(c, out, checker.Contains, "invalid mount config") |
| 3860 | 3860 |
} |
| 3861 | 3861 |
|
| ... | ... |
@@ -3909,7 +3909,7 @@ func (s *DockerSuite) TestRunNamedVolumesFromNotRemoved(c *testing.T) {
|
| 3909 | 3909 |
vname = v.Name |
| 3910 | 3910 |
} |
| 3911 | 3911 |
} |
| 3912 |
- assert.Assert(c, vname, checker.Not(checker.Equals), "") |
|
| 3912 |
+ assert.Assert(c, vname != "") |
|
| 3913 | 3913 |
|
| 3914 | 3914 |
// Remove the parent so there are not other references to the volumes |
| 3915 | 3915 |
dockerCmd(c, "rm", "-f", "parent") |
| ... | ... |
@@ -129,8 +129,8 @@ func (s *DockerSuite) TestSaveImageId(c *testing.T) {
|
| 129 | 129 |
cleanedShortImageID := strings.TrimSpace(out) |
| 130 | 130 |
|
| 131 | 131 |
// Make sure IDs are not empty |
| 132 |
- assert.Assert(c, cleanedLongImageID, checker.Not(checker.Equals), "", check.Commentf("Id should not be empty."))
|
|
| 133 |
- assert.Assert(c, cleanedShortImageID, checker.Not(checker.Equals), "", check.Commentf("Id should not be empty."))
|
|
| 132 |
+ assert.Assert(c, cleanedLongImageID != "", check.Commentf("Id should not be empty."))
|
|
| 133 |
+ assert.Assert(c, cleanedShortImageID != "", check.Commentf("Id should not be empty."))
|
|
| 134 | 134 |
|
| 135 | 135 |
saveCmd := exec.Command(dockerBinary, "save", cleanedShortImageID) |
| 136 | 136 |
tarCmd := exec.Command("tar", "t")
|
| ... | ... |
@@ -75,7 +75,7 @@ func (s *DockerSwarmSuite) TestServiceCreateWithSecretSimple(c *testing.T) {
|
| 75 | 75 |
}, |
| 76 | 76 |
Data: []byte("TESTINGDATA"),
|
| 77 | 77 |
}) |
| 78 |
- assert.Assert(c, id, checker.Not(checker.Equals), "", check.Commentf("secrets: %s", id))
|
|
| 78 |
+ assert.Assert(c, id != "", check.Commentf("secrets: %s", id))
|
|
| 79 | 79 |
|
| 80 | 80 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", serviceName, "--secret", testName, "busybox", "top")
|
| 81 | 81 |
assert.NilError(c, err, out) |
| ... | ... |
@@ -117,7 +117,7 @@ func (s *DockerSwarmSuite) TestServiceCreateWithSecretSourceTargetPaths(c *testi |
| 117 | 117 |
}, |
| 118 | 118 |
Data: []byte("TESTINGDATA " + testName + " " + testTarget),
|
| 119 | 119 |
}) |
| 120 |
- assert.Assert(c, id, checker.Not(checker.Equals), "", check.Commentf("secrets: %s", id))
|
|
| 120 |
+ assert.Assert(c, id != "", check.Commentf("secrets: %s", id))
|
|
| 121 | 121 |
|
| 122 | 122 |
secretFlags = append(secretFlags, "--secret", fmt.Sprintf("source=%s,target=%s", testName, testTarget))
|
| 123 | 123 |
} |
| ... | ... |
@@ -173,7 +173,7 @@ func (s *DockerSwarmSuite) TestServiceCreateWithSecretReferencedTwice(c *testing |
| 173 | 173 |
}, |
| 174 | 174 |
Data: []byte("TESTINGDATA"),
|
| 175 | 175 |
}) |
| 176 |
- assert.Assert(c, id, checker.Not(checker.Equals), "", check.Commentf("secrets: %s", id))
|
|
| 176 |
+ assert.Assert(c, id != "", check.Commentf("secrets: %s", id))
|
|
| 177 | 177 |
|
| 178 | 178 |
serviceName := "svc" |
| 179 | 179 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", serviceName, "--secret", "source=mysecret,target=target1", "--secret", "source=mysecret,target=target2", "busybox", "top")
|
| ... | ... |
@@ -223,7 +223,7 @@ func (s *DockerSwarmSuite) TestServiceCreateWithConfigSimple(c *testing.T) {
|
| 223 | 223 |
}, |
| 224 | 224 |
Data: []byte("TESTINGDATA"),
|
| 225 | 225 |
}) |
| 226 |
- assert.Assert(c, id, checker.Not(checker.Equals), "", check.Commentf("configs: %s", id))
|
|
| 226 |
+ assert.Assert(c, id != "", check.Commentf("configs: %s", id))
|
|
| 227 | 227 |
|
| 228 | 228 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", serviceName, "--config", testName, "busybox", "top")
|
| 229 | 229 |
assert.NilError(c, err, out) |
| ... | ... |
@@ -264,7 +264,7 @@ func (s *DockerSwarmSuite) TestServiceCreateWithConfigSourceTargetPaths(c *testi |
| 264 | 264 |
}, |
| 265 | 265 |
Data: []byte("TESTINGDATA " + testName + " " + testTarget),
|
| 266 | 266 |
}) |
| 267 |
- assert.Assert(c, id, checker.Not(checker.Equals), "", check.Commentf("configs: %s", id))
|
|
| 267 |
+ assert.Assert(c, id != "", check.Commentf("configs: %s", id))
|
|
| 268 | 268 |
|
| 269 | 269 |
configFlags = append(configFlags, "--config", fmt.Sprintf("source=%s,target=%s", testName, testTarget))
|
| 270 | 270 |
} |
| ... | ... |
@@ -320,7 +320,7 @@ func (s *DockerSwarmSuite) TestServiceCreateWithConfigReferencedTwice(c *testing |
| 320 | 320 |
}, |
| 321 | 321 |
Data: []byte("TESTINGDATA"),
|
| 322 | 322 |
}) |
| 323 |
- assert.Assert(c, id, checker.Not(checker.Equals), "", check.Commentf("configs: %s", id))
|
|
| 323 |
+ assert.Assert(c, id != "", check.Commentf("configs: %s", id))
|
|
| 324 | 324 |
|
| 325 | 325 |
serviceName := "svc" |
| 326 | 326 |
out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", serviceName, "--config", "source=myconfig,target=target1", "--config", "source=myconfig,target=target2", "busybox", "top")
|
| ... | ... |
@@ -626,7 +626,7 @@ func (s *DockerSwarmSuite) TestPsListContainersFilterIsTask(c *testing.T) {
|
| 626 | 626 |
assert.NilError(c, err, out) |
| 627 | 627 |
lines := strings.Split(strings.Trim(out, "\n "), "\n") |
| 628 | 628 |
assert.Equal(c, len(lines), 1) |
| 629 |
- assert.Assert(c, lines[0], checker.Not(checker.Equals), bareID, check.Commentf("Expected not %s, but got it for is-task label, output %q", bareID, out))
|
|
| 629 |
+ assert.Assert(c, lines[0] != bareID, check.Commentf("Expected not %s, but got it for is-task label, output %q", bareID, out))
|
|
| 630 | 630 |
} |
| 631 | 631 |
|
| 632 | 632 |
const globalNetworkPlugin = "global-network-plugin" |
| ... | ... |
@@ -1263,8 +1263,8 @@ func (s *DockerSwarmSuite) TestSwarmRotateUnlockKey(c *testing.T) {
|
| 1263 | 1263 |
assert.Assert(c, err, checker.IsNil, check.Commentf("out: %v", outs))
|
| 1264 | 1264 |
// Strip \n |
| 1265 | 1265 |
newUnlockKey := outs[:len(outs)-1] |
| 1266 |
- assert.Assert(c, newUnlockKey, checker.Not(checker.Equals), "") |
|
| 1267 |
- assert.Assert(c, newUnlockKey, checker.Not(checker.Equals), unlockKey) |
|
| 1266 |
+ assert.Assert(c, newUnlockKey != "") |
|
| 1267 |
+ assert.Assert(c, newUnlockKey != unlockKey) |
|
| 1268 | 1268 |
|
| 1269 | 1269 |
d.RestartNode(c) |
| 1270 | 1270 |
assert.Assert(c, getNodeStatus(c, d), checker.Equals, swarm.LocalNodeStateLocked) |
| ... | ... |
@@ -1352,8 +1352,8 @@ func (s *DockerSwarmSuite) TestSwarmClusterRotateUnlockKey(c *testing.T) {
|
| 1352 | 1352 |
assert.Assert(c, err, checker.IsNil, check.Commentf("%s", outs))
|
| 1353 | 1353 |
// Strip \n |
| 1354 | 1354 |
newUnlockKey := outs[:len(outs)-1] |
| 1355 |
- assert.Assert(c, newUnlockKey, checker.Not(checker.Equals), "") |
|
| 1356 |
- assert.Assert(c, newUnlockKey, checker.Not(checker.Equals), unlockKey) |
|
| 1355 |
+ assert.Assert(c, newUnlockKey != "") |
|
| 1356 |
+ assert.Assert(c, newUnlockKey != unlockKey) |
|
| 1357 | 1357 |
|
| 1358 | 1358 |
d2.RestartNode(c) |
| 1359 | 1359 |
d3.RestartNode(c) |
| ... | ... |
@@ -1520,7 +1520,7 @@ func (s *DockerSwarmSuite) TestSwarmNetworkCreateIssue27866(c *testing.T) {
|
| 1520 | 1520 |
out, err := d.Cmd("network", "inspect", "-f", "{{.Id}}", "ingress")
|
| 1521 | 1521 |
assert.NilError(c, err, "out: %v", out) |
| 1522 | 1522 |
ingressID := strings.TrimSpace(out) |
| 1523 |
- assert.Assert(c, ingressID, checker.Not(checker.Equals), "") |
|
| 1523 |
+ assert.Assert(c, ingressID != "") |
|
| 1524 | 1524 |
|
| 1525 | 1525 |
// create a network of which name is the prefix of the ID of an overlay network |
| 1526 | 1526 |
// (ingressID in this case) |
| ... | ... |
@@ -1833,7 +1833,7 @@ func (s *DockerSwarmSuite) TestSwarmClusterEventsSource(c *testing.T) {
|
| 1833 | 1833 |
out, err := d1.Cmd("network", "create", "--attachable", "-d", "overlay", "foo")
|
| 1834 | 1834 |
assert.NilError(c, err, out) |
| 1835 | 1835 |
networkID := strings.TrimSpace(out) |
| 1836 |
- assert.Assert(c, networkID, checker.Not(checker.Equals), "") |
|
| 1836 |
+ assert.Assert(c, networkID != "") |
|
| 1837 | 1837 |
|
| 1838 | 1838 |
// d1, d2 are managers that can get swarm events |
| 1839 | 1839 |
waitForEvent(c, d1, "0", "-f scope=swarm", "network create "+networkID, defaultRetryCount) |
| ... | ... |
@@ -1877,7 +1877,7 @@ func (s *DockerSwarmSuite) TestSwarmClusterEventsType(c *testing.T) {
|
| 1877 | 1877 |
out, err = d.Cmd("network", "create", "--attachable", "-d", "overlay", "foo")
|
| 1878 | 1878 |
assert.NilError(c, err, out) |
| 1879 | 1879 |
networkID := strings.TrimSpace(out) |
| 1880 |
- assert.Assert(c, networkID, checker.Not(checker.Equals), "") |
|
| 1880 |
+ assert.Assert(c, networkID != "") |
|
| 1881 | 1881 |
|
| 1882 | 1882 |
// filter by service |
| 1883 | 1883 |
out = waitForEvent(c, d, "0", "-f type=service", "service create "+serviceID, defaultRetryCount) |
| ... | ... |
@@ -1987,7 +1987,7 @@ func (s *DockerSwarmSuite) TestSwarmClusterEventsSecret(c *testing.T) {
|
| 1987 | 1987 |
}, |
| 1988 | 1988 |
Data: []byte("TESTINGDATA"),
|
| 1989 | 1989 |
}) |
| 1990 |
- assert.Assert(c, id, checker.Not(checker.Equals), "", check.Commentf("secrets: %s", id))
|
|
| 1990 |
+ assert.Assert(c, id != "", check.Commentf("secrets: %s", id))
|
|
| 1991 | 1991 |
|
| 1992 | 1992 |
waitForEvent(c, d, "0", "-f scope=swarm", "secret create "+id, defaultRetryCount) |
| 1993 | 1993 |
|
| ... | ... |
@@ -2007,7 +2007,7 @@ func (s *DockerSwarmSuite) TestSwarmClusterEventsConfig(c *testing.T) {
|
| 2007 | 2007 |
}, |
| 2008 | 2008 |
Data: []byte("TESTINGDATA"),
|
| 2009 | 2009 |
}) |
| 2010 |
- assert.Assert(c, id, checker.Not(checker.Equals), "", check.Commentf("configs: %s", id))
|
|
| 2010 |
+ assert.Assert(c, id != "", check.Commentf("configs: %s", id))
|
|
| 2011 | 2011 |
|
| 2012 | 2012 |
waitForEvent(c, d, "0", "-f scope=swarm", "config create "+id, defaultRetryCount) |
| 2013 | 2013 |
|
| ... | ... |
@@ -476,11 +476,11 @@ func (s *DockerSuite) TestDuplicateMountpointsForVolumesFrom(c *testing.T) {
|
| 476 | 476 |
|
| 477 | 477 |
out, _ := dockerCmd(c, "inspect", "--format", "{{(index .Mounts 0).Name}}", "data1")
|
| 478 | 478 |
data1 := strings.TrimSpace(out) |
| 479 |
- assert.Assert(c, data1, checker.Not(checker.Equals), "") |
|
| 479 |
+ assert.Assert(c, data1 != "") |
|
| 480 | 480 |
|
| 481 | 481 |
out, _ = dockerCmd(c, "inspect", "--format", "{{(index .Mounts 0).Name}}", "data2")
|
| 482 | 482 |
data2 := strings.TrimSpace(out) |
| 483 |
- assert.Assert(c, data2, checker.Not(checker.Equals), "") |
|
| 483 |
+ assert.Assert(c, data2 != "") |
|
| 484 | 484 |
|
| 485 | 485 |
// Both volume should exist |
| 486 | 486 |
out, _ = dockerCmd(c, "volume", "ls", "-q") |
| ... | ... |
@@ -518,11 +518,11 @@ func (s *DockerSuite) TestDuplicateMountpointsForVolumesFromAndBind(c *testing.T |
| 518 | 518 |
|
| 519 | 519 |
out, _ := dockerCmd(c, "inspect", "--format", "{{(index .Mounts 0).Name}}", "data1")
|
| 520 | 520 |
data1 := strings.TrimSpace(out) |
| 521 |
- assert.Assert(c, data1, checker.Not(checker.Equals), "") |
|
| 521 |
+ assert.Assert(c, data1 != "") |
|
| 522 | 522 |
|
| 523 | 523 |
out, _ = dockerCmd(c, "inspect", "--format", "{{(index .Mounts 0).Name}}", "data2")
|
| 524 | 524 |
data2 := strings.TrimSpace(out) |
| 525 |
- assert.Assert(c, data2, checker.Not(checker.Equals), "") |
|
| 525 |
+ assert.Assert(c, data2 != "") |
|
| 526 | 526 |
|
| 527 | 527 |
// Both volume should exist |
| 528 | 528 |
out, _ = dockerCmd(c, "volume", "ls", "-q") |
| ... | ... |
@@ -562,11 +562,11 @@ func (s *DockerSuite) TestDuplicateMountpointsForVolumesFromAndMounts(c *testing |
| 562 | 562 |
|
| 563 | 563 |
out, _ := dockerCmd(c, "inspect", "--format", "{{(index .Mounts 0).Name}}", "data1")
|
| 564 | 564 |
data1 := strings.TrimSpace(out) |
| 565 |
- assert.Assert(c, data1, checker.Not(checker.Equals), "") |
|
| 565 |
+ assert.Assert(c, data1 != "") |
|
| 566 | 566 |
|
| 567 | 567 |
out, _ = dockerCmd(c, "inspect", "--format", "{{(index .Mounts 0).Name}}", "data2")
|
| 568 | 568 |
data2 := strings.TrimSpace(out) |
| 569 |
- assert.Assert(c, data2, checker.Not(checker.Equals), "") |
|
| 569 |
+ assert.Assert(c, data2 != "") |
|
| 570 | 570 |
|
| 571 | 571 |
// Both volume should exist |
| 572 | 572 |
out, _ = dockerCmd(c, "volume", "ls", "-q") |