Browse code

add a test to make sure port is allowed in images filter

Signed-off-by: Shijiang Wei <mountkin@gmail.com>

Shijiang Wei authored on 2015/11/25 11:43:14
Showing 1 changed files
... ...
@@ -20,24 +20,22 @@ func (s *DockerSuite) TestImagesEnsureImageIsListed(c *check.C) {
20 20
 
21 21
 func (s *DockerSuite) TestImagesEnsureImageWithTagIsListed(c *check.C) {
22 22
 	testRequires(c, DaemonIsLinux)
23
-	_, err := buildImage("imagewithtag:v1",
24
-		`FROM scratch
25
-		MAINTAINER dockerio1`, true)
26
-	c.Assert(err, check.IsNil)
27 23
 
28
-	_, err = buildImage("imagewithtag:v2",
29
-		`FROM scratch
30
-		MAINTAINER dockerio1`, true)
31
-	c.Assert(err, check.IsNil)
24
+	name := "imagewithtag"
25
+	dockerCmd(c, "tag", "busybox", name+":v1")
26
+	dockerCmd(c, "tag", "busybox", name+":v1v1")
27
+	dockerCmd(c, "tag", "busybox", name+":v2")
32 28
 
33
-	imagesOut, _ := dockerCmd(c, "images", "imagewithtag:v1")
34
-	c.Assert(imagesOut, checker.Contains, "imagewithtag")
29
+	imagesOut, _ := dockerCmd(c, "images", name+":v1")
30
+	c.Assert(imagesOut, checker.Contains, name)
35 31
 	c.Assert(imagesOut, checker.Contains, "v1")
36 32
 	c.Assert(imagesOut, checker.Not(checker.Contains), "v2")
33
+	c.Assert(imagesOut, checker.Not(checker.Contains), "v1v1")
37 34
 
38
-	imagesOut, _ = dockerCmd(c, "images", "imagewithtag")
39
-	c.Assert(imagesOut, checker.Contains, "imagewithtag")
35
+	imagesOut, _ = dockerCmd(c, "images", name)
36
+	c.Assert(imagesOut, checker.Contains, name)
40 37
 	c.Assert(imagesOut, checker.Contains, "v1")
38
+	c.Assert(imagesOut, checker.Contains, "v1v1")
41 39
 	c.Assert(imagesOut, checker.Contains, "v2")
42 40
 }
43 41
 
... ...
@@ -221,3 +219,17 @@ func (s *DockerSuite) TestImagesEnsureImagesFromScratchShown(c *check.C) {
221 221
 	// images should contain images built from scratch
222 222
 	c.Assert(out, checker.Contains, stringid.TruncateID(id))
223 223
 }
224
+
225
+// #18181
226
+func (s *DockerSuite) TestImagesFilterNameWithPort(c *check.C) {
227
+	tag := "a.b.c.d:5000/hello"
228
+	dockerCmd(c, "tag", "busybox", tag)
229
+	out, _ := dockerCmd(c, "images", tag)
230
+	c.Assert(out, checker.Contains, tag)
231
+
232
+	out, _ = dockerCmd(c, "images", tag+":latest")
233
+	c.Assert(out, checker.Contains, tag)
234
+
235
+	out, _ = dockerCmd(c, "images", tag+":no-such-tag")
236
+	c.Assert(out, checker.Not(checker.Contains), tag)
237
+}