Browse code

Remove -lpthread and -ldl from ldflags

There is no need in those flags now when we use amalgamated sqlite3 from
mattn/go-sqlite3.

Signed-off-by: Alexander Morozov <lk4d4@docker.com>

Alexander Morozov authored on 2015/09/09 03:29:43
Showing 4 changed files
... ...
@@ -150,12 +150,9 @@ BUILDFLAGS=( $BUILDFLAGS "${ORIG_BUILDFLAGS[@]}" )
150 150
 : ${TIMEOUT:=60m}
151 151
 TESTFLAGS+=" -test.timeout=${TIMEOUT}"
152 152
 
153
-# A few more flags that are specific just to building a completely-static binary (see hack/make/binary)
154
-# PLEASE do not use these anywhere else.
155
-EXTLDFLAGS_STATIC_DOCKER="$EXTLDFLAGS_STATIC -lpthread -ldl"
156 153
 LDFLAGS_STATIC_DOCKER="
157 154
 	$LDFLAGS_STATIC
158
-	-extldflags \"$EXTLDFLAGS_STATIC_DOCKER\"
155
+	-extldflags \"$EXTLDFLAGS_STATIC\"
159 156
 "
160 157
 
161 158
 if [ "$(uname -s)" = 'FreeBSD' ]; then
... ...
@@ -11,7 +11,7 @@ go build --compiler=gccgo \
11 11
 	--gccgoflags "
12 12
 		-g
13 13
 		-Wl,--no-export-dynamic
14
-		$EXTLDFLAGS_STATIC_DOCKER
14
+		$EXTLDFLAGS_STATIC
15 15
 		-lnetgo
16 16
 	" \
17 17
 	./dockerinit
... ...
@@ -13,7 +13,7 @@ fi
13 13
 
14 14
 (
15 15
 	export IAMSTATIC="false"
16
-	export EXTLDFLAGS_STATIC_DOCKER=''
16
+	export EXTLDFLAGS_STATIC=''
17 17
 	export LDFLAGS_STATIC_DOCKER=''
18 18
 	export BUILDFLAGS=( "${BUILDFLAGS[@]/netgo /}" ) # disable netgo, since we don't need it for a dynamic binary
19 19
 	export BUILDFLAGS=( "${BUILDFLAGS[@]/static_build /}" ) # we're not building a "static" binary here
... ...
@@ -8,14 +8,14 @@ BINARY_FULLNAME="$BINARY_NAME$BINARY_EXTENSION"
8 8
 source "${MAKEDIR}/.go-autogen"
9 9
 
10 10
 if [[ "${BUILDFLAGS[@]}" =~ 'netgo ' ]]; then
11
-	EXTLDFLAGS_STATIC_DOCKER+=' -lnetgo'
11
+	EXTLDFLAGS_STATIC+=' -lnetgo'
12 12
 fi
13 13
 go build -compiler=gccgo \
14 14
 	-o "$DEST/$BINARY_FULLNAME" \
15 15
 	"${BUILDFLAGS[@]}" \
16 16
 	-gccgoflags "
17 17
 		-g
18
-		$EXTLDFLAGS_STATIC_DOCKER
18
+		$EXTLDFLAGS_STATIC
19 19
 		-Wl,--no-export-dynamic
20 20
 		-ldl
21 21
 	" \