Signed-off-by: John Howard <jhoward@microsoft.com>
| ... | ... |
@@ -6,10 +6,10 @@ |
| 6 | 6 |
builder/** @tonistiigi |
| 7 | 7 |
contrib/mkimage/** @tianon |
| 8 | 8 |
daemon/graphdriver/devmapper/** @rhvgoyal |
| 9 |
-daemon/graphdriver/lcow/** @johnstep @jhowardmsft |
|
| 9 |
+daemon/graphdriver/lcow/** @johnstep |
|
| 10 | 10 |
daemon/graphdriver/overlay/** @dmcgowan |
| 11 | 11 |
daemon/graphdriver/overlay2/** @dmcgowan |
| 12 |
-daemon/graphdriver/windows/** @johnstep @jhowardmsft |
|
| 12 |
+daemon/graphdriver/windows/** @johnstep |
|
| 13 | 13 |
daemon/logger/awslogs/** @samuelkarp |
| 14 | 14 |
hack/** @tianon |
| 15 | 15 |
plugin/** @cpuguy83 |
| ... | ... |
@@ -257,7 +257,7 @@ func (container *Container) WriteHostConfig() (*containertypes.HostConfig, error |
| 257 | 257 |
|
| 258 | 258 |
// SetupWorkingDirectory sets up the container's working directory as set in container.Config.WorkingDir |
| 259 | 259 |
func (container *Container) SetupWorkingDirectory(rootIdentity idtools.Identity) error {
|
| 260 |
- // TODO @jhowardmsft, @gupta-ak LCOW Support. This will need revisiting. |
|
| 260 |
+ // TODO: LCOW Support. This will need revisiting. |
|
| 261 | 261 |
// We will need to do remote filesystem operations here. |
| 262 | 262 |
if container.OS != runtime.GOOS {
|
| 263 | 263 |
return nil |
| ... | ... |
@@ -97,7 +97,7 @@ func (c *containerAdapter) pullImage(ctx context.Context) error {
|
| 97 | 97 |
pr, pw := io.Pipe() |
| 98 | 98 |
metaHeaders := map[string][]string{}
|
| 99 | 99 |
go func() {
|
| 100 |
- // TODO @jhowardmsft LCOW Support: This will need revisiting as |
|
| 100 |
+ // TODO LCOW Support: This will need revisiting as |
|
| 101 | 101 |
// the stack is built up to include LCOW support for swarm. |
| 102 | 102 |
err := c.imageBackend.PullImage(ctx, c.container.image(), "", nil, metaHeaders, authConfig, pw) |
| 103 | 103 |
pw.CloseWithError(err) |
| ... | ... |
@@ -201,7 +201,7 @@ func verifyPlatformContainerSettings(daemon *Daemon, hostConfig *containertypes. |
| 201 | 201 |
// On RS5, we allow (but don't strictly support) process isolation on Client SKUs. |
| 202 | 202 |
// Prior to RS5, we don't allow process isolation on Client SKUs. |
| 203 | 203 |
// @engine maintainers. This block should not be removed. It partially enforces licensing |
| 204 |
- // restrictions on Windows. Ping @jhowardmsft if there are concerns or PRs to change this. |
|
| 204 |
+ // restrictions on Windows. Ping Microsoft folks if there are concerns or PRs to change this. |
|
| 205 | 205 |
if !hyperv && system.IsWindowsClient() && osv.Build < 17763 {
|
| 206 | 206 |
return warnings, fmt.Errorf("Windows client operating systems earlier than version 1809 can only run Hyper-V containers")
|
| 207 | 207 |
} |
| ... | ... |
@@ -604,7 +604,7 @@ func (daemon *Daemon) setDefaultIsolation() error {
|
| 604 | 604 |
osv := system.GetOSVersion() |
| 605 | 605 |
|
| 606 | 606 |
// On client SKUs, default to Hyper-V. @engine maintainers. This |
| 607 |
- // should not be removed. Ping @jhowardmsft is there are PRs to |
|
| 607 |
+ // should not be removed. Ping Microsoft folks is there are PRs to |
|
| 608 | 608 |
// to change this. |
| 609 | 609 |
if system.IsWindowsClient() {
|
| 610 | 610 |
daemon.defaultIsolation = containertypes.Isolation("hyperv")
|
| ... | ... |
@@ -628,7 +628,7 @@ func (daemon *Daemon) setDefaultIsolation() error {
|
| 628 | 628 |
if system.IsWindowsClient() && osv.Build < 17763 {
|
| 629 | 629 |
// On RS5, we allow (but don't strictly support) process isolation on Client SKUs. |
| 630 | 630 |
// @engine maintainers. This block should not be removed. It partially enforces licensing |
| 631 |
- // restrictions on Windows. Ping @jhowardmsft if there are concerns or PRs to change this. |
|
| 631 |
+ // restrictions on Windows. Ping Microsoft folks if there are concerns or PRs to change this. |
|
| 632 | 632 |
return fmt.Errorf("Windows client operating systems earlier than version 1809 can only run Hyper-V containers")
|
| 633 | 633 |
} |
| 634 | 634 |
daemon.defaultIsolation = containertypes.Isolation("process")
|
| ... | ... |
@@ -286,7 +286,7 @@ func (d *Driver) Remove(id string) error {
|
| 286 | 286 |
// in RS1 and RS2 building during enumeration when a silo is going away |
| 287 | 287 |
// for example under it, in HCS. AccessIsDenied added to fix 30278. |
| 288 | 288 |
// |
| 289 |
- // TODO @jhowardmsft - For RS3, we can remove the retries. Also consider |
|
| 289 |
+ // TODO: For RS3, we can remove the retries. Also consider |
|
| 290 | 290 |
// using platform APIs (if available) to get this more succinctly. Also |
| 291 | 291 |
// consider enhancing the Remove() interface to have context of why |
| 292 | 292 |
// the remove is being called - that could improve efficiency by not |
| ... | ... |
@@ -370,7 +370,7 @@ func (daemon *Daemon) setWindowsCredentialSpec(c *container.Container, s *specs. |
| 370 | 370 |
} |
| 371 | 371 |
|
| 372 | 372 |
// Sets the Linux-specific fields of the OCI spec |
| 373 |
-// TODO: @jhowardmsft LCOW Support. We need to do a lot more pulling in what can |
|
| 373 |
+// TODO: LCOW Support. We need to do a lot more pulling in what can |
|
| 374 | 374 |
// be pulled in from oci_linux.go. |
| 375 | 375 |
func (daemon *Daemon) createSpecLinuxFields(c *container.Container, s *specs.Spec) error {
|
| 376 | 376 |
s.Root = &specs.Root{
|
| ... | ... |
@@ -15,7 +15,7 @@ func (daemon *Daemon) getLibcontainerdCreateOptions(container *container.Contain |
| 15 | 15 |
return opts, nil |
| 16 | 16 |
} |
| 17 | 17 |
|
| 18 |
- // TODO @jhowardmsft (containerd) - Probably need to revisit LCOW options here |
|
| 18 |
+ // TODO (containerd) - Probably need to revisit LCOW options here |
|
| 19 | 19 |
// rather than blindly ignoring them. |
| 20 | 20 |
|
| 21 | 21 |
// LCOW options. |
| ... | ... |
@@ -89,7 +89,7 @@ func (s *DockerSuite) TestAttachMultipleAndRestart(c *testing.T) {
|
| 89 | 89 |
} |
| 90 | 90 |
|
| 91 | 91 |
func (s *DockerSuite) TestAttachTTYWithoutStdin(c *testing.T) {
|
| 92 |
- // TODO @jhowardmsft. Figure out how to get this running again reliable on Windows. |
|
| 92 |
+ // TODO: Figure out how to get this running again reliable on Windows. |
|
| 93 | 93 |
// It works by accident at the moment. Sometimes. I've gone back to v1.13.0 and see the same. |
| 94 | 94 |
// On Windows, docker run -d -ti busybox causes the container to exit immediately. |
| 95 | 95 |
// Obviously a year back when I updated the test, that was not the case. However, |
| ... | ... |
@@ -390,7 +390,7 @@ func (s *DockerSuite) TestBuildCacheAdd(c *testing.T) {
|
| 390 | 390 |
} |
| 391 | 391 |
|
| 392 | 392 |
func (s *DockerSuite) TestBuildLastModified(c *testing.T) {
|
| 393 |
- // Temporary fix for #30890. TODO @jhowardmsft figure out what |
|
| 393 |
+ // Temporary fix for #30890. TODO: figure out what |
|
| 394 | 394 |
// has changed in the master busybox image. |
| 395 | 395 |
testRequires(c, DaemonIsLinux) |
| 396 | 396 |
|
| ... | ... |
@@ -1347,7 +1347,7 @@ func (s *DockerSuite) TestBuildWindowsWorkdirProcessing(c *testing.T) {
|
| 1347 | 1347 |
// One functional test for end-to-end |
| 1348 | 1348 |
func (s *DockerSuite) TestBuildWindowsAddCopyPathProcessing(c *testing.T) {
|
| 1349 | 1349 |
testRequires(c, DaemonIsWindows) |
| 1350 |
- // TODO Windows (@jhowardmsft). Needs a follow-up PR to 22181 to |
|
| 1350 |
+ // TODO Windows. Needs a follow-up PR to 22181 to |
|
| 1351 | 1351 |
// support backslash such as .\\ being equivalent to ./ and c:\\ being |
| 1352 | 1352 |
// equivalent to c:/. This is not currently (nor ever has been) supported |
| 1353 | 1353 |
// by docker on the Windows platform. |
| ... | ... |
@@ -238,7 +238,7 @@ func (c *client) createWindows(id string, spec *specs.Spec, runtimeOptions inter |
| 238 | 238 |
|
| 239 | 239 |
if configuration.HvPartition {
|
| 240 | 240 |
// We don't currently support setting the utility VM image explicitly. |
| 241 |
- // TODO @swernli/jhowardmsft circa RS5, this may be re-locatable. |
|
| 241 |
+ // TODO circa RS5, this may be re-locatable. |
|
| 242 | 242 |
if spec.Windows.HyperV.UtilityVMPath != "" {
|
| 243 | 243 |
return errors.New("runtime does not support an explicit utility VM path for Hyper-V containers")
|
| 244 | 244 |
} |
| ... | ... |
@@ -1,7 +1,6 @@ |
| 1 | 1 |
package opts // import "github.com/docker/docker/opts" |
| 2 | 2 |
|
| 3 | 3 |
// TODO Windows. Identify bug in GOLang 1.5.1+ and/or Windows Server 2016 TP5. |
| 4 |
-// @jhowardmsft, @swernli. |
|
| 5 | 4 |
// |
| 6 | 5 |
// On Windows, this mitigates a problem with the default options of running |
| 7 | 6 |
// a docker client against a local docker daemon on TP5. |