Browse code

Merge pull request #11686 from willhf/9340_test

Add test for net=container and links

Arnaud Porterie authored on 2015/04/07 05:21:01
Showing 2 changed files
... ...
@@ -125,7 +125,7 @@ func Parse(cmd *flag.FlagSet, args []string) (*Config, *HostConfig, *flag.FlagSe
125 125
 		return nil, nil, cmd, ErrConflictHostNetworkAndLinks
126 126
 	}
127 127
 
128
-	if *flNetMode == "container" && flLinks.Len() > 0 {
128
+	if strings.HasPrefix(*flNetMode, "container") && flLinks.Len() > 0 {
129 129
 		return nil, nil, cmd, ErrConflictContainerNetworkAndLinks
130 130
 	}
131 131
 
... ...
@@ -133,7 +133,7 @@ func Parse(cmd *flag.FlagSet, args []string) (*Config, *HostConfig, *flag.FlagSe
133 133
 		return nil, nil, cmd, ErrConflictHostNetworkAndDns
134 134
 	}
135 135
 
136
-	if *flNetMode == "container" && flDns.Len() > 0 {
136
+	if strings.HasPrefix(*flNetMode, "container") && flDns.Len() > 0 {
137 137
 		return nil, nil, cmd, ErrConflictContainerNetworkAndDns
138 138
 	}
139 139
 
... ...
@@ -57,3 +57,9 @@ func TestNetHostname(t *testing.T) {
57 57
 		t.Fatalf("Expected error ErrConflictNetworkHostname, got: %s", err)
58 58
 	}
59 59
 }
60
+
61
+func TestConflictContainerNetworkAndLinks(t *testing.T) {
62
+	if _, _, _, err := parseRun([]string{"--net=container:other", "--link=zip:zap", "img", "cmd"}); err != ErrConflictContainerNetworkAndLinks {
63
+		t.Fatalf("Expected error ErrConflictContainerNetworkAndLinks, got: %s", err)
64
+	}
65
+}