Browse code

Improve err message when parsing kernel port range

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

Brian Goff authored on 2015/03/22 05:57:22
Showing 1 changed files
... ...
@@ -70,10 +70,11 @@ func NewErrPortAlreadyAllocated(ip string, port int) ErrPortAlreadyAllocated {
70 70
 
71 71
 func init() {
72 72
 	const portRangeKernelParam = "/proc/sys/net/ipv4/ip_local_port_range"
73
+	portRangeFallback := fmt.Sprintf("using fallback port range %d-%d", beginPortRange, endPortRange)
73 74
 
74 75
 	file, err := os.Open(portRangeKernelParam)
75 76
 	if err != nil {
76
-		log.Warnf("Failed to read %s kernel parameter: %v", portRangeKernelParam, err)
77
+		log.Warnf("port allocator - %s due to error: %v", portRangeFallback, err)
77 78
 		return
78 79
 	}
79 80
 	var start, end int
... ...
@@ -82,7 +83,7 @@ func init() {
82 82
 		if err == nil {
83 83
 			err = fmt.Errorf("unexpected count of parsed numbers (%d)", n)
84 84
 		}
85
-		log.Errorf("Failed to parse port range from %s: %v", portRangeKernelParam, err)
85
+		log.Errorf("port allocator - failed to parse system ephemeral port range from %s - %s: %v", portRangeKernelParam, portRangeFallback, err)
86 86
 		return
87 87
 	}
88 88
 	beginPortRange = start