GitList

Browse code

Add a debug message when client closes websocket attach connection

When the client closes websocket connections that sends container
output through websocket, an error message is displayed:
"Error attaching websocket: %!s(<nil>)"

This message is misleading. Thus, this change suggests to check
if error is nil and print the correct message accordingly.

Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>

Boaz Shuster authored on 2017/12/06 23:45:33
Showing 1 changed files

api/server/router/container/container_routes.go

History View file @ 8f65bb6

@@ -593,7 +593,11 @@ func (s *containerRouter) wsContainersAttach(ctx context.Context, w http.Respons
                      	close(done)
                      	select {
                      	case <-started:
                     -		logrus.Errorf("Error attaching websocket: %s", err)
                     +		if err != nil {
                     +			logrus.Errorf("Error attaching websocket: %s", err)
                     +		} else {
                     +			logrus.Debug("websocket connection was closed by client")
                     +		}
                      		return nil
                      	default:
+                     	}